| Message ID | 20230706035522.1817402-2-j-luthra@ti.com |
|---|---|
| State | Superseded |
| Delegated to: | Ryan Eatmon |
| Headers | show |
| Series | [master/kirkstone,v2,1/3] libcamera: Add recipe for v0.0.5 | expand |
On Thu, Jul 06, 2023 at 09:25:21AM +0530, Jai Luthra via lists.yoctoproject.org wrote: > TI's CSI-RX driver is not yet upstream, so the libcamera simple pipeline > does not recognize it. > > Apply a patch to the simple pipeline so that it can recognize the media > entity for TI's CSI-RX driver. > > Signed-off-by: Jai Luthra <j-luthra@ti.com> > --- > > v2: Add upstream information in the patch > Link to v1: https://lore.kernel.org/all/20230705130928.1201894-2-j-luthra@ti.com/ > > .../0001-simple-Support-TI-CSI-RX.patch | 32 +++++++++++++++++++ > .../libcamera/libcamera_0.0.5.bb | 1 + > 2 files changed, 33 insertions(+) > create mode 100644 meta-arago-extras/recipes-multimedia/libcamera/libcamera/0001-simple-Support-TI-CSI-RX.patch > > diff --git a/meta-arago-extras/recipes-multimedia/libcamera/libcamera/0001-simple-Support-TI-CSI-RX.patch b/meta-arago-extras/recipes-multimedia/libcamera/libcamera/0001-simple-Support-TI-CSI-RX.patch > new file mode 100644 > index 00000000..f35b3613 > --- /dev/null > +++ b/meta-arago-extras/recipes-multimedia/libcamera/libcamera/0001-simple-Support-TI-CSI-RX.patch > @@ -0,0 +1,32 @@ > +From d0e4f4f224671e9fc992d39e7beb9c486303ede1 Mon Sep 17 00:00:00 2001 > +From: Jai Luthra <j-luthra@ti.com> > +Date: Thu, 23 Mar 2023 11:38:46 +0530 > +Subject: [PATCH] simple: Support TI CSI-RX > + > +Add support for TI's CSI-RX pixel grabber device for the simple > +pipeline. > + > +The driver is not yet merged, but v7 is posted [1] upstream. > + > +Link: https://lore.kernel.org/all/20230314115516.667-1-vaishnav.a@ti.com/ [1] No, that is not a required Upstream-Status tag. See here: https://www.openembedded.org/wiki/Commit_Patch_Message_Guidelines#Patch_Header_Recommendations:_Upstream-Status > +Signed-off-by: Jai Luthra <j-luthra@ti.com> > +--- > + src/libcamera/pipeline/simple/simple.cpp | 2 ++ > + 1 file changed, 2 insertions(+) > + > +diff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp > +index e1f8b989..520405a1 100644 > +--- a/src/libcamera/pipeline/simple/simple.cpp > ++++ b/src/libcamera/pipeline/simple/simple.cpp > +@@ -194,6 +194,8 @@ static const SimplePipelineInfo supportedDevices[] = { > + { "mxc-isi", {} }, > + { "qcom-camss", {} }, > + { "sun6i-csi", {} }, > ++ { "j721e-csi2rx", {} }, > ++ > + }; > + > + } /* namespace */ > +-- > +2.41.0 > + > diff --git a/meta-arago-extras/recipes-multimedia/libcamera/libcamera_0.0.5.bb b/meta-arago-extras/recipes-multimedia/libcamera/libcamera_0.0.5.bb > index 6ad376f2..b2eb5fac 100644 > --- a/meta-arago-extras/recipes-multimedia/libcamera/libcamera_0.0.5.bb > +++ b/meta-arago-extras/recipes-multimedia/libcamera/libcamera_0.0.5.bb > @@ -10,6 +10,7 @@ LIC_FILES_CHKSUM = "\ > > SRC_URI = " \ > git://git.libcamera.org/libcamera/libcamera.git;protocol=https;branch=master \ > + file://0001-simple-Support-TI-CSI-RX.patch \ > " > > SRCREV = "fb44403f1c5571549ac128c21daee9761eb9249c" > -- > 2.41.0
diff --git a/meta-arago-extras/recipes-multimedia/libcamera/libcamera/0001-simple-Support-TI-CSI-RX.patch b/meta-arago-extras/recipes-multimedia/libcamera/libcamera/0001-simple-Support-TI-CSI-RX.patch new file mode 100644 index 00000000..f35b3613 --- /dev/null +++ b/meta-arago-extras/recipes-multimedia/libcamera/libcamera/0001-simple-Support-TI-CSI-RX.patch @@ -0,0 +1,32 @@ +From d0e4f4f224671e9fc992d39e7beb9c486303ede1 Mon Sep 17 00:00:00 2001 +From: Jai Luthra <j-luthra@ti.com> +Date: Thu, 23 Mar 2023 11:38:46 +0530 +Subject: [PATCH] simple: Support TI CSI-RX + +Add support for TI's CSI-RX pixel grabber device for the simple +pipeline. + +The driver is not yet merged, but v7 is posted [1] upstream. + +Link: https://lore.kernel.org/all/20230314115516.667-1-vaishnav.a@ti.com/ [1] +Signed-off-by: Jai Luthra <j-luthra@ti.com> +--- + src/libcamera/pipeline/simple/simple.cpp | 2 ++ + 1 file changed, 2 insertions(+) + +diff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp +index e1f8b989..520405a1 100644 +--- a/src/libcamera/pipeline/simple/simple.cpp ++++ b/src/libcamera/pipeline/simple/simple.cpp +@@ -194,6 +194,8 @@ static const SimplePipelineInfo supportedDevices[] = { + { "mxc-isi", {} }, + { "qcom-camss", {} }, + { "sun6i-csi", {} }, ++ { "j721e-csi2rx", {} }, ++ + }; + + } /* namespace */ +-- +2.41.0 + diff --git a/meta-arago-extras/recipes-multimedia/libcamera/libcamera_0.0.5.bb b/meta-arago-extras/recipes-multimedia/libcamera/libcamera_0.0.5.bb index 6ad376f2..b2eb5fac 100644 --- a/meta-arago-extras/recipes-multimedia/libcamera/libcamera_0.0.5.bb +++ b/meta-arago-extras/recipes-multimedia/libcamera/libcamera_0.0.5.bb @@ -10,6 +10,7 @@ LIC_FILES_CHKSUM = "\ SRC_URI = " \ git://git.libcamera.org/libcamera/libcamera.git;protocol=https;branch=master \ + file://0001-simple-Support-TI-CSI-RX.patch \ " SRCREV = "fb44403f1c5571549ac128c21daee9761eb9249c"
TI's CSI-RX driver is not yet upstream, so the libcamera simple pipeline does not recognize it. Apply a patch to the simple pipeline so that it can recognize the media entity for TI's CSI-RX driver. Signed-off-by: Jai Luthra <j-luthra@ti.com> --- v2: Add upstream information in the patch Link to v1: https://lore.kernel.org/all/20230705130928.1201894-2-j-luthra@ti.com/ .../0001-simple-Support-TI-CSI-RX.patch | 32 +++++++++++++++++++ .../libcamera/libcamera_0.0.5.bb | 1 + 2 files changed, 33 insertions(+) create mode 100644 meta-arago-extras/recipes-multimedia/libcamera/libcamera/0001-simple-Support-TI-CSI-RX.patch