| Message ID | 20230627144249.30543-6-r-gunasekaran@ti.com |
|---|---|
| State | Accepted |
| Delegated to: | Ryan Eatmon |
| Headers | show |
| Series | Add meta-sysrepo recipes | expand |
On 6/27/23 9:42 AM, Ravi Gunasekaran wrote: > libredblack is needed to build sysrepo. Add recipe for libredblack. > > The recipe is taken as-is from the commit 09f73e7 ("update for honister") > from the public repo [1]. > > [1] - https://github.com/sartura/meta-sysrepo > > Signed-off-by: Ravi Gunasekaran <r-gunasekaran@ti.com> > --- > > Changes since v3: > ---------------- > No change > > Changes since v2: > --------------- > Newly introduced in this series > > .../libredblack/libredblack_git.bb | 21 +++++++++++++++++++ > 1 file changed, 21 insertions(+) > create mode 100644 meta-arago-extras/recipes-sysrepo/libredblack/libredblack_git.bb > > diff --git a/meta-arago-extras/recipes-sysrepo/libredblack/libredblack_git.bb b/meta-arago-extras/recipes-sysrepo/libredblack/libredblack_git.bb > new file mode 100644 > index 00000000..ea51b618 > --- /dev/null > +++ b/meta-arago-extras/recipes-sysrepo/libredblack/libredblack_git.bb > @@ -0,0 +1,21 @@ > +SUMMARY = "Library for handling red-black tree searching algorithm" > +DESCRIPTION = "A library to provide the RedBlack balanced tree searching and sorting algorithm." > +LICENSE = "LGPLv2.1" > +LIC_FILES_CHKSUM = "file://COPYING;md5=de174fb5a92cdbe038c88dc4c4316f99" > + > +SRC_URI = "git://github.com/sysrepo/libredblack.git;protocol=https" > + > +PV = "1.0+git${SRCPV}" > +SRCREV = "a399310d99b61eec4d3c0677573ab5dddcf9395d" > + > +S = "${WORKDIR}/git" > + > +# NOTE: if this software is not capable of being built in a separate build directory > +# from the source, you should replace autotools with autotools-brokensep in the > +# inherit line This comment isn't needed. I understand the 1:1 copy from the original repo, but after you should have another patch that comes back and cleans these up. If they are to live in meta-arago they need to be up to the standards. Andrew > +inherit python3native autotools > + > +# Specify any options you want to pass to the configure script using EXTRA_OECONF: > +EXTRA_OECONF = " --without-rbgen " > + > +BBCLASSEXTEND = "native nativesdk"
Andrew, On 6/27/23 8:32 PM, Andrew Davis wrote: > On 6/27/23 9:42 AM, Ravi Gunasekaran wrote: >> libredblack is needed to build sysrepo. Add recipe for libredblack. >> >> The recipe is taken as-is from the commit 09f73e7 ("update for honister") >> from the public repo [1]. >> >> [1] - https://github.com/sartura/meta-sysrepo >> >> Signed-off-by: Ravi Gunasekaran <r-gunasekaran@ti.com> >> --- >> >> Changes since v3: >> ---------------- >> No change >> >> Changes since v2: >> --------------- >> Newly introduced in this series >> >> .../libredblack/libredblack_git.bb | 21 +++++++++++++++++++ >> 1 file changed, 21 insertions(+) >> create mode 100644 meta-arago-extras/recipes-sysrepo/libredblack/libredblack_git.bb >> >> diff --git a/meta-arago-extras/recipes-sysrepo/libredblack/libredblack_git.bb b/meta-arago-extras/recipes-sysrepo/libredblack/libredblack_git.bb >> new file mode 100644 >> index 00000000..ea51b618 >> --- /dev/null >> +++ b/meta-arago-extras/recipes-sysrepo/libredblack/libredblack_git.bb >> @@ -0,0 +1,21 @@ >> +SUMMARY = "Library for handling red-black tree searching algorithm" >> +DESCRIPTION = "A library to provide the RedBlack balanced tree searching and sorting algorithm." >> +LICENSE = "LGPLv2.1" >> +LIC_FILES_CHKSUM = "file://COPYING;md5=de174fb5a92cdbe038c88dc4c4316f99" >> + >> +SRC_URI = "git://github.com/sysrepo/libredblack.git;protocol=https" >> + >> +PV = "1.0+git${SRCPV}" >> +SRCREV = "a399310d99b61eec4d3c0677573ab5dddcf9395d" >> + >> +S = "${WORKDIR}/git" >> + >> +# NOTE: if this software is not capable of being built in a separate build directory >> +# from the source, you should replace autotools with autotools-brokensep in the >> +# inherit line > > This comment isn't needed. > > I understand the 1:1 copy from the original repo, but after you should have another patch > that comes back and cleans these up. If they are to live in meta-arago they need to be up > to the standards. Understood. I have replied to your comment in [2/8]. If my reply is not satisfactory, then while sending the next version, I will add another patch in the series to remove this "Note". Incase the series is acceptable, then I will send out a separate patch to remove the "Note" > > Andrew > >> +inherit python3native autotools >> + >> +# Specify any options you want to pass to the configure script using EXTRA_OECONF: >> +EXTRA_OECONF = " --without-rbgen " >> + >> +BBCLASSEXTEND = "native nativesdk"
On 6/27/2023 11:22 PM, Ravi Gunasekaran wrote: > Andrew, > > On 6/27/23 8:32 PM, Andrew Davis wrote: >> On 6/27/23 9:42 AM, Ravi Gunasekaran wrote: >>> libredblack is needed to build sysrepo. Add recipe for libredblack. >>> >>> The recipe is taken as-is from the commit 09f73e7 ("update for honister") >>> from the public repo [1]. >>> >>> [1] - https://github.com/sartura/meta-sysrepo >>> >>> Signed-off-by: Ravi Gunasekaran <r-gunasekaran@ti.com> >>> --- >>> >>> Changes since v3: >>> ---------------- >>> No change >>> >>> Changes since v2: >>> --------------- >>> Newly introduced in this series >>> >>> .../libredblack/libredblack_git.bb | 21 +++++++++++++++++++ >>> 1 file changed, 21 insertions(+) >>> create mode 100644 meta-arago-extras/recipes-sysrepo/libredblack/libredblack_git.bb >>> >>> diff --git a/meta-arago-extras/recipes-sysrepo/libredblack/libredblack_git.bb b/meta-arago-extras/recipes-sysrepo/libredblack/libredblack_git.bb >>> new file mode 100644 >>> index 00000000..ea51b618 >>> --- /dev/null >>> +++ b/meta-arago-extras/recipes-sysrepo/libredblack/libredblack_git.bb >>> @@ -0,0 +1,21 @@ >>> +SUMMARY = "Library for handling red-black tree searching algorithm" >>> +DESCRIPTION = "A library to provide the RedBlack balanced tree searching and sorting algorithm." >>> +LICENSE = "LGPLv2.1" >>> +LIC_FILES_CHKSUM = "file://COPYING;md5=de174fb5a92cdbe038c88dc4c4316f99" >>> + >>> +SRC_URI = "git://github.com/sysrepo/libredblack.git;protocol=https" >>> + >>> +PV = "1.0+git${SRCPV}" >>> +SRCREV = "a399310d99b61eec4d3c0677573ab5dddcf9395d" >>> + >>> +S = "${WORKDIR}/git" >>> + >>> +# NOTE: if this software is not capable of being built in a separate build directory >>> +# from the source, you should replace autotools with autotools-brokensep in the >>> +# inherit line >> >> This comment isn't needed. >> >> I understand the 1:1 copy from the original repo, but after you should have another patch >> that comes back and cleans these up. If they are to live in meta-arago they need to be up >> to the standards. > > Understood. > I have replied to your comment in [2/8]. If my reply is not satisfactory, then while sending > the next version, I will add another patch in the series to remove this "Note". > Incase the series is acceptable, then I will send out a separate patch to remove the "Note" What you have is fine for accepting this series. Just submit a new patch that cleans it up. >> >> Andrew >> >>> +inherit python3native autotools >>> + >>> +# Specify any options you want to pass to the configure script using EXTRA_OECONF: >>> +EXTRA_OECONF = " --without-rbgen " >>> + >>> +BBCLASSEXTEND = "native nativesdk" >
On Wed, Jun 28, 2023 at 10:52:26AM -0500, Ryan Eatmon wrote: > > > On 6/27/2023 11:22 PM, Ravi Gunasekaran wrote: > >Andrew, > > > >On 6/27/23 8:32 PM, Andrew Davis wrote: > >>On 6/27/23 9:42 AM, Ravi Gunasekaran wrote: > >>>libredblack is needed to build sysrepo. Add recipe for libredblack. > >>> > >>>The recipe is taken as-is from the commit 09f73e7 ("update for honister") > >>>from the public repo [1]. > >>> > >>>[1] - https://github.com/sartura/meta-sysrepo > >>> > >>>Signed-off-by: Ravi Gunasekaran <r-gunasekaran@ti.com> > >>>--- > >>> > >>>Changes since v3: > >>>---------------- > >>>No change > >>> > >>>Changes since v2: > >>>--------------- > >>>Newly introduced in this series > >>> > >>> .../libredblack/libredblack_git.bb | 21 +++++++++++++++++++ > >>> 1 file changed, 21 insertions(+) > >>> create mode 100644 meta-arago-extras/recipes-sysrepo/libredblack/libredblack_git.bb > >>> > >>>diff --git a/meta-arago-extras/recipes-sysrepo/libredblack/libredblack_git.bb b/meta-arago-extras/recipes-sysrepo/libredblack/libredblack_git.bb > >>>new file mode 100644 > >>>index 00000000..ea51b618 > >>>--- /dev/null > >>>+++ b/meta-arago-extras/recipes-sysrepo/libredblack/libredblack_git.bb > >>>@@ -0,0 +1,21 @@ > >>>+SUMMARY = "Library for handling red-black tree searching algorithm" > >>>+DESCRIPTION = "A library to provide the RedBlack balanced tree searching and sorting algorithm." > >>>+LICENSE = "LGPLv2.1" > >>>+LIC_FILES_CHKSUM = "file://COPYING;md5=de174fb5a92cdbe038c88dc4c4316f99" > >>>+ > >>>+SRC_URI = "git://github.com/sysrepo/libredblack.git;protocol=https" > >>>+ > >>>+PV = "1.0+git${SRCPV}" > >>>+SRCREV = "a399310d99b61eec4d3c0677573ab5dddcf9395d" > >>>+ > >>>+S = "${WORKDIR}/git" > >>>+ > >>>+# NOTE: if this software is not capable of being built in a separate build directory > >>>+# from the source, you should replace autotools with autotools-brokensep in the > >>>+# inherit line > >> > >>This comment isn't needed. > >> > >>I understand the 1:1 copy from the original repo, but after you should have another patch > >>that comes back and cleans these up. If they are to live in meta-arago they need to be up > >>to the standards. > > > >Understood. > >I have replied to your comment in [2/8]. If my reply is not satisfactory, then while sending > >the next version, I will add another patch in the series to remove this "Note". > >Incase the series is acceptable, then I will send out a separate patch to remove the "Note" > > > What you have is fine for accepting this series. Just submit a new > patch that cleans it up. +1 here. Good enough for merging, please address remaining comments in the follow up patches. Thanks.
On Wed, Jun 28, 2023 at 01:56:06PM -0400, Denys Dmytriyenko wrote: > On Wed, Jun 28, 2023 at 10:52:26AM -0500, Ryan Eatmon wrote: > > > > > > On 6/27/2023 11:22 PM, Ravi Gunasekaran wrote: > > >Andrew, > > > > > >On 6/27/23 8:32 PM, Andrew Davis wrote: > > >>On 6/27/23 9:42 AM, Ravi Gunasekaran wrote: > > >>>libredblack is needed to build sysrepo. Add recipe for libredblack. > > >>> > > >>>The recipe is taken as-is from the commit 09f73e7 ("update for honister") > > >>>from the public repo [1]. > > >>> > > >>>[1] - https://github.com/sartura/meta-sysrepo > > >>> > > >>>Signed-off-by: Ravi Gunasekaran <r-gunasekaran@ti.com> > > >>>--- > > >>> > > >>>Changes since v3: > > >>>---------------- > > >>>No change > > >>> > > >>>Changes since v2: > > >>>--------------- > > >>>Newly introduced in this series > > >>> > > >>> .../libredblack/libredblack_git.bb | 21 +++++++++++++++++++ > > >>> 1 file changed, 21 insertions(+) > > >>> create mode 100644 meta-arago-extras/recipes-sysrepo/libredblack/libredblack_git.bb > > >>> > > >>>diff --git a/meta-arago-extras/recipes-sysrepo/libredblack/libredblack_git.bb b/meta-arago-extras/recipes-sysrepo/libredblack/libredblack_git.bb > > >>>new file mode 100644 > > >>>index 00000000..ea51b618 > > >>>--- /dev/null > > >>>+++ b/meta-arago-extras/recipes-sysrepo/libredblack/libredblack_git.bb > > >>>@@ -0,0 +1,21 @@ > > >>>+SUMMARY = "Library for handling red-black tree searching algorithm" > > >>>+DESCRIPTION = "A library to provide the RedBlack balanced tree searching and sorting algorithm." > > >>>+LICENSE = "LGPLv2.1" > > >>>+LIC_FILES_CHKSUM = "file://COPYING;md5=de174fb5a92cdbe038c88dc4c4316f99" > > >>>+ > > >>>+SRC_URI = "git://github.com/sysrepo/libredblack.git;protocol=https" > > >>>+ > > >>>+PV = "1.0+git${SRCPV}" > > >>>+SRCREV = "a399310d99b61eec4d3c0677573ab5dddcf9395d" > > >>>+ > > >>>+S = "${WORKDIR}/git" > > >>>+ > > >>>+# NOTE: if this software is not capable of being built in a separate build directory > > >>>+# from the source, you should replace autotools with autotools-brokensep in the > > >>>+# inherit line > > >> > > >>This comment isn't needed. > > >> > > >>I understand the 1:1 copy from the original repo, but after you should have another patch > > >>that comes back and cleans these up. If they are to live in meta-arago they need to be up > > >>to the standards. > > > > > >Understood. > > >I have replied to your comment in [2/8]. If my reply is not satisfactory, then while sending > > >the next version, I will add another patch in the series to remove this "Note". > > >Incase the series is acceptable, then I will send out a separate patch to remove the "Note" > > > > > > What you have is fine for accepting this series. Just submit a new > > patch that cleans it up. > > +1 here. Good enough for merging, please address remaining comments in the > follow up patches. Thanks. BTW, one more thing to fix in the follow up updates: WARNING: URL: git://github.com/sysrepo/libredblack.git;protocol=https does not set any branch parameter. The future default branch used by tools and repositories is uncertain and we will therefore soon require this is set in all git urls.
On 6/29/23 4:17 AM, Denys Dmytriyenko wrote: > On Wed, Jun 28, 2023 at 01:56:06PM -0400, Denys Dmytriyenko wrote: >> On Wed, Jun 28, 2023 at 10:52:26AM -0500, Ryan Eatmon wrote: >>> >>> >>> On 6/27/2023 11:22 PM, Ravi Gunasekaran wrote: >>>> Andrew, >>>> >>>> On 6/27/23 8:32 PM, Andrew Davis wrote: >>>>> On 6/27/23 9:42 AM, Ravi Gunasekaran wrote: >>>>>> libredblack is needed to build sysrepo. Add recipe for libredblack. >>>>>> >>>>>> The recipe is taken as-is from the commit 09f73e7 ("update for honister") >>>>> >from the public repo [1]. >>>>>> >>>>>> [1] - https://github.com/sartura/meta-sysrepo >>>>>> >>>>>> Signed-off-by: Ravi Gunasekaran <r-gunasekaran@ti.com> >>>>>> --- >>>>>> >>>>>> Changes since v3: >>>>>> ---------------- >>>>>> No change >>>>>> >>>>>> Changes since v2: >>>>>> --------------- >>>>>> Newly introduced in this series >>>>>> >>>>>> .../libredblack/libredblack_git.bb | 21 +++++++++++++++++++ >>>>>> 1 file changed, 21 insertions(+) >>>>>> create mode 100644 meta-arago-extras/recipes-sysrepo/libredblack/libredblack_git.bb >>>>>> >>>>>> diff --git a/meta-arago-extras/recipes-sysrepo/libredblack/libredblack_git.bb b/meta-arago-extras/recipes-sysrepo/libredblack/libredblack_git.bb >>>>>> new file mode 100644 >>>>>> index 00000000..ea51b618 >>>>>> --- /dev/null >>>>>> +++ b/meta-arago-extras/recipes-sysrepo/libredblack/libredblack_git.bb >>>>>> @@ -0,0 +1,21 @@ >>>>>> +SUMMARY = "Library for handling red-black tree searching algorithm" >>>>>> +DESCRIPTION = "A library to provide the RedBlack balanced tree searching and sorting algorithm." >>>>>> +LICENSE = "LGPLv2.1" >>>>>> +LIC_FILES_CHKSUM = "file://COPYING;md5=de174fb5a92cdbe038c88dc4c4316f99" >>>>>> + >>>>>> +SRC_URI = "git://github.com/sysrepo/libredblack.git;protocol=https" >>>>>> + >>>>>> +PV = "1.0+git${SRCPV}" >>>>>> +SRCREV = "a399310d99b61eec4d3c0677573ab5dddcf9395d" >>>>>> + >>>>>> +S = "${WORKDIR}/git" >>>>>> + >>>>>> +# NOTE: if this software is not capable of being built in a separate build directory >>>>>> +# from the source, you should replace autotools with autotools-brokensep in the >>>>>> +# inherit line >>>>> >>>>> This comment isn't needed. >>>>> >>>>> I understand the 1:1 copy from the original repo, but after you should have another patch >>>>> that comes back and cleans these up. If they are to live in meta-arago they need to be up >>>>> to the standards. >>>> >>>> Understood. >>>> I have replied to your comment in [2/8]. If my reply is not satisfactory, then while sending >>>> the next version, I will add another patch in the series to remove this "Note". >>>> Incase the series is acceptable, then I will send out a separate patch to remove the "Note" >>> >>> >>> What you have is fine for accepting this series. Just submit a new >>> patch that cleans it up. >> >> +1 here. Good enough for merging, please address remaining comments in the >> follow up patches. Thanks. > > BTW, one more thing to fix in the follow up updates: > > WARNING: URL: git://github.com/sysrepo/libredblack.git;protocol=https does not > set any branch parameter. The future default branch used by tools and > repositories is uncertain and we will therefore soon require this is set in > all git urls. Thanks for merging the patches to kirkstone-next. I will post a follow up series fixing the comments.
diff --git a/meta-arago-extras/recipes-sysrepo/libredblack/libredblack_git.bb b/meta-arago-extras/recipes-sysrepo/libredblack/libredblack_git.bb new file mode 100644 index 00000000..ea51b618 --- /dev/null +++ b/meta-arago-extras/recipes-sysrepo/libredblack/libredblack_git.bb @@ -0,0 +1,21 @@ +SUMMARY = "Library for handling red-black tree searching algorithm" +DESCRIPTION = "A library to provide the RedBlack balanced tree searching and sorting algorithm." +LICENSE = "LGPLv2.1" +LIC_FILES_CHKSUM = "file://COPYING;md5=de174fb5a92cdbe038c88dc4c4316f99" + +SRC_URI = "git://github.com/sysrepo/libredblack.git;protocol=https" + +PV = "1.0+git${SRCPV}" +SRCREV = "a399310d99b61eec4d3c0677573ab5dddcf9395d" + +S = "${WORKDIR}/git" + +# NOTE: if this software is not capable of being built in a separate build directory +# from the source, you should replace autotools with autotools-brokensep in the +# inherit line +inherit python3native autotools + +# Specify any options you want to pass to the configure script using EXTRA_OECONF: +EXTRA_OECONF = " --without-rbgen " + +BBCLASSEXTEND = "native nativesdk"
libredblack is needed to build sysrepo. Add recipe for libredblack. The recipe is taken as-is from the commit 09f73e7 ("update for honister") from the public repo [1]. [1] - https://github.com/sartura/meta-sysrepo Signed-off-by: Ravi Gunasekaran <r-gunasekaran@ti.com> --- Changes since v3: ---------------- No change Changes since v2: --------------- Newly introduced in this series .../libredblack/libredblack_git.bb | 21 +++++++++++++++++++ 1 file changed, 21 insertions(+) create mode 100644 meta-arago-extras/recipes-sysrepo/libredblack/libredblack_git.bb