diff mbox series

[oe-layersetup] configs: Update Kirkstone config for sysrepo

Message ID 20230616084538.10530-1-r-gunasekaran@ti.com
State Rejected
Delegated to: Ryan Eatmon
Headers show
Series [oe-layersetup] configs: Update Kirkstone config for sysrepo | expand

Commit Message

Ravi Gunasekaran June 16, 2023, 8:45 a.m. UTC
NETCONF/YANG is implemented through netopeer2/sysrepo.
A Yocto project for sysrepo is available in public domain[1].

[1] is compatible only with Yocto Honister branch. So update
the config with [2] which is fork of [1] for Kirkstone.

[1] - https://github.com/sartura/meta-sysrepo
[2] - https://github.com/ravig07/meta-sysrepo

Signed-off-by: Ravi Gunasekaran <r-gunasekaran@ti.com>
---
I have sent a Pull Request for [2]. Once it gets merged, then the URI
in the config.txt can be replaced with it.

 configs/arago-kirkstone-config.txt | 1 +
 1 file changed, 1 insertion(+)

Comments

Denys Dmytriyenko June 16, 2023, 7:48 p.m. UTC | #1
On Fri, Jun 16, 2023 at 02:15:38PM +0530, Ravi Gunasekaran wrote:
> NETCONF/YANG is implemented through netopeer2/sysrepo.
> A Yocto project for sysrepo is available in public domain[1].
> 
> [1] is compatible only with Yocto Honister branch. So update
> the config with [2] which is fork of [1] for Kirkstone.
> 
> [1] - https://github.com/sartura/meta-sysrepo
> [2] - https://github.com/ravig07/meta-sysrepo

So, you are bumping many of the recipes in that layer, plus updating to the 
new override syntax and setting compatibility with kirkstone. The PR has been 
setting open since May 4 w/o any comments, so it's probably safe to assume the 
layer is abandoned. Why not move the recipes to an active layer? At least to 
meta-arago, or even better work on upstreaming them to meta-openembedded?

Regardless, the changes for kirkstone appear to be safe to langdale and 
mickledore - that would allow including the change in master builds too.


> Signed-off-by: Ravi Gunasekaran <r-gunasekaran@ti.com>
> ---
> I have sent a Pull Request for [2]. Once it gets merged, then the URI
> in the config.txt can be replaced with it.
> 
>  configs/arago-kirkstone-config.txt | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/configs/arago-kirkstone-config.txt b/configs/arago-kirkstone-config.txt
> index c2524a4..e80ab80 100644
> --- a/configs/arago-kirkstone-config.txt
> +++ b/configs/arago-kirkstone-config.txt
> @@ -10,6 +10,7 @@ meta-openembedded,https://git.openembedded.org/meta-openembedded,kirkstone,HEAD,
>  meta-ti,https://git.yoctoproject.org/meta-ti,kirkstone,HEAD,layers=meta-ti-extras:meta-ti-bsp
>  meta-arm,https://git.yoctoproject.org/meta-arm,kirkstone,HEAD,layers=meta-arm:meta-arm-toolchain
>  oe-core,https://git.openembedded.org/openembedded-core,kirkstone,HEAD,layers=meta
> +meta-sysrepo,https://github.com/ravig07/meta-sysrepo,kirkstone,HEAD,layers=
>  OECORELAYERCONF=./sample-files/bblayers.conf.sample
>  OECORELOCALCONF=./sample-files/local-arago64-v2.conf.sample
>  BITBAKE_INCLUSIVE_VARS=yes
> -- 
> 2.17.1
Ravi Gunasekaran June 19, 2023, 4:34 a.m. UTC | #2
Denys,

On 6/17/23 1:18 AM, Denys Dmytriyenko wrote:
> On Fri, Jun 16, 2023 at 02:15:38PM +0530, Ravi Gunasekaran wrote:
>> NETCONF/YANG is implemented through netopeer2/sysrepo.
>> A Yocto project for sysrepo is available in public domain[1].
>>
>> [1] is compatible only with Yocto Honister branch. So update
>> the config with [2] which is fork of [1] for Kirkstone.
>>
>> [1] - https://github.com/sartura/meta-sysrepo
>> [2] - https://github.com/ravig07/meta-sysrepo
> 
> So, you are bumping many of the recipes in that layer, plus updating to the 
> new override syntax and setting compatibility with kirkstone. The PR has been 
> setting open since May 4 w/o any comments, so it's probably safe to assume the 
> layer is abandoned. Why not move the recipes to an active layer? At least to 
> meta-arago, or even better work on upstreaming them to meta-openembedded?
> 
> Regardless, the changes for kirkstone appear to be safe to langdale and 
> mickledore - that would allow including the change in master builds too.

Yes, the PR has been open since quite some time. 
I did think of adding the recipes to meta-arago, but since the recipes already
exists in the public domain, I felt moving them to meta-arago might not be the
right way. 

> 
> 
>> Signed-off-by: Ravi Gunasekaran <r-gunasekaran@ti.com>
>> ---
>> I have sent a Pull Request for [2]. Once it gets merged, then the URI
>> in the config.txt can be replaced with it.
>>
>>  configs/arago-kirkstone-config.txt | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/configs/arago-kirkstone-config.txt b/configs/arago-kirkstone-config.txt
>> index c2524a4..e80ab80 100644
>> --- a/configs/arago-kirkstone-config.txt
>> +++ b/configs/arago-kirkstone-config.txt
>> @@ -10,6 +10,7 @@ meta-openembedded,https://git.openembedded.org/meta-openembedded,kirkstone,HEAD,
>>  meta-ti,https://git.yoctoproject.org/meta-ti,kirkstone,HEAD,layers=meta-ti-extras:meta-ti-bsp
>>  meta-arm,https://git.yoctoproject.org/meta-arm,kirkstone,HEAD,layers=meta-arm:meta-arm-toolchain
>>  oe-core,https://git.openembedded.org/openembedded-core,kirkstone,HEAD,layers=meta
>> +meta-sysrepo,https://github.com/ravig07/meta-sysrepo,kirkstone,HEAD,layers=
>>  OECORELAYERCONF=./sample-files/bblayers.conf.sample
>>  OECORELOCALCONF=./sample-files/local-arago64-v2.conf.sample
>>  BITBAKE_INCLUSIVE_VARS=yes
>> -- 
>> 2.17.1
Ryan Eatmon June 19, 2023, 10:04 p.m. UTC | #3
On 6/18/2023 11:34 PM, Ravi Gunasekaran wrote:
> Denys,
> 
> On 6/17/23 1:18 AM, Denys Dmytriyenko wrote:
>> On Fri, Jun 16, 2023 at 02:15:38PM +0530, Ravi Gunasekaran wrote:
>>> NETCONF/YANG is implemented through netopeer2/sysrepo.
>>> A Yocto project for sysrepo is available in public domain[1].
>>>
>>> [1] is compatible only with Yocto Honister branch. So update
>>> the config with [2] which is fork of [1] for Kirkstone.
>>>
>>> [1] - https://github.com/sartura/meta-sysrepo
>>> [2] - https://github.com/ravig07/meta-sysrepo
>>
>> So, you are bumping many of the recipes in that layer, plus updating to the
>> new override syntax and setting compatibility with kirkstone. The PR has been
>> setting open since May 4 w/o any comments, so it's probably safe to assume the
>> layer is abandoned. Why not move the recipes to an active layer? At least to
>> meta-arago, or even better work on upstreaming them to meta-openembedded?
>>
>> Regardless, the changes for kirkstone appear to be safe to langdale and
>> mickledore - that would allow including the change in master builds too.
> 
> Yes, the PR has been open since quite some time.
> I did think of adding the recipes to meta-arago, but since the recipes already
> exists in the public domain, I felt moving them to meta-arago might not be the
> right way.

We should pull any needed recipes into meta-arago and not in a forked 
repo of meta-sysrepo...

Are you signing up to maintain your forked copy of meta-sysrepo for all 
time?  If not, then we should migrate your required changes into 
meta-arago-extras and just deal with the fact that we as TI need to 
maintain them.


>>
>>
>>> Signed-off-by: Ravi Gunasekaran <r-gunasekaran@ti.com>
>>> ---
>>> I have sent a Pull Request for [2]. Once it gets merged, then the URI
>>> in the config.txt can be replaced with it.
>>>
>>>   configs/arago-kirkstone-config.txt | 1 +
>>>   1 file changed, 1 insertion(+)
>>>
>>> diff --git a/configs/arago-kirkstone-config.txt b/configs/arago-kirkstone-config.txt
>>> index c2524a4..e80ab80 100644
>>> --- a/configs/arago-kirkstone-config.txt
>>> +++ b/configs/arago-kirkstone-config.txt
>>> @@ -10,6 +10,7 @@ meta-openembedded,https://git.openembedded.org/meta-openembedded,kirkstone,HEAD,
>>>   meta-ti,https://git.yoctoproject.org/meta-ti,kirkstone,HEAD,layers=meta-ti-extras:meta-ti-bsp
>>>   meta-arm,https://git.yoctoproject.org/meta-arm,kirkstone,HEAD,layers=meta-arm:meta-arm-toolchain
>>>   oe-core,https://git.openembedded.org/openembedded-core,kirkstone,HEAD,layers=meta
>>> +meta-sysrepo,https://github.com/ravig07/meta-sysrepo,kirkstone,HEAD,layers=
>>>   OECORELAYERCONF=./sample-files/bblayers.conf.sample
>>>   OECORELOCALCONF=./sample-files/local-arago64-v2.conf.sample
>>>   BITBAKE_INCLUSIVE_VARS=yes
>>> -- 
>>> 2.17.1
>
Ravi Gunasekaran June 20, 2023, 4:06 a.m. UTC | #4
On 6/20/2023 3:34 AM, Ryan Eatmon wrote:
>
>
> On 6/18/2023 11:34 PM, Ravi Gunasekaran wrote:
>> Denys,
>>
>> On 6/17/23 1:18 AM, Denys Dmytriyenko wrote:
>>> On Fri, Jun 16, 2023 at 02:15:38PM +0530, Ravi Gunasekaran wrote:
>>>> NETCONF/YANG is implemented through netopeer2/sysrepo.
>>>> A Yocto project for sysrepo is available in public domain[1].
>>>>
>>>> [1] is compatible only with Yocto Honister branch. So update
>>>> the config with [2] which is fork of [1] for Kirkstone.
>>>>
>>>> [1] - https://github.com/sartura/meta-sysrepo
>>>> [2] - https://github.com/ravig07/meta-sysrepo
>>>
>>> So, you are bumping many of the recipes in that layer, plus updating to the
>>> new override syntax and setting compatibility with kirkstone. The PR has been
>>> setting open since May 4 w/o any comments, so it's probably safe to assume the
>>> layer is abandoned. Why not move the recipes to an active layer? At least to
>>> meta-arago, or even better work on upstreaming them to meta-openembedded?
>>>
>>> Regardless, the changes for kirkstone appear to be safe to langdale and
>>> mickledore - that would allow including the change in master builds too.
>>
>> Yes, the PR has been open since quite some time.
>> I did think of adding the recipes to meta-arago, but since the recipes already
>> exists in the public domain, I felt moving them to meta-arago might not be the
>> right way.
>
> We should pull any needed recipes into meta-arago and not in a forked repo of
> meta-sysrepo...
>
> Are you signing up to maintain your forked copy of meta-sysrepo for all time? 
> If not, then we should migrate your required changes into meta-arago-extras
> and just deal with the fact that we as TI need to maintain them.
>

Understood. I will add the recipes to meta-aragos-extras then.

>
>>>
>>>
>>>> Signed-off-by: Ravi Gunasekaran <r-gunasekaran@ti.com>
>>>> ---
>>>> I have sent a Pull Request for [2]. Once it gets merged, then the URI
>>>> in the config.txt can be replaced with it.
>>>>
>>>>   configs/arago-kirkstone-config.txt | 1 +
>>>>   1 file changed, 1 insertion(+)
>>>>
>>>> diff --git a/configs/arago-kirkstone-config.txt
>>>> b/configs/arago-kirkstone-config.txt
>>>> index c2524a4..e80ab80 100644
>>>> --- a/configs/arago-kirkstone-config.txt
>>>> +++ b/configs/arago-kirkstone-config.txt
>>>> @@ -10,6 +10,7 @@
>>>> meta-openembedded,https://git.openembedded.org/meta-openembedded,kirkstone,HEAD,
>>>>  
>>>> meta-ti,https://git.yoctoproject.org/meta-ti,kirkstone,HEAD,layers=meta-ti-extras:meta-ti-bsp
>>>>  
>>>> meta-arm,https://git.yoctoproject.org/meta-arm,kirkstone,HEAD,layers=meta-arm:meta-arm-toolchain
>>>>  
>>>> oe-core,https://git.openembedded.org/openembedded-core,kirkstone,HEAD,layers=meta
>>>> +meta-sysrepo,https://github.com/ravig07/meta-sysrepo,kirkstone,HEAD,layers=
>>>>   OECORELAYERCONF=./sample-files/bblayers.conf.sample
>>>>   OECORELOCALCONF=./sample-files/local-arago64-v2.conf.sample
>>>>   BITBAKE_INCLUSIVE_VARS=yes
>>>> -- 
>>>> 2.17.1
>>
>
Denys Dmytriyenko June 20, 2023, 4:13 p.m. UTC | #5
On Tue, Jun 20, 2023 at 09:36:12AM +0530, Ravi Gunasekaran wrote:
> 
> 
> On 6/20/2023 3:34 AM, Ryan Eatmon wrote:
> >
> >
> > On 6/18/2023 11:34 PM, Ravi Gunasekaran wrote:
> >> Denys,
> >>
> >> On 6/17/23 1:18 AM, Denys Dmytriyenko wrote:
> >>> On Fri, Jun 16, 2023 at 02:15:38PM +0530, Ravi Gunasekaran wrote:
> >>>> NETCONF/YANG is implemented through netopeer2/sysrepo.
> >>>> A Yocto project for sysrepo is available in public domain[1].
> >>>>
> >>>> [1] is compatible only with Yocto Honister branch. So update
> >>>> the config with [2] which is fork of [1] for Kirkstone.
> >>>>
> >>>> [1] - https://github.com/sartura/meta-sysrepo
> >>>> [2] - https://github.com/ravig07/meta-sysrepo
> >>>
> >>> So, you are bumping many of the recipes in that layer, plus updating to the
> >>> new override syntax and setting compatibility with kirkstone. The PR has been
> >>> setting open since May 4 w/o any comments, so it's probably safe to assume the
> >>> layer is abandoned. Why not move the recipes to an active layer? At least to
> >>> meta-arago, or even better work on upstreaming them to meta-openembedded?
> >>>
> >>> Regardless, the changes for kirkstone appear to be safe to langdale and
> >>> mickledore - that would allow including the change in master builds too.
> >>
> >> Yes, the PR has been open since quite some time.
> >> I did think of adding the recipes to meta-arago, but since the recipes already
> >> exists in the public domain, I felt moving them to meta-arago might not be the
> >> right way.
> >
> > We should pull any needed recipes into meta-arago and not in a forked repo of
> > meta-sysrepo...
> >
> > Are you signing up to maintain your forked copy of meta-sysrepo for all time? 
> > If not, then we should migrate your required changes into meta-arago-extras
> > and just deal with the fact that we as TI need to maintain them.
> >
> 
> Understood. I will add the recipes to meta-aragos-extras then.

What is "aragos"?


> >>>> Signed-off-by: Ravi Gunasekaran <r-gunasekaran@ti.com>
> >>>> ---
> >>>> I have sent a Pull Request for [2]. Once it gets merged, then the URI
> >>>> in the config.txt can be replaced with it.
> >>>>
> >>>>   configs/arago-kirkstone-config.txt | 1 +
> >>>>   1 file changed, 1 insertion(+)
> >>>>
> >>>> diff --git a/configs/arago-kirkstone-config.txt
> >>>> b/configs/arago-kirkstone-config.txt
> >>>> index c2524a4..e80ab80 100644
> >>>> --- a/configs/arago-kirkstone-config.txt
> >>>> +++ b/configs/arago-kirkstone-config.txt
> >>>> @@ -10,6 +10,7 @@
> >>>> meta-openembedded,https://git.openembedded.org/meta-openembedded,kirkstone,HEAD,
> >>>>  
> >>>> meta-ti,https://git.yoctoproject.org/meta-ti,kirkstone,HEAD,layers=meta-ti-extras:meta-ti-bsp
> >>>>  
> >>>> meta-arm,https://git.yoctoproject.org/meta-arm,kirkstone,HEAD,layers=meta-arm:meta-arm-toolchain
> >>>>  
> >>>> oe-core,https://git.openembedded.org/openembedded-core,kirkstone,HEAD,layers=meta
> >>>> +meta-sysrepo,https://github.com/ravig07/meta-sysrepo,kirkstone,HEAD,layers=
> >>>>   OECORELAYERCONF=./sample-files/bblayers.conf.sample
> >>>>   OECORELOCALCONF=./sample-files/local-arago64-v2.conf.sample
> >>>>   BITBAKE_INCLUSIVE_VARS=yes
> >>>> -- 
> >>>> 2.17.1
Ravi Gunasekaran June 21, 2023, 4:28 a.m. UTC | #6
On 6/20/23 9:43 PM, Denys Dmytriyenko wrote:
> On Tue, Jun 20, 2023 at 09:36:12AM +0530, Ravi Gunasekaran wrote:
>>
>>
>> On 6/20/2023 3:34 AM, Ryan Eatmon wrote:
>>>
>>>
>>> On 6/18/2023 11:34 PM, Ravi Gunasekaran wrote:
>>>> Denys,
>>>>
>>>> On 6/17/23 1:18 AM, Denys Dmytriyenko wrote:
>>>>> On Fri, Jun 16, 2023 at 02:15:38PM +0530, Ravi Gunasekaran wrote:
>>>>>> NETCONF/YANG is implemented through netopeer2/sysrepo.
>>>>>> A Yocto project for sysrepo is available in public domain[1].
>>>>>>
>>>>>> [1] is compatible only with Yocto Honister branch. So update
>>>>>> the config with [2] which is fork of [1] for Kirkstone.
>>>>>>
>>>>>> [1] - https://github.com/sartura/meta-sysrepo
>>>>>> [2] - https://github.com/ravig07/meta-sysrepo
>>>>>
>>>>> So, you are bumping many of the recipes in that layer, plus updating to the
>>>>> new override syntax and setting compatibility with kirkstone. The PR has been
>>>>> setting open since May 4 w/o any comments, so it's probably safe to assume the
>>>>> layer is abandoned. Why not move the recipes to an active layer? At least to
>>>>> meta-arago, or even better work on upstreaming them to meta-openembedded?
>>>>>
>>>>> Regardless, the changes for kirkstone appear to be safe to langdale and
>>>>> mickledore - that would allow including the change in master builds too.
>>>>
>>>> Yes, the PR has been open since quite some time.
>>>> I did think of adding the recipes to meta-arago, but since the recipes already
>>>> exists in the public domain, I felt moving them to meta-arago might not be the
>>>> right way.
>>>
>>> We should pull any needed recipes into meta-arago and not in a forked repo of
>>> meta-sysrepo...
>>>
>>> Are you signing up to maintain your forked copy of meta-sysrepo for all time? 
>>> If not, then we should migrate your required changes into meta-arago-extras
>>> and just deal with the fact that we as TI need to maintain them.
>>>
>>
>> Understood. I will add the recipes to meta-aragos-extras then.
> 
> What is "aragos"?

Sorry. For some reason, "aragos" is stuck in my mind.

> 
> 
>>>>>> Signed-off-by: Ravi Gunasekaran <r-gunasekaran@ti.com>
>>>>>> ---
>>>>>> I have sent a Pull Request for [2]. Once it gets merged, then the URI
>>>>>> in the config.txt can be replaced with it.
>>>>>>
>>>>>>   configs/arago-kirkstone-config.txt | 1 +
>>>>>>   1 file changed, 1 insertion(+)
>>>>>>
>>>>>> diff --git a/configs/arago-kirkstone-config.txt
>>>>>> b/configs/arago-kirkstone-config.txt
>>>>>> index c2524a4..e80ab80 100644
>>>>>> --- a/configs/arago-kirkstone-config.txt
>>>>>> +++ b/configs/arago-kirkstone-config.txt
>>>>>> @@ -10,6 +10,7 @@
>>>>>> meta-openembedded,https://git.openembedded.org/meta-openembedded,kirkstone,HEAD,
>>>>>>  
>>>>>> meta-ti,https://git.yoctoproject.org/meta-ti,kirkstone,HEAD,layers=meta-ti-extras:meta-ti-bsp
>>>>>>  
>>>>>> meta-arm,https://git.yoctoproject.org/meta-arm,kirkstone,HEAD,layers=meta-arm:meta-arm-toolchain
>>>>>>  
>>>>>> oe-core,https://git.openembedded.org/openembedded-core,kirkstone,HEAD,layers=meta
>>>>>> +meta-sysrepo,https://github.com/ravig07/meta-sysrepo,kirkstone,HEAD,layers=
>>>>>>   OECORELAYERCONF=./sample-files/bblayers.conf.sample
>>>>>>   OECORELOCALCONF=./sample-files/local-arago64-v2.conf.sample
>>>>>>   BITBAKE_INCLUSIVE_VARS=yes
>>>>>> -- 
>>>>>> 2.17.1
diff mbox series

Patch

diff --git a/configs/arago-kirkstone-config.txt b/configs/arago-kirkstone-config.txt
index c2524a4..e80ab80 100644
--- a/configs/arago-kirkstone-config.txt
+++ b/configs/arago-kirkstone-config.txt
@@ -10,6 +10,7 @@  meta-openembedded,https://git.openembedded.org/meta-openembedded,kirkstone,HEAD,
 meta-ti,https://git.yoctoproject.org/meta-ti,kirkstone,HEAD,layers=meta-ti-extras:meta-ti-bsp
 meta-arm,https://git.yoctoproject.org/meta-arm,kirkstone,HEAD,layers=meta-arm:meta-arm-toolchain
 oe-core,https://git.openembedded.org/openembedded-core,kirkstone,HEAD,layers=meta
+meta-sysrepo,https://github.com/ravig07/meta-sysrepo,kirkstone,HEAD,layers=
 OECORELAYERCONF=./sample-files/bblayers.conf.sample
 OECORELOCALCONF=./sample-files/local-arago64-v2.conf.sample
 BITBAKE_INCLUSIVE_VARS=yes