diff mbox series

[meta-arago,master/kirkstone,1/2] arago.conf: add opencl as a distro feature

Message ID 20230530214757.3693099-2-rs@ti.com
State Superseded
Delegated to: Ryan Eatmon
Headers show
Series Add piglit and opencl support | expand

Commit Message

Randolph Sapp May 30, 2023, 9:47 p.m. UTC
From: Randolph Sapp <rs@ti.com>

Rogue devices now have limited support for opencl. Further testing is
required but this is safe to enable now.

Signed-off-by: Randolph Sapp <rs@ti.com>
---
 meta-arago-distro/conf/distro/arago.conf | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Ryan Eatmon June 5, 2023, 4:57 p.m. UTC | #1
On 5/30/2023 4:47 PM, rs@ti.com wrote:
> From: Randolph Sapp <rs@ti.com>
> 
> Rogue devices now have limited support for opencl. Further testing is
> required but this is safe to enable now.
> 
> Signed-off-by: Randolph Sapp <rs@ti.com>
> ---
>   meta-arago-distro/conf/distro/arago.conf | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/meta-arago-distro/conf/distro/arago.conf b/meta-arago-distro/conf/distro/arago.conf
> index 379b1d44..a6425fae 100644
> --- a/meta-arago-distro/conf/distro/arago.conf
> +++ b/meta-arago-distro/conf/distro/arago.conf
> @@ -47,7 +47,7 @@ DISTRO_FEATURES = "${DISTRO_FEATURES_DEFAULT} ${DISTRO_FEATURES_LIBC}"
>   
>   # Add additional distro features
>   DISTRO_FEATURES:append = " pam wayland opengl"
> -#DISTRO_FEATURES:append = " opencl"
> +DISTRO_FEATURES:append = " opencl"

This change has opened a can of worms.  A lot of build failures.  Some 
of the dependent recipes were not migrated over from dunfell to 
kirkstone and those dependencies were hidden behind this feature being 
turned off.

If you want to recreate the build failures you can run:

MACHINE=am57xx-evm bitbake -k tisdk-core-bundle tisdk-tiny-image ti-world


We need to either prune out some more older recipes that are depending 
on the missing packages, restore the missing packages and clean them up 
per the kirkstone rules and machine renames, or option C (yet to be 
thought of).

Needless to say, no quick fix for this one.  So I'm holding off 
accepting this patch series.


>   DISTRO_FEATURES:append = " vulkan"
>   DISTRO_FEATURES:append = " opencv"
>   DISTRO_FEATURES:append = " openmp"
Denys Dmytriyenko June 6, 2023, 10:56 p.m. UTC | #2
On Mon, Jun 05, 2023 at 11:57:51AM -0500, Ryan Eatmon via lists.yoctoproject.org wrote:
> 
> 
> On 5/30/2023 4:47 PM, rs@ti.com wrote:
> >From: Randolph Sapp <rs@ti.com>
> >
> >Rogue devices now have limited support for opencl. Further testing is
> >required but this is safe to enable now.
> >
> >Signed-off-by: Randolph Sapp <rs@ti.com>
> >---
> >  meta-arago-distro/conf/distro/arago.conf | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> >diff --git a/meta-arago-distro/conf/distro/arago.conf b/meta-arago-distro/conf/distro/arago.conf
> >index 379b1d44..a6425fae 100644
> >--- a/meta-arago-distro/conf/distro/arago.conf
> >+++ b/meta-arago-distro/conf/distro/arago.conf
> >@@ -47,7 +47,7 @@ DISTRO_FEATURES = "${DISTRO_FEATURES_DEFAULT} ${DISTRO_FEATURES_LIBC}"
> >  # Add additional distro features
> >  DISTRO_FEATURES:append = " pam wayland opengl"
> >-#DISTRO_FEATURES:append = " opencl"
> >+DISTRO_FEATURES:append = " opencl"
> 
> This change has opened a can of worms.  A lot of build failures.
> Some of the dependent recipes were not migrated over from dunfell to
> kirkstone and those dependencies were hidden behind this feature
> being turned off.
> 
> If you want to recreate the build failures you can run:
> 
> MACHINE=am57xx-evm bitbake -k tisdk-core-bundle tisdk-tiny-image ti-world
> 
> 
> We need to either prune out some more older recipes that are
> depending on the missing packages, restore the missing packages and
> clean them up per the kirkstone rules and machine renames, or option
> C (yet to be thought of).
> 
> Needless to say, no quick fix for this one.  So I'm holding off
> accepting this patch series.
> 
> 
> >  DISTRO_FEATURES:append = " vulkan"
> >  DISTRO_FEATURES:append = " opencv"
> >  DISTRO_FEATURES:append = " openmp"

There are several old components in meta-arago-extras that are keyed off of 
"opencl" distro feature, that were doing task offloading to DSPs and EVEs on 
older platforms, like K2 and AM57x. Those are TI forks of OpenCL, OpenMP, 
OpenVX to work with old version of TIDL for EdgeAI back in the day:
https://www.cnx-software.com/2019/02/28/ti-am5729-beaglebone-ai-dsp-eve/

And when meta-ti was being restructured for Kirkstone and lower level 
dependencies were deprecated couple years ago, the fate of these components 
wasn't decided yet. If there are no downstream consumers of these pieces now, 
I guess they can be removed:
https://git.yoctoproject.org/meta-arago/tree/meta-arago-extras/recipes-ti
diff mbox series

Patch

diff --git a/meta-arago-distro/conf/distro/arago.conf b/meta-arago-distro/conf/distro/arago.conf
index 379b1d44..a6425fae 100644
--- a/meta-arago-distro/conf/distro/arago.conf
+++ b/meta-arago-distro/conf/distro/arago.conf
@@ -47,7 +47,7 @@  DISTRO_FEATURES = "${DISTRO_FEATURES_DEFAULT} ${DISTRO_FEATURES_LIBC}"
 
 # Add additional distro features
 DISTRO_FEATURES:append = " pam wayland opengl"
-#DISTRO_FEATURES:append = " opencl"
+DISTRO_FEATURES:append = " opencl"
 DISTRO_FEATURES:append = " vulkan"
 DISTRO_FEATURES:append = " opencv"
 DISTRO_FEATURES:append = " openmp"