| Message ID | 20230501163915.10612-1-reatmon@ti.com |
|---|---|
| State | Rejected |
| Delegated to: | Ryan Eatmon |
| Headers | show |
| Series | [meta-arago,master/kirkstone] packagegroup-arago-gst: Disable vpe and ducati plugins | expand |
On Mon, May 01, 2023 at 11:39:15AM -0500, Ryan Eatmon via lists.yoctoproject.org wrote: > The code for the plugins uses dma allocation code that we add in with a > patch. Theoretically we no longer need that code and can use some > upstreamed dma buffer allocation code. The work to rewrite these > plugins to support the newer gstreamer versions needs to be scheduled. I'm guessing you are missing this in "ltsprep" and other brandings: https://git.yoctoproject.org/meta-arago/tree/meta-arago-distro/conf/distro/include/branding-core.inc#n15 But it is a more broader approach, so maybe surgically disabling individual components and re-enabling "mmip" machine feature in "core" is better... > In the meantime, disable using these plugins that cause build errors. > > Signed-off-by: Ryan Eatmon <reatmon@ti.com> > --- > .../recipes-core/packagegroups/packagegroup-arago-gst.bb | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-gst.bb b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-gst.bb > index e8a639bd..2184ab58 100644 > --- a/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-gst.bb > +++ b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-gst.bb > @@ -27,8 +27,8 @@ GSTREAMER_DEPS:append:dra7xx = " \ > " > > GSTREAMER_ACCEL_MM = "" > -GSTREAMER_ACCEL_MM:omap-a15 = "${@bb.utils.contains('MACHINE_FEATURES', 'mmip', "gstreamer1.0-plugins-ducati", '', d)}" > -GSTREAMER_ACCEL_MM:append:dra7xx = "${@bb.utils.contains('MACHINE_FEATURES', 'mmip', " gstreamer1.0-plugins-vpe", '', d)}" > +#GSTREAMER_ACCEL_MM:omap-a15 = "${@bb.utils.contains('MACHINE_FEATURES', 'mmip', "gstreamer1.0-plugins-ducati", '', d)}" > +#GSTREAMER_ACCEL_MM:append:dra7xx = "${@bb.utils.contains('MACHINE_FEATURES', 'mmip', " gstreamer1.0-plugins-vpe", '', d)}" > > RDEPENDS:${PN} = "\ > ${GSTREAMER_DEPS} \ > -- > 2.17.1
On 5/1/2023 11:55, Denys Dmytriyenko wrote: > On Mon, May 01, 2023 at 11:39:15AM -0500, Ryan Eatmon via lists.yoctoproject.org wrote: >> The code for the plugins uses dma allocation code that we add in with a >> patch. Theoretically we no longer need that code and can use some >> upstreamed dma buffer allocation code. The work to rewrite these >> plugins to support the newer gstreamer versions needs to be scheduled. > > I'm guessing you are missing this in "ltsprep" and other brandings: > https://git.yoctoproject.org/meta-arago/tree/meta-arago-distro/conf/distro/include/branding-core.inc#n15 > > But it is a more broader approach, so maybe surgically disabling individual > components and re-enabling "mmip" machine feature in "core" is better... It's not that I missed it, but evn running ltsprep the recipes were being included and they fail to build. So something else must be going on to make them be included. Let me look into it. I still need to understand why we did not see these build failures in kirkstone-wip. Because these errors are related to the version of gstreamer and the bbappends not being applied. And the only time these tests were turned off was under ltsprep... Odd. > >> In the meantime, disable using these plugins that cause build errors. >> >> Signed-off-by: Ryan Eatmon <reatmon@ti.com> >> --- >> .../recipes-core/packagegroups/packagegroup-arago-gst.bb | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-gst.bb b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-gst.bb >> index e8a639bd..2184ab58 100644 >> --- a/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-gst.bb >> +++ b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-gst.bb >> @@ -27,8 +27,8 @@ GSTREAMER_DEPS:append:dra7xx = " \ >> " >> >> GSTREAMER_ACCEL_MM = "" >> -GSTREAMER_ACCEL_MM:omap-a15 = "${@bb.utils.contains('MACHINE_FEATURES', 'mmip', "gstreamer1.0-plugins-ducati", '', d)}" >> -GSTREAMER_ACCEL_MM:append:dra7xx = "${@bb.utils.contains('MACHINE_FEATURES', 'mmip', " gstreamer1.0-plugins-vpe", '', d)}" >> +#GSTREAMER_ACCEL_MM:omap-a15 = "${@bb.utils.contains('MACHINE_FEATURES', 'mmip', "gstreamer1.0-plugins-ducati", '', d)}" >> +#GSTREAMER_ACCEL_MM:append:dra7xx = "${@bb.utils.contains('MACHINE_FEATURES', 'mmip', " gstreamer1.0-plugins-vpe", '', d)}" >> >> RDEPENDS:${PN} = "\ >> ${GSTREAMER_DEPS} \ >> -- >> 2.17.1
On Mon, May 01, 2023 at 01:39:12PM -0500, Ryan Eatmon wrote: > > > On 5/1/2023 11:55, Denys Dmytriyenko wrote: > >On Mon, May 01, 2023 at 11:39:15AM -0500, Ryan Eatmon via lists.yoctoproject.org wrote: > >>The code for the plugins uses dma allocation code that we add in with a > >>patch. Theoretically we no longer need that code and can use some > >>upstreamed dma buffer allocation code. The work to rewrite these > >>plugins to support the newer gstreamer versions needs to be scheduled. > > > >I'm guessing you are missing this in "ltsprep" and other brandings: > >https://git.yoctoproject.org/meta-arago/tree/meta-arago-distro/conf/distro/include/branding-core.inc#n15 > > > >But it is a more broader approach, so maybe surgically disabling individual > >components and re-enabling "mmip" machine feature in "core" is better... > > It's not that I missed it, but evn running ltsprep the recipes were > being included and they fail to build. So something else must be > going on to make them be included. Let me look into it. > > I still need to understand why we did not see these build failures > in kirkstone-wip. Because these errors are related to the version > of gstreamer and the bbappends not being applied. And the only time > these tests were turned off was under ltsprep... Odd. I think you got it in reverse: "mmip" is being completely disabled for default "core" builds, but not for "ltsprep" ones, hence you see the breakage there. > >>In the meantime, disable using these plugins that cause build errors. > >> > >>Signed-off-by: Ryan Eatmon <reatmon@ti.com> > >>--- > >> .../recipes-core/packagegroups/packagegroup-arago-gst.bb | 4 ++-- > >> 1 file changed, 2 insertions(+), 2 deletions(-) > >> > >>diff --git a/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-gst.bb b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-gst.bb > >>index e8a639bd..2184ab58 100644 > >>--- a/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-gst.bb > >>+++ b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-gst.bb > >>@@ -27,8 +27,8 @@ GSTREAMER_DEPS:append:dra7xx = " \ > >> " > >> GSTREAMER_ACCEL_MM = "" > >>-GSTREAMER_ACCEL_MM:omap-a15 = "${@bb.utils.contains('MACHINE_FEATURES', 'mmip', "gstreamer1.0-plugins-ducati", '', d)}" > >>-GSTREAMER_ACCEL_MM:append:dra7xx = "${@bb.utils.contains('MACHINE_FEATURES', 'mmip', " gstreamer1.0-plugins-vpe", '', d)}" > >>+#GSTREAMER_ACCEL_MM:omap-a15 = "${@bb.utils.contains('MACHINE_FEATURES', 'mmip', "gstreamer1.0-plugins-ducati", '', d)}" > >>+#GSTREAMER_ACCEL_MM:append:dra7xx = "${@bb.utils.contains('MACHINE_FEATURES', 'mmip', " gstreamer1.0-plugins-vpe", '', d)}" > >> RDEPENDS:${PN} = "\ > >> ${GSTREAMER_DEPS} \ > >>-- > >>2.17.1
On 5/1/2023 13:49, Denys Dmytriyenko wrote: > On Mon, May 01, 2023 at 01:39:12PM -0500, Ryan Eatmon wrote: >> >> >> On 5/1/2023 11:55, Denys Dmytriyenko wrote: >>> On Mon, May 01, 2023 at 11:39:15AM -0500, Ryan Eatmon via lists.yoctoproject.org wrote: >>>> The code for the plugins uses dma allocation code that we add in with a >>>> patch. Theoretically we no longer need that code and can use some >>>> upstreamed dma buffer allocation code. The work to rewrite these >>>> plugins to support the newer gstreamer versions needs to be scheduled. >>> >>> I'm guessing you are missing this in "ltsprep" and other brandings: >>> https://git.yoctoproject.org/meta-arago/tree/meta-arago-distro/conf/distro/include/branding-core.inc#n15 >>> >>> But it is a more broader approach, so maybe surgically disabling individual >>> components and re-enabling "mmip" machine feature in "core" is better... >> >> It's not that I missed it, but evn running ltsprep the recipes were >> being included and they fail to build. So something else must be >> going on to make them be included. Let me look into it. >> >> I still need to understand why we did not see these build failures >> in kirkstone-wip. Because these errors are related to the version >> of gstreamer and the bbappends not being applied. And the only time >> these tests were turned off was under ltsprep... Odd. > > I think you got it in reverse: "mmip" is being completely disabled for default > "core" builds, but not for "ltsprep" ones, hence you see the breakage there. Ahhhh... gotcha... Yes. That is what is missing. I'll remove this patch and add that to the ltsprep brand file. > >>>> In the meantime, disable using these plugins that cause build errors. >>>> >>>> Signed-off-by: Ryan Eatmon <reatmon@ti.com> >>>> --- >>>> .../recipes-core/packagegroups/packagegroup-arago-gst.bb | 4 ++-- >>>> 1 file changed, 2 insertions(+), 2 deletions(-) >>>> >>>> diff --git a/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-gst.bb b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-gst.bb >>>> index e8a639bd..2184ab58 100644 >>>> --- a/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-gst.bb >>>> +++ b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-gst.bb >>>> @@ -27,8 +27,8 @@ GSTREAMER_DEPS:append:dra7xx = " \ >>>> " >>>> GSTREAMER_ACCEL_MM = "" >>>> -GSTREAMER_ACCEL_MM:omap-a15 = "${@bb.utils.contains('MACHINE_FEATURES', 'mmip', "gstreamer1.0-plugins-ducati", '', d)}" >>>> -GSTREAMER_ACCEL_MM:append:dra7xx = "${@bb.utils.contains('MACHINE_FEATURES', 'mmip', " gstreamer1.0-plugins-vpe", '', d)}" >>>> +#GSTREAMER_ACCEL_MM:omap-a15 = "${@bb.utils.contains('MACHINE_FEATURES', 'mmip', "gstreamer1.0-plugins-ducati", '', d)}" >>>> +#GSTREAMER_ACCEL_MM:append:dra7xx = "${@bb.utils.contains('MACHINE_FEATURES', 'mmip', " gstreamer1.0-plugins-vpe", '', d)}" >>>> RDEPENDS:${PN} = "\ >>>> ${GSTREAMER_DEPS} \ >>>> -- >>>> 2.17.1
On Mon, May 01, 2023 at 02:08:40PM -0500, Ryan Eatmon wrote: > > > On 5/1/2023 13:49, Denys Dmytriyenko wrote: > >On Mon, May 01, 2023 at 01:39:12PM -0500, Ryan Eatmon wrote: > >> > >> > >>On 5/1/2023 11:55, Denys Dmytriyenko wrote: > >>>On Mon, May 01, 2023 at 11:39:15AM -0500, Ryan Eatmon via lists.yoctoproject.org wrote: > >>>>The code for the plugins uses dma allocation code that we add in with a > >>>>patch. Theoretically we no longer need that code and can use some > >>>>upstreamed dma buffer allocation code. The work to rewrite these > >>>>plugins to support the newer gstreamer versions needs to be scheduled. > >>> > >>>I'm guessing you are missing this in "ltsprep" and other brandings: > >>>https://git.yoctoproject.org/meta-arago/tree/meta-arago-distro/conf/distro/include/branding-core.inc#n15 > >>> > >>>But it is a more broader approach, so maybe surgically disabling individual > >>>components and re-enabling "mmip" machine feature in "core" is better... > >> > >>It's not that I missed it, but evn running ltsprep the recipes were > >>being included and they fail to build. So something else must be > >>going on to make them be included. Let me look into it. > >> > >>I still need to understand why we did not see these build failures > >>in kirkstone-wip. Because these errors are related to the version > >>of gstreamer and the bbappends not being applied. And the only time > >>these tests were turned off was under ltsprep... Odd. > > > >I think you got it in reverse: "mmip" is being completely disabled for default > >"core" builds, but not for "ltsprep" ones, hence you see the breakage there. > > Ahhhh... gotcha... Yes. That is what is missing. I'll remove this > patch and add that to the ltsprep brand file. What about this one: https://patchwork.yoctoproject.org/project/arago/patch/20230429144445.32401-1-reatmon@ti.com/ > >>>>In the meantime, disable using these plugins that cause build errors. > >>>> > >>>>Signed-off-by: Ryan Eatmon <reatmon@ti.com> > >>>>--- > >>>> .../recipes-core/packagegroups/packagegroup-arago-gst.bb | 4 ++-- > >>>> 1 file changed, 2 insertions(+), 2 deletions(-) > >>>> > >>>>diff --git a/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-gst.bb b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-gst.bb > >>>>index e8a639bd..2184ab58 100644 > >>>>--- a/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-gst.bb > >>>>+++ b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-gst.bb > >>>>@@ -27,8 +27,8 @@ GSTREAMER_DEPS:append:dra7xx = " \ > >>>> " > >>>> GSTREAMER_ACCEL_MM = "" > >>>>-GSTREAMER_ACCEL_MM:omap-a15 = "${@bb.utils.contains('MACHINE_FEATURES', 'mmip', "gstreamer1.0-plugins-ducati", '', d)}" > >>>>-GSTREAMER_ACCEL_MM:append:dra7xx = "${@bb.utils.contains('MACHINE_FEATURES', 'mmip', " gstreamer1.0-plugins-vpe", '', d)}" > >>>>+#GSTREAMER_ACCEL_MM:omap-a15 = "${@bb.utils.contains('MACHINE_FEATURES', 'mmip', "gstreamer1.0-plugins-ducati", '', d)}" > >>>>+#GSTREAMER_ACCEL_MM:append:dra7xx = "${@bb.utils.contains('MACHINE_FEATURES', 'mmip', " gstreamer1.0-plugins-vpe", '', d)}" > >>>> RDEPENDS:${PN} = "\ > >>>> ${GSTREAMER_DEPS} \ > >>>>-- > >>>>2.17.1
On 5/1/2023 14:10, Denys Dmytriyenko wrote: > On Mon, May 01, 2023 at 02:08:40PM -0500, Ryan Eatmon wrote: >> >> >> On 5/1/2023 13:49, Denys Dmytriyenko wrote: >>> On Mon, May 01, 2023 at 01:39:12PM -0500, Ryan Eatmon wrote: >>>> >>>> >>>> On 5/1/2023 11:55, Denys Dmytriyenko wrote: >>>>> On Mon, May 01, 2023 at 11:39:15AM -0500, Ryan Eatmon via lists.yoctoproject.org wrote: >>>>>> The code for the plugins uses dma allocation code that we add in with a >>>>>> patch. Theoretically we no longer need that code and can use some >>>>>> upstreamed dma buffer allocation code. The work to rewrite these >>>>>> plugins to support the newer gstreamer versions needs to be scheduled. >>>>> >>>>> I'm guessing you are missing this in "ltsprep" and other brandings: >>>>> https://git.yoctoproject.org/meta-arago/tree/meta-arago-distro/conf/distro/include/branding-core.inc#n15 >>>>> >>>>> But it is a more broader approach, so maybe surgically disabling individual >>>>> components and re-enabling "mmip" machine feature in "core" is better... >>>> >>>> It's not that I missed it, but evn running ltsprep the recipes were >>>> being included and they fail to build. So something else must be >>>> going on to make them be included. Let me look into it. >>>> >>>> I still need to understand why we did not see these build failures >>>> in kirkstone-wip. Because these errors are related to the version >>>> of gstreamer and the bbappends not being applied. And the only time >>>> these tests were turned off was under ltsprep... Odd. >>> >>> I think you got it in reverse: "mmip" is being completely disabled for default >>> "core" builds, but not for "ltsprep" ones, hence you see the breakage there. >> >> Ahhhh... gotcha... Yes. That is what is missing. I'll remove this >> patch and add that to the ltsprep brand file. > > What about this one: > https://patchwork.yoctoproject.org/project/arago/patch/20230429144445.32401-1-reatmon@ti.com/ Yes. It falls into the same bucket. Turning off mmip in ltsprep will mean that patch can be removed as well. > >>>>>> In the meantime, disable using these plugins that cause build errors. >>>>>> >>>>>> Signed-off-by: Ryan Eatmon <reatmon@ti.com> >>>>>> --- >>>>>> .../recipes-core/packagegroups/packagegroup-arago-gst.bb | 4 ++-- >>>>>> 1 file changed, 2 insertions(+), 2 deletions(-) >>>>>> >>>>>> diff --git a/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-gst.bb b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-gst.bb >>>>>> index e8a639bd..2184ab58 100644 >>>>>> --- a/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-gst.bb >>>>>> +++ b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-gst.bb >>>>>> @@ -27,8 +27,8 @@ GSTREAMER_DEPS:append:dra7xx = " \ >>>>>> " >>>>>> GSTREAMER_ACCEL_MM = "" >>>>>> -GSTREAMER_ACCEL_MM:omap-a15 = "${@bb.utils.contains('MACHINE_FEATURES', 'mmip', "gstreamer1.0-plugins-ducati", '', d)}" >>>>>> -GSTREAMER_ACCEL_MM:append:dra7xx = "${@bb.utils.contains('MACHINE_FEATURES', 'mmip', " gstreamer1.0-plugins-vpe", '', d)}" >>>>>> +#GSTREAMER_ACCEL_MM:omap-a15 = "${@bb.utils.contains('MACHINE_FEATURES', 'mmip', "gstreamer1.0-plugins-ducati", '', d)}" >>>>>> +#GSTREAMER_ACCEL_MM:append:dra7xx = "${@bb.utils.contains('MACHINE_FEATURES', 'mmip', " gstreamer1.0-plugins-vpe", '', d)}" >>>>>> RDEPENDS:${PN} = "\ >>>>>> ${GSTREAMER_DEPS} \ >>>>>> -- >>>>>> 2.17.1
diff --git a/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-gst.bb b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-gst.bb index e8a639bd..2184ab58 100644 --- a/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-gst.bb +++ b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-gst.bb @@ -27,8 +27,8 @@ GSTREAMER_DEPS:append:dra7xx = " \ " GSTREAMER_ACCEL_MM = "" -GSTREAMER_ACCEL_MM:omap-a15 = "${@bb.utils.contains('MACHINE_FEATURES', 'mmip', "gstreamer1.0-plugins-ducati", '', d)}" -GSTREAMER_ACCEL_MM:append:dra7xx = "${@bb.utils.contains('MACHINE_FEATURES', 'mmip', " gstreamer1.0-plugins-vpe", '', d)}" +#GSTREAMER_ACCEL_MM:omap-a15 = "${@bb.utils.contains('MACHINE_FEATURES', 'mmip', "gstreamer1.0-plugins-ducati", '', d)}" +#GSTREAMER_ACCEL_MM:append:dra7xx = "${@bb.utils.contains('MACHINE_FEATURES', 'mmip', " gstreamer1.0-plugins-vpe", '', d)}" RDEPENDS:${PN} = "\ ${GSTREAMER_DEPS} \
The code for the plugins uses dma allocation code that we add in with a patch. Theoretically we no longer need that code and can use some upstreamed dma buffer allocation code. The work to rewrite these plugins to support the newer gstreamer versions needs to be scheduled. In the meantime, disable using these plugins that cause build errors. Signed-off-by: Ryan Eatmon <reatmon@ti.com> --- .../recipes-core/packagegroups/packagegroup-arago-gst.bb | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)