diff mbox series

[meta-arago,master/kirkstone,5/6] qtwayland: add comment about why this append exists

Message ID 20230426213214.3501230-6-rs@ti.com
State Superseded
Delegated to: Ryan Eatmon
Headers show
Series Vulkan prep and some cleanup | expand

Commit Message

Randolph Sapp April 26, 2023, 9:32 p.m. UTC
From: Randolph Sapp <rs@ti.com>

Add some info about why this bbappend still exists. It's to prefer
wayland over x11 and remove some unoptimized components.

Signed-off-by: Randolph Sapp <rs@ti.com>
---
 meta-arago-distro/recipes-qt/qt5/qtwayland_git.bbappend | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Andrew Davis April 26, 2023, 11:22 p.m. UTC | #1
On 4/26/23 4:32 PM, rs@ti.com wrote:
> From: Randolph Sapp <rs@ti.com>
> 
> Add some info about why this bbappend still exists. It's to prefer
> wayland over x11 and remove some unoptimized components.
> 
> Signed-off-by: Randolph Sapp <rs@ti.com>
> ---
>   meta-arago-distro/recipes-qt/qt5/qtwayland_git.bbappend | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/meta-arago-distro/recipes-qt/qt5/qtwayland_git.bbappend b/meta-arago-distro/recipes-qt/qt5/qtwayland_git.bbappend
> index e7560d02..82cb657a 100644
> --- a/meta-arago-distro/recipes-qt/qt5/qtwayland_git.bbappend
> +++ b/meta-arago-distro/recipes-qt/qt5/qtwayland_git.bbappend
> @@ -1,4 +1,4 @@
> -FILESEXTRAPATHS:prepend := "${THISDIR}/${PN}:"

This above line can be removed when you removed the last carried
patch, squash into the last patch.

> -PR:append = ".arago2"

Since you are changing this package from the default, it is usually
a good idea to keep this line, so it is clear this is a "Arago"
version of this package.

And since this package was changed in your last patch (probably not
in a noticeable way but still..) you should bump the version .arago3

Andrew

> +# This append exists to modify the PACKAGECONFIG such that the wayland backend
> +# is preferred over x11 and unoptimized components are removed.
>   
>   PACKAGECONFIG:remove = "xcomposite-egl xcomposite-glx"
diff mbox series

Patch

diff --git a/meta-arago-distro/recipes-qt/qt5/qtwayland_git.bbappend b/meta-arago-distro/recipes-qt/qt5/qtwayland_git.bbappend
index e7560d02..82cb657a 100644
--- a/meta-arago-distro/recipes-qt/qt5/qtwayland_git.bbappend
+++ b/meta-arago-distro/recipes-qt/qt5/qtwayland_git.bbappend
@@ -1,4 +1,4 @@ 
-FILESEXTRAPATHS:prepend := "${THISDIR}/${PN}:"
-PR:append = ".arago2"
+# This append exists to modify the PACKAGECONFIG such that the wayland backend
+# is preferred over x11 and unoptimized components are removed.
 
 PACKAGECONFIG:remove = "xcomposite-egl xcomposite-glx"