diff mbox series

[meta-arago,master/kirkstone] net-snmp: Remove broken net-snmp recipe

Message ID 20221025142235.12400-1-afd@ti.com
State New
Delegated to: Denys Dmytriyenko
Headers show
Series [meta-arago,master/kirkstone] net-snmp: Remove broken net-snmp recipe | expand

Commit Message

Andrew Davis Oct. 25, 2022, 2:22 p.m. UTC
This bbappend is not functional on the latest net-snmp. The additional
patches are ~61k lines, half the entire size of meta-arago. This extra
functionality should have been added to a forked repo and that is how we
should add this back if ever needed again. Remove this recipe.

Signed-off-by: Andrew Davis <afd@ti.com>
---

Patch created with --irreversible-delete to prevent oversized email,
will need manually applied.

 .../packagegroup-arago-tisdk-connectivity.bb  |     2 -
 .../net-snmp/files/snmpd.conf                 |   422 -
 ...initial-support-for-hsr-prp-mib-supp.patch |  1224 -
 ...a-dummy-lreInterfaceConfigTable-for-.patch |   326 -
 ...update-lreInterfaceConfigTable-for-M.patch | 12791 -------
 ...update-lreInterfaceTable-to-use-real.patch |   413 -
 ...2439-3-MIB-refractor-code-for-re-use.patch |   403 -
 ...update-to-get-real-slave-admin-and-l.patch |   612 -
 ...add-functions-to-get-set-real-values.patch |   471 -
 ...Move-existing-lre-access-functions-t.patch |   884 -
 ...add-initial-version-of-stats-and-nod.patch | 10371 -----
 ...-3-MIB-Add-support-for-lreNodesTable.patch |  1236 -
 .../0011-IEC-62439-3-MIB-bug-fixes.patch      |   722 -
 ...Fix-index-issue-in-table-implementat.patch |    87 -
 ...39-3-MIB-Add-command-to-set-HSR-mode.patch |    34 -
 ...-3-MIB-add-license-header-to-sources.patch | 31871 ----------------
 ...fix-lreManufacturerName-displaying-d.patch |    34 -
 ...fix-duplicate-discard-mode-setting-f.patch |    53 -
 ...to-retrieve-mibs-from-main-interface.patch |   700 -
 ...update-to-work-with-iproute2-changes.patch |    71 -
 .../net-snmp/net-snmp_%.bbappend              |    31 -
 21 files changed, 62758 deletions(-)
 delete mode 100644 meta-arago-distro/recipes-protocols/net-snmp/files/snmpd.conf
 delete mode 100644 meta-arago-distro/recipes-protocols/net-snmp/net-snmp/0001-IEC-62439-3-add-initial-support-for-hsr-prp-mib-supp.patch
 delete mode 100644 meta-arago-distro/recipes-protocols/net-snmp/net-snmp/0002-IEC-62439-3-add-a-dummy-lreInterfaceConfigTable-for-.patch
 delete mode 100644 meta-arago-distro/recipes-protocols/net-snmp/net-snmp/0003-IEC-62439-3-MIB-update-lreInterfaceConfigTable-for-M.patch
 delete mode 100644 meta-arago-distro/recipes-protocols/net-snmp/net-snmp/0004-IEC-62439-3-MIB-update-lreInterfaceTable-to-use-real.patch
 delete mode 100644 meta-arago-distro/recipes-protocols/net-snmp/net-snmp/0005-IEC-62439-3-MIB-refractor-code-for-re-use.patch
 delete mode 100644 meta-arago-distro/recipes-protocols/net-snmp/net-snmp/0006-IEC-62439-3-MIB-update-to-get-real-slave-admin-and-l.patch
 delete mode 100644 meta-arago-distro/recipes-protocols/net-snmp/net-snmp/0007-IEC-62439-3-MIB-add-functions-to-get-set-real-values.patch
 delete mode 100644 meta-arago-distro/recipes-protocols/net-snmp/net-snmp/0008-IEC-62439-3-MIB-Move-existing-lre-access-functions-t.patch
 delete mode 100644 meta-arago-distro/recipes-protocols/net-snmp/net-snmp/0009-IEC-62439-3-MIB-add-initial-version-of-stats-and-nod.patch
 delete mode 100644 meta-arago-distro/recipes-protocols/net-snmp/net-snmp/0010-IEC-62439-3-MIB-Add-support-for-lreNodesTable.patch
 delete mode 100644 meta-arago-distro/recipes-protocols/net-snmp/net-snmp/0011-IEC-62439-3-MIB-bug-fixes.patch
 delete mode 100644 meta-arago-distro/recipes-protocols/net-snmp/net-snmp/0012-IEC-62439-3-MIB-Fix-index-issue-in-table-implementat.patch
 delete mode 100644 meta-arago-distro/recipes-protocols/net-snmp/net-snmp/0013-IEC-62439-3-MIB-Add-command-to-set-HSR-mode.patch
 delete mode 100644 meta-arago-distro/recipes-protocols/net-snmp/net-snmp/0014-IEC-62439-3-MIB-add-license-header-to-sources.patch
 delete mode 100644 meta-arago-distro/recipes-protocols/net-snmp/net-snmp/0015-IEC-62439-3-MIB-fix-lreManufacturerName-displaying-d.patch
 delete mode 100644 meta-arago-distro/recipes-protocols/net-snmp/net-snmp/0016-IEC-62439-3-MIB-fix-duplicate-discard-mode-setting-f.patch
 delete mode 100644 meta-arago-distro/recipes-protocols/net-snmp/net-snmp/0017-hsr-prp-update-to-retrieve-mibs-from-main-interface.patch
 delete mode 100644 meta-arago-distro/recipes-protocols/net-snmp/net-snmp/0018-IEC-62439-3-MIB-update-to-work-with-iproute2-changes.patch
 delete mode 100644 meta-arago-distro/recipes-protocols/net-snmp/net-snmp_%.bbappend

Comments

Denys Dmytriyenko Oct. 25, 2022, 9:30 p.m. UTC | #1
On Tue, Oct 25, 2022 at 09:22:35AM -0500, Andrew Davis via lists.yoctoproject.org wrote:
> This bbappend is not functional on the latest net-snmp. The additional
> patches are ~61k lines, half the entire size of meta-arago. This extra
> functionality should have been added to a forked repo and that is how we
> should add this back if ever needed again. Remove this recipe.

I'm fine with removing these patches, since they break the latest snmp and 
it's been disabled in default images since Kirkstone.

But I'm not so sure about promoting forked repo concept...

The best approach, of course, is to get the patches submitted, reviewed and 
accepted upstream (snmp in this case).

Making changes with patches, instead of a forked repo, has this benefit - when 
updating layer to a new release/LTS and these patches start breaking, it gets 
noticed right away. It forces a decision - either someone is tasked with 
updating the patches and fixing the breakage, or they get removed/disabled at 
least.

Using a forked repo has a high possibility of a stale and outdated component, 
collecting security vulnerabilities, unfixed bugs, etc.
Andrew Davis Oct. 26, 2022, 3:57 p.m. UTC | #2
On 10/25/22 4:30 PM, Denys Dmytriyenko wrote:
> On Tue, Oct 25, 2022 at 09:22:35AM -0500, Andrew Davis via lists.yoctoproject.org wrote:
>> This bbappend is not functional on the latest net-snmp. The additional
>> patches are ~61k lines, half the entire size of meta-arago. This extra
>> functionality should have been added to a forked repo and that is how we
>> should add this back if ever needed again. Remove this recipe.
> 
> I'm fine with removing these patches, since they break the latest snmp and
> it's been disabled in default images since Kirkstone.
> 
> But I'm not so sure about promoting forked repo concept...
> 
> The best approach, of course, is to get the patches submitted, reviewed and
> accepted upstream (snmp in this case).
> 
> Making changes with patches, instead of a forked repo, has this benefit - when
> updating layer to a new release/LTS and these patches start breaking, it gets
> noticed right away. It forces a decision - either someone is tasked with
> updating the patches and fixing the breakage, or they get removed/disabled at
> least.
> 

That's fair. I'd say we also start to reduce our wildcard bbappends, if the
package moves forward underneath, then we should re-evaluate anyway.

> Using a forked repo has a high possibility of a stale and outdated component,
> collecting security vulnerabilities, unfixed bugs, etc.
> 

I'd normally agree, but at some point the amount of change justifies the fork.
This would certainly be such a case.

Andrew
diff mbox series

Patch

diff --git a/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-connectivity.bb b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-connectivity.bb
index 8798a44a..623ffc49 100644
--- a/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-connectivity.bb
+++ b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-connectivity.bb
@@ -51,8 +51,6 @@  BT_TI = "\
     bt-fw \
 "
 
-#    net-snmp
-#    net-snmp-server-snmpd
 CONNECTIVITY_RDEPENDS = " \
     htop \
     iptables \
diff --git a/meta-arago-distro/recipes-protocols/net-snmp/files/snmpd.conf b/meta-arago-distro/recipes-protocols/net-snmp/files/snmpd.conf
deleted file mode 100644
index 6c2f1755..00000000
diff --git a/meta-arago-distro/recipes-protocols/net-snmp/net-snmp/0001-IEC-62439-3-add-initial-support-for-hsr-prp-mib-supp.patch b/meta-arago-distro/recipes-protocols/net-snmp/net-snmp/0001-IEC-62439-3-add-initial-support-for-hsr-prp-mib-supp.patch
deleted file mode 100644
index 5f1f350a..00000000
diff --git a/meta-arago-distro/recipes-protocols/net-snmp/net-snmp/0002-IEC-62439-3-add-a-dummy-lreInterfaceConfigTable-for-.patch b/meta-arago-distro/recipes-protocols/net-snmp/net-snmp/0002-IEC-62439-3-add-a-dummy-lreInterfaceConfigTable-for-.patch
deleted file mode 100644
index dfabb06c..00000000
diff --git a/meta-arago-distro/recipes-protocols/net-snmp/net-snmp/0003-IEC-62439-3-MIB-update-lreInterfaceConfigTable-for-M.patch b/meta-arago-distro/recipes-protocols/net-snmp/net-snmp/0003-IEC-62439-3-MIB-update-lreInterfaceConfigTable-for-M.patch
deleted file mode 100644
index 30cd147d..00000000
diff --git a/meta-arago-distro/recipes-protocols/net-snmp/net-snmp/0004-IEC-62439-3-MIB-update-lreInterfaceTable-to-use-real.patch b/meta-arago-distro/recipes-protocols/net-snmp/net-snmp/0004-IEC-62439-3-MIB-update-lreInterfaceTable-to-use-real.patch
deleted file mode 100644
index 28e923f6..00000000
diff --git a/meta-arago-distro/recipes-protocols/net-snmp/net-snmp/0005-IEC-62439-3-MIB-refractor-code-for-re-use.patch b/meta-arago-distro/recipes-protocols/net-snmp/net-snmp/0005-IEC-62439-3-MIB-refractor-code-for-re-use.patch
deleted file mode 100644
index ac385243..00000000
diff --git a/meta-arago-distro/recipes-protocols/net-snmp/net-snmp/0006-IEC-62439-3-MIB-update-to-get-real-slave-admin-and-l.patch b/meta-arago-distro/recipes-protocols/net-snmp/net-snmp/0006-IEC-62439-3-MIB-update-to-get-real-slave-admin-and-l.patch
deleted file mode 100644
index 66cd8003..00000000
diff --git a/meta-arago-distro/recipes-protocols/net-snmp/net-snmp/0007-IEC-62439-3-MIB-add-functions-to-get-set-real-values.patch b/meta-arago-distro/recipes-protocols/net-snmp/net-snmp/0007-IEC-62439-3-MIB-add-functions-to-get-set-real-values.patch
deleted file mode 100644
index 27b811c2..00000000
diff --git a/meta-arago-distro/recipes-protocols/net-snmp/net-snmp/0008-IEC-62439-3-MIB-Move-existing-lre-access-functions-t.patch b/meta-arago-distro/recipes-protocols/net-snmp/net-snmp/0008-IEC-62439-3-MIB-Move-existing-lre-access-functions-t.patch
deleted file mode 100644
index 2659ddc0..00000000
diff --git a/meta-arago-distro/recipes-protocols/net-snmp/net-snmp/0009-IEC-62439-3-MIB-add-initial-version-of-stats-and-nod.patch b/meta-arago-distro/recipes-protocols/net-snmp/net-snmp/0009-IEC-62439-3-MIB-add-initial-version-of-stats-and-nod.patch
deleted file mode 100644
index 32715b0b..00000000
diff --git a/meta-arago-distro/recipes-protocols/net-snmp/net-snmp/0010-IEC-62439-3-MIB-Add-support-for-lreNodesTable.patch b/meta-arago-distro/recipes-protocols/net-snmp/net-snmp/0010-IEC-62439-3-MIB-Add-support-for-lreNodesTable.patch
deleted file mode 100644
index 25767032..00000000
diff --git a/meta-arago-distro/recipes-protocols/net-snmp/net-snmp/0011-IEC-62439-3-MIB-bug-fixes.patch b/meta-arago-distro/recipes-protocols/net-snmp/net-snmp/0011-IEC-62439-3-MIB-bug-fixes.patch
deleted file mode 100644
index 02b4ab7b..00000000
diff --git a/meta-arago-distro/recipes-protocols/net-snmp/net-snmp/0012-IEC-62439-3-MIB-Fix-index-issue-in-table-implementat.patch b/meta-arago-distro/recipes-protocols/net-snmp/net-snmp/0012-IEC-62439-3-MIB-Fix-index-issue-in-table-implementat.patch
deleted file mode 100644
index 3433a23d..00000000
diff --git a/meta-arago-distro/recipes-protocols/net-snmp/net-snmp/0013-IEC-62439-3-MIB-Add-command-to-set-HSR-mode.patch b/meta-arago-distro/recipes-protocols/net-snmp/net-snmp/0013-IEC-62439-3-MIB-Add-command-to-set-HSR-mode.patch
deleted file mode 100644
index a9719874..00000000
diff --git a/meta-arago-distro/recipes-protocols/net-snmp/net-snmp/0014-IEC-62439-3-MIB-add-license-header-to-sources.patch b/meta-arago-distro/recipes-protocols/net-snmp/net-snmp/0014-IEC-62439-3-MIB-add-license-header-to-sources.patch
deleted file mode 100644
index e8ca55f9..00000000
diff --git a/meta-arago-distro/recipes-protocols/net-snmp/net-snmp/0015-IEC-62439-3-MIB-fix-lreManufacturerName-displaying-d.patch b/meta-arago-distro/recipes-protocols/net-snmp/net-snmp/0015-IEC-62439-3-MIB-fix-lreManufacturerName-displaying-d.patch
deleted file mode 100644
index 9f2678a2..00000000
diff --git a/meta-arago-distro/recipes-protocols/net-snmp/net-snmp/0016-IEC-62439-3-MIB-fix-duplicate-discard-mode-setting-f.patch b/meta-arago-distro/recipes-protocols/net-snmp/net-snmp/0016-IEC-62439-3-MIB-fix-duplicate-discard-mode-setting-f.patch
deleted file mode 100644
index a95679d2..00000000
diff --git a/meta-arago-distro/recipes-protocols/net-snmp/net-snmp/0017-hsr-prp-update-to-retrieve-mibs-from-main-interface.patch b/meta-arago-distro/recipes-protocols/net-snmp/net-snmp/0017-hsr-prp-update-to-retrieve-mibs-from-main-interface.patch
deleted file mode 100644
index 717331eb..00000000
diff --git a/meta-arago-distro/recipes-protocols/net-snmp/net-snmp/0018-IEC-62439-3-MIB-update-to-work-with-iproute2-changes.patch b/meta-arago-distro/recipes-protocols/net-snmp/net-snmp/0018-IEC-62439-3-MIB-update-to-work-with-iproute2-changes.patch
deleted file mode 100644
index e62883dc..00000000
diff --git a/meta-arago-distro/recipes-protocols/net-snmp/net-snmp_%.bbappend b/meta-arago-distro/recipes-protocols/net-snmp/net-snmp_%.bbappend
deleted file mode 100644
index 32cbe416..00000000