| Message ID | 20220928204354.25876-1-reatmon@ti.com |
|---|---|
| State | Accepted |
| Delegated to: | Ryan Eatmon |
| Headers | show |
| Series | [oe-layersetup,master] oe-layer-setup.sh: restore number of threads to max | expand |
On Wed, Sep 28, 2022 at 03:43:54PM -0500, Ryan Eatmon via lists.yoctoproject.org wrote: > We are no longer using VMs for building and so should not need > to reduce the number of threads down by 75%. I would recommend dropping those lines altogether - these days bitbake defaults to max number of threads/processes on its own. > Signed-off-by: Ryan Eatmon <reatmon@ti.com> > --- > oe-layertool-setup.sh | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/oe-layertool-setup.sh b/oe-layertool-setup.sh > index e404290..1ea31c3 100755 > --- a/oe-layertool-setup.sh > +++ b/oe-layertool-setup.sh > @@ -770,9 +770,8 @@ EOM > > # set the number of threads > threads=`cat /proc/cpuinfo | grep -c processor` > - tnum=`expr \( ${threads} + 1 \) \* 75 / 100` > - sed -i "s/^PARALLEL_MAKE.*/PARALLEL_MAKE ?= \"-j ${tnum}\"/" $confdir/local.conf > - sed -i "s/^BB_NUMBER_THREADS.*/BB_NUMBER_THREADS ?= \"${tnum}\"/" $confdir/local.conf > + sed -i "s/^PARALLEL_MAKE.*/PARALLEL_MAKE ?= \"-j ${threads}\"/" $confdir/local.conf > + sed -i "s/^BB_NUMBER_THREADS.*/BB_NUMBER_THREADS ?= \"${threads}\"/" $confdir/local.conf > > # Find if old DL_DIR was set > if [ -e $confdir/local.conf.bak ] > -- > 2.17.1
On 9/28/2022 15:49, Denys Dmytriyenko wrote: > On Wed, Sep 28, 2022 at 03:43:54PM -0500, Ryan Eatmon via lists.yoctoproject.org wrote: >> We are no longer using VMs for building and so should not need >> to reduce the number of threads down by 75%. > > I would recommend dropping those lines altogether - these days bitbake > defaults to max number of threads/processes on its own. Even better. I'll make that change. >> Signed-off-by: Ryan Eatmon <reatmon@ti.com> >> --- >> oe-layertool-setup.sh | 5 ++--- >> 1 file changed, 2 insertions(+), 3 deletions(-) >> >> diff --git a/oe-layertool-setup.sh b/oe-layertool-setup.sh >> index e404290..1ea31c3 100755 >> --- a/oe-layertool-setup.sh >> +++ b/oe-layertool-setup.sh >> @@ -770,9 +770,8 @@ EOM >> >> # set the number of threads >> threads=`cat /proc/cpuinfo | grep -c processor` >> - tnum=`expr \( ${threads} + 1 \) \* 75 / 100` >> - sed -i "s/^PARALLEL_MAKE.*/PARALLEL_MAKE ?= \"-j ${tnum}\"/" $confdir/local.conf >> - sed -i "s/^BB_NUMBER_THREADS.*/BB_NUMBER_THREADS ?= \"${tnum}\"/" $confdir/local.conf >> + sed -i "s/^PARALLEL_MAKE.*/PARALLEL_MAKE ?= \"-j ${threads}\"/" $confdir/local.conf >> + sed -i "s/^BB_NUMBER_THREADS.*/BB_NUMBER_THREADS ?= \"${threads}\"/" $confdir/local.conf >> >> # Find if old DL_DIR was set >> if [ -e $confdir/local.conf.bak ] >> -- >> 2.17.1
diff --git a/oe-layertool-setup.sh b/oe-layertool-setup.sh index e404290..1ea31c3 100755 --- a/oe-layertool-setup.sh +++ b/oe-layertool-setup.sh @@ -770,9 +770,8 @@ EOM # set the number of threads threads=`cat /proc/cpuinfo | grep -c processor` - tnum=`expr \( ${threads} + 1 \) \* 75 / 100` - sed -i "s/^PARALLEL_MAKE.*/PARALLEL_MAKE ?= \"-j ${tnum}\"/" $confdir/local.conf - sed -i "s/^BB_NUMBER_THREADS.*/BB_NUMBER_THREADS ?= \"${tnum}\"/" $confdir/local.conf + sed -i "s/^PARALLEL_MAKE.*/PARALLEL_MAKE ?= \"-j ${threads}\"/" $confdir/local.conf + sed -i "s/^BB_NUMBER_THREADS.*/BB_NUMBER_THREADS ?= \"${threads}\"/" $confdir/local.conf # Find if old DL_DIR was set if [ -e $confdir/local.conf.bak ]
We are no longer using VMs for building and so should not need to reduce the number of threads down by 75%. Signed-off-by: Ryan Eatmon <reatmon@ti.com> --- oe-layertool-setup.sh | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)