[kirkstone/master] arago.conf: switch to internal toolchain for now

Message ID 20220513020008.3048052-1-denis@denix.org
State Accepted
Delegated to: Ryan Eatmon
Headers show
Series [kirkstone/master] arago.conf: switch to internal toolchain for now | expand

Commit Message

Denys Dmytriyenko May 13, 2022, 2 a.m. UTC
From: Denys Dmytriyenko <denys@konsulko.com>

Set default to build and use internal toolchain for now, instead of a pre-built
external one, as external gcc-11.2 toolchain still requires some work and syncup
with latest meta-arm codebase.

Signed-off-by: Denys Dmytriyenko <denys@konsulko.com>
---
 meta-arago-distro/conf/distro/arago.conf | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Nishanth Menon May 13, 2022, 2:38 a.m. UTC | #1
On 02:00-20220513, Denys Dmytriyenko wrote:
> From: Denys Dmytriyenko <denys@konsulko.com>
> 
> Set default to build and use internal toolchain for now, instead of a pre-built
> external one, as external gcc-11.2 toolchain still requires some work and syncup
> with latest meta-arm codebase.

I wonder if we should just settle for internal toolchain and dump the
entire external toolchain argumentation?


Is'nt that more inline with what the rest of the ecosystem is doing?

> Signed-off-by: Denys Dmytriyenko <denys@konsulko.com>
> ---
>  meta-arago-distro/conf/distro/arago.conf | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/meta-arago-distro/conf/distro/arago.conf b/meta-arago-distro/conf/distro/arago.conf
> index b2246537..e24cace9 100644
> --- a/meta-arago-distro/conf/distro/arago.conf
> +++ b/meta-arago-distro/conf/distro/arago.conf
> @@ -170,7 +170,7 @@ IMAGE_FSTYPES:remove = "${@['','ubi ubifs'][d.getVar('ARAGO_SYSTEST_ENABLE') ==
>  # Toolchain should be selected by setting TOOLCHAIN_BRAND in local.conf
>  # Set some sane defaults, in case someone forgets to set them in local.conf
>  TC_SANE_DEFAULT ?= "arm"
> -TOOLCHAIN_TYPE ?= "external"
> +TOOLCHAIN_TYPE ?= "internal"
>  TOOLCHAIN_TYPE:omapl1 = "internal"
>  TOOLCHAIN_BRAND ?= "${@[d.getVar('TC_SANE_DEFAULT'),'gcc'][d.getVar('TOOLCHAIN_TYPE') == 'internal']}"
Denys Dmytriyenko May 13, 2022, 9:47 p.m. UTC | #2
On Thu, May 12, 2022 at 09:38:23PM -0500, Nishanth Menon wrote:
> On 02:00-20220513, Denys Dmytriyenko wrote:
> > From: Denys Dmytriyenko <denys@konsulko.com>
> > 
> > Set default to build and use internal toolchain for now, instead of a pre-built
> > external one, as external gcc-11.2 toolchain still requires some work and syncup
> > with latest meta-arm codebase.
> 
> I wonder if we should just settle for internal toolchain and dump the
> entire external toolchain argumentation?

Sure, in due time. There were some concerns about using OE toolchain with the 
SDK, compared to the external toolchain - need to look closer at those.


> Is'nt that more inline with what the rest of the ecosystem is doing?
> 
> > Signed-off-by: Denys Dmytriyenko <denys@konsulko.com>
> > ---
> >  meta-arago-distro/conf/distro/arago.conf | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/meta-arago-distro/conf/distro/arago.conf b/meta-arago-distro/conf/distro/arago.conf
> > index b2246537..e24cace9 100644
> > --- a/meta-arago-distro/conf/distro/arago.conf
> > +++ b/meta-arago-distro/conf/distro/arago.conf
> > @@ -170,7 +170,7 @@ IMAGE_FSTYPES:remove = "${@['','ubi ubifs'][d.getVar('ARAGO_SYSTEST_ENABLE') ==
> >  # Toolchain should be selected by setting TOOLCHAIN_BRAND in local.conf
> >  # Set some sane defaults, in case someone forgets to set them in local.conf
> >  TC_SANE_DEFAULT ?= "arm"
> > -TOOLCHAIN_TYPE ?= "external"
> > +TOOLCHAIN_TYPE ?= "internal"
> >  TOOLCHAIN_TYPE:omapl1 = "internal"
> >  TOOLCHAIN_BRAND ?= "${@[d.getVar('TC_SANE_DEFAULT'),'gcc'][d.getVar('TOOLCHAIN_TYPE') == 'internal']}"

Patch

diff --git a/meta-arago-distro/conf/distro/arago.conf b/meta-arago-distro/conf/distro/arago.conf
index b2246537..e24cace9 100644
--- a/meta-arago-distro/conf/distro/arago.conf
+++ b/meta-arago-distro/conf/distro/arago.conf
@@ -170,7 +170,7 @@  IMAGE_FSTYPES:remove = "${@['','ubi ubifs'][d.getVar('ARAGO_SYSTEST_ENABLE') ==
 # Toolchain should be selected by setting TOOLCHAIN_BRAND in local.conf
 # Set some sane defaults, in case someone forgets to set them in local.conf
 TC_SANE_DEFAULT ?= "arm"
-TOOLCHAIN_TYPE ?= "external"
+TOOLCHAIN_TYPE ?= "internal"
 TOOLCHAIN_TYPE:omapl1 = "internal"
 TOOLCHAIN_BRAND ?= "${@[d.getVar('TC_SANE_DEFAULT'),'gcc'][d.getVar('TOOLCHAIN_TYPE') == 'internal']}"