| Message ID | 20220426200529.19956-1-afd@ti.com |
|---|---|
| State | Accepted |
| Delegated to: | Ryan Eatmon |
| Headers | show |
| Series | [meta-arago,oe-layersetup] Fix non-standard shell usage | expand |
On Tue, Apr 26, 2022 at 03:05:29PM -0500, Andrew F. Davis via lists.yoctoproject.org wrote: > Remove some Bashisms that prevent prevent this script from working > on stock Ubuntu (with Dash default interpreter). > > Signed-off-by: Andrew Davis <afd@ti.com> Reviewed-by: Denys Dmytriyenko <denys@konsulko.com> > --- > oe-layertool-setup.sh | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/oe-layertool-setup.sh b/oe-layertool-setup.sh > index f171f94..e05737b 100755 > --- a/oe-layertool-setup.sh > +++ b/oe-layertool-setup.sh > @@ -780,7 +780,7 @@ print_image_names() { > for FOLDER in ${FOLDERS} > do > RECO="" > - if [ "${FOLDER}" == "meta-arago" ]; then > + if [ "${FOLDER}" = "meta-arago" ]; then > RECO="[recommended]" > fi > echo "From ${FOLDER}${RECO}:" > @@ -796,7 +796,7 @@ print_image_names() { > if [ -z "${summary}" ]; then > summary="No Summary available" > fi > - echo -e "\t${name}: ${summary}" > + echo " ${name}: ${summary}" > done > fi > done > -- > 2.17.1
Patch applied to master. On 4/26/2022 16:04, Denys Dmytriyenko wrote: > On Tue, Apr 26, 2022 at 03:05:29PM -0500, Andrew F. Davis via lists.yoctoproject.org wrote: >> Remove some Bashisms that prevent prevent this script from working >> on stock Ubuntu (with Dash default interpreter). >> >> Signed-off-by: Andrew Davis <afd@ti.com> > > Reviewed-by: Denys Dmytriyenko <denys@konsulko.com> > > >> --- >> oe-layertool-setup.sh | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/oe-layertool-setup.sh b/oe-layertool-setup.sh >> index f171f94..e05737b 100755 >> --- a/oe-layertool-setup.sh >> +++ b/oe-layertool-setup.sh >> @@ -780,7 +780,7 @@ print_image_names() { >> for FOLDER in ${FOLDERS} >> do >> RECO="" >> - if [ "${FOLDER}" == "meta-arago" ]; then >> + if [ "${FOLDER}" = "meta-arago" ]; then >> RECO="[recommended]" >> fi >> echo "From ${FOLDER}${RECO}:" >> @@ -796,7 +796,7 @@ print_image_names() { >> if [ -z "${summary}" ]; then >> summary="No Summary available" >> fi >> - echo -e "\t${name}: ${summary}" >> + echo " ${name}: ${summary}" >> done >> fi >> done >> -- >> 2.17.1
diff --git a/oe-layertool-setup.sh b/oe-layertool-setup.sh index f171f94..e05737b 100755 --- a/oe-layertool-setup.sh +++ b/oe-layertool-setup.sh @@ -780,7 +780,7 @@ print_image_names() { for FOLDER in ${FOLDERS} do RECO="" - if [ "${FOLDER}" == "meta-arago" ]; then + if [ "${FOLDER}" = "meta-arago" ]; then RECO="[recommended]" fi echo "From ${FOLDER}${RECO}:" @@ -796,7 +796,7 @@ print_image_names() { if [ -z "${summary}" ]; then summary="No Summary available" fi - echo -e "\t${name}: ${summary}" + echo " ${name}: ${summary}" done fi done
Remove some Bashisms that prevent prevent this script from working on stock Ubuntu (with Dash default interpreter). Signed-off-by: Andrew Davis <afd@ti.com> --- oe-layertool-setup.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)