mbox series

[oe-layersetup,PATCHv2,00/16] Sacrifice your first born to the linter

Message ID 20230614034507.598391-1-res.sapp@gmail.com
Headers show
Series Sacrifice your first born to the linter | expand

Message

Res Sapp June 14, 2023, 3:44 a.m. UTC 
A few days ago someone in the beagle community reported some cryptic
errors from oe-layersetup so I took the time to address all of the
issues reported by Shellcheck and add some extra sanity checks.

I tried to split it into reasonable segments.

Resubmitting with a sane email I guess. Probably good I had to resubmit
it. Apparently somewhere along the way a patch was dropped in the first
series.

Randolph Sapp (16):
  oe-layertool-setup: split logic and/or expressions
  oe-layertool-setup: prefer use of $() notation
  oe-layertool-setup: replace all x comparisons with -n/-z
  oe-layertool-setup: fix all the printf calls
  oe-layertool-setup: fix all quoting, switch eval to export
  oe-layertool-setup: only invoke read with -r
  oe-layertool-setup: check exit code directly
  oe-layertool-setup: guard all cd calls
  oe-layertool-setup: eliminate useless cat
  oe-layertool-setup: use subshell execution with redirect
  oe-layertool-setup: guard against invalid expression in case
  oe-layertool-setup: replace all calls to echo with printf
  oe-layertool-setup: drop unused variable
  oe-layertool-setup: add a path sanity check for oebase
  oe-layertool-setup: fix multi-line printfs
  oe-layertool-setup: add sanity check for layer names

 oe-layertool-setup.sh | 435 +++++++++++++++++++++---------------------
 1 file changed, 220 insertions(+), 215 deletions(-)

Comments

Randolph Sapp May 7, 2025, 10:29 p.m. UTC | #1 
On 5/7/25 17:16, PRC Automation wrote:
> oe-layersetup / na / 20230614034507.598391-1-res.sapp
> 
> PRC Results: FAIL
> 
> -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-
>    apply-patch: FAIL
> -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-
> Summary:
> - Patch Series: [oe-layersetup][PATCHv2 00/16] Sacrifice your first born to the linter
> - Submitter: From: Randolph Sapp <res.sapp@gmail.com>
> - Date: Date: Tue, 13 Jun 2023 22:44:51 -0500
> - Num Patches: 16
> - Mailing List (public inbox) Commit SHA: 5a49bf112d3685aeb2f6e7b0a0c6f5b45e440e23
> 
> Applied to:
> - Repository:
> - Base Branch:
> - Commit Author:
> - Commit Subject:
> - Commit SHA:
> 
> Patches
> ----------------------------------------
> FAIL - [oe-layersetup][PATCHv2 01/16] oe-layertool-setup: split logic and/or expressions
>      fatal: not a git repository (or any parent up to mount point /scratch)
>      Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).
> 
> 
> 

How far back are you going with this test?
Ryan Eatmon May 7, 2025, 10:30 p.m. UTC | #2 
On 5/7/2025 5:29 PM, Randolph Sapp wrote:
> On 5/7/25 17:16, PRC Automation wrote:
>> oe-layersetup / na / 20230614034507.598391-1-res.sapp
>>
>> PRC Results: FAIL
>>
>> -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-
>>    apply-patch: FAIL
>> -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-
>> Summary:
>> - Patch Series: [oe-layersetup][PATCHv2 00/16] Sacrifice your first 
>> born to the linter
>> - Submitter: From: Randolph Sapp <res.sapp@gmail.com>
>> - Date: Date: Tue, 13 Jun 2023 22:44:51 -0500
>> - Num Patches: 16
>> - Mailing List (public inbox) Commit SHA: 
>> 5a49bf112d3685aeb2f6e7b0a0c6f5b45e440e23
>>
>> Applied to:
>> - Repository:
>> - Base Branch:
>> - Commit Author:
>> - Commit Subject:
>> - Commit SHA:
>>
>> Patches
>> ----------------------------------------
>> FAIL - [oe-layersetup][PATCHv2 01/16] oe-layertool-setup: split logic 
>> and/or expressions
>>      fatal: not a git repository (or any parent up to mount point 
>> /scratch)
>>      Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM 
>> not set).
>>
>>
>>
> 
> How far back are you going with this test?

Doh!  No one should have been getting these emails...
Ryan Eatmon May 7, 2025, 10:32 p.m. UTC | #3 
On 5/7/2025 5:30 PM, Ryan Eatmon via lists.yoctoproject.org wrote:
> 
> 
> On 5/7/2025 5:29 PM, Randolph Sapp wrote:
>> On 5/7/25 17:16, PRC Automation wrote:
>>> oe-layersetup / na / 20230614034507.598391-1-res.sapp
>>>
>>> PRC Results: FAIL
>>>
>>>
>>> Summary:
>>> - Patch Series: [oe-layersetup][PATCHv2 00/16] Sacrifice your first 
>>> born to the linter
>>> - Submitter: From: Randolph Sapp <res.sapp@gmail.com>
>>> - Date: Date: Tue, 13 Jun 2023 22:44:51 -0500
>>> - Num Patches: 16
>>> - Mailing List (public inbox) Commit SHA: 
>>> 5a49bf112d3685aeb2f6e7b0a0c6f5b45e440e23
>>>
>>> Applied to:
>>> - Repository:
>>> - Base Branch:
>>> - Commit Author:
>>> - Commit Subject:
>>> - Commit SHA:
>>>
>>> Patches
>>> ----------------------------------------
>>> FAIL - [oe-layersetup][PATCHv2 01/16] oe-layertool-setup: split logic 
>>> and/or expressions
>>>      fatal: not a git repository (or any parent up to mount point 
>>> /scratch)
>>>      Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM 
>>> not set).
>>>
>>>
>>>
>>
>> How far back are you going with this test?
> 
> Doh!  No one should have been getting these emails...
> 

I think I see the issue...  I've turned it off while I fix it.