diff mbox series

[v3,3/6] python3-pygobject: depend on gobject-introspection

Message ID 20230324152238.194877-3-kubiznak@2n.com
State New
Headers show
Series [v3,1/6] gobject-introspection: reduce dependencies | expand

Commit Message

Petr Kubizňák - 2N March 24, 2023, 3:22 p.m. UTC
When g-i feature is disabled, the gobject-introspection package
dependency is not pulled in but pygobject has a hard dependency on it.

Signed-off-by: Petr Kubizňák <kubiznak@2n.com>
---
 meta/recipes-devtools/python/python3-pygobject_3.42.2.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Tim Orling March 24, 2023, 3:46 p.m. UTC | #1
On Fri, Mar 24, 2023 at 8:24 AM Petr Kubizňák <kubiznak@2n.com> wrote:

> When g-i feature is disabled, the gobject-introspection package
> dependency is not pulled in but pygobject has a hard dependency on it.
>
> Signed-off-by: Petr Kubizňák <kubiznak@2n.com>
> ---
>  meta/recipes-devtools/python/python3-pygobject_3.42.2.bb | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/recipes-devtools/python/python3-pygobject_3.42.2.bb
> b/meta/recipes-devtools/python/python3-pygobject_3.42.2.bb
> index cc7b07e804..f54f4ce784 100644
> --- a/meta/recipes-devtools/python/python3-pygobject_3.42.2.bb
> +++ b/meta/recipes-devtools/python/python3-pygobject_3.42.2.bb
> @@ -10,7 +10,7 @@ GIR_MESON_OPTION = ""
>
>  inherit gnomebase setuptools3-base gobject-introspection
> upstream-version-is-even
>
> -DEPENDS += "python3 glib-2.0"
> +DEPENDS += "python3 glib-2.0 gobject-introspection"
>

This is not needed. It is already added by the inherited
gobject-introspection class
https://git.yoctoproject.org/poky/tree/meta/classes-recipe/gobject-introspection.bbclass#n38


>

 SRCNAME="pygobject"
>
> --
> 2.30.2
>
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#179064):
> https://lists.openembedded.org/g/openembedded-core/message/179064
> Mute This Topic: https://lists.openembedded.org/mt/97825895/924729
> Group Owner: openembedded-core+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [
> ticotimo@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
>
Tim Orling March 24, 2023, 3:48 p.m. UTC | #2
On Fri, Mar 24, 2023 at 8:47 AM Tim Orling via lists.openembedded.org
<ticotimo=gmail.com@lists.openembedded.org> wrote:

>
>
> On Fri, Mar 24, 2023 at 8:24 AM Petr Kubizňák <kubiznak@2n.com> wrote:
>
>> When g-i feature is disabled, the gobject-introspection package
>> dependency is not pulled in but pygobject has a hard dependency on it.
>>
>> Signed-off-by: Petr Kubizňák <kubiznak@2n.com>
>> ---
>>  meta/recipes-devtools/python/python3-pygobject_3.42.2.bb | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/meta/recipes-devtools/python/python3-pygobject_3.42.2.bb
>> b/meta/recipes-devtools/python/python3-pygobject_3.42.2.bb
>> index cc7b07e804..f54f4ce784 100644
>> --- a/meta/recipes-devtools/python/python3-pygobject_3.42.2.bb
>> +++ b/meta/recipes-devtools/python/python3-pygobject_3.42.2.bb
>> @@ -10,7 +10,7 @@ GIR_MESON_OPTION = ""
>>
>>  inherit gnomebase setuptools3-base gobject-introspection
>> upstream-version-is-even
>>
>> -DEPENDS += "python3 glib-2.0"
>> +DEPENDS += "python3 glib-2.0 gobject-introspection"
>>
>
> This is not needed. It is already added by the inherited
> gobject-introspection class
>
> https://git.yoctoproject.org/poky/tree/meta/classes-recipe/gobject-introspection.bbclass#n38
>
>

I had not yet read the previous patch to the class. Ignore this comment for
now, but this feels like a step backward.


>
>
>  SRCNAME="pygobject"
>>
>> --
>> 2.30.2
>>
>>
>>
>>
>>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#179072):
> https://lists.openembedded.org/g/openembedded-core/message/179072
> Mute This Topic: https://lists.openembedded.org/mt/97825895/924729
> Group Owner: openembedded-core+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [
> ticotimo@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
>
diff mbox series

Patch

diff --git a/meta/recipes-devtools/python/python3-pygobject_3.42.2.bb b/meta/recipes-devtools/python/python3-pygobject_3.42.2.bb
index cc7b07e804..f54f4ce784 100644
--- a/meta/recipes-devtools/python/python3-pygobject_3.42.2.bb
+++ b/meta/recipes-devtools/python/python3-pygobject_3.42.2.bb
@@ -10,7 +10,7 @@  GIR_MESON_OPTION = ""
 
 inherit gnomebase setuptools3-base gobject-introspection upstream-version-is-even
 
-DEPENDS += "python3 glib-2.0"
+DEPENDS += "python3 glib-2.0 gobject-introspection"
 
 SRCNAME="pygobject"