diff mbox series

[meta-oe,2/2] netplan: add missing runtime dependencies

Message ID 20230308135705.796596-2-yi.zhao@windriver.com
State Under Review
Headers show
Series [meta-python,1/2] python3-rich: add recipe | expand

Commit Message

Yi Zhao March 8, 2023, 1:57 p.m. UTC 
Add python3-dbus and python3-rich[1] to RDEPENDS.

[1] https://github.com/canonical/netplan/pull/290

Signed-off-by: Yi Zhao <yi.zhao@windriver.com>
---
 .../meta-python/recipes-connectivity/netplan/netplan_0.106.bb   | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Alexandre Belloni March 10, 2023, 4:46 p.m. UTC | #1 
Hello,

This broke check-layer-nightly on the autobuilders:

https://autobuilder.yoctoproject.org/typhoon/#/builders/121/builds/1227/steps/15/logs/stdio
https://autobuilder.yoctoproject.org/typhoon/#/builders/121/builds/1227/steps/21/logs/stdio
https://autobuilder.yoctoproject.org/typhoon/#/builders/121/builds/1227/steps/23/logs/stdio

I'm not completely sure why yet.

On 08/03/2023 21:57:05+0800, Yi Zhao wrote:
> Add python3-dbus and python3-rich[1] to RDEPENDS.
> 
> [1] https://github.com/canonical/netplan/pull/290
> 
> Signed-off-by: Yi Zhao <yi.zhao@windriver.com>
> ---
>  .../meta-python/recipes-connectivity/netplan/netplan_0.106.bb   | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/meta-oe/dynamic-layers/meta-python/recipes-connectivity/netplan/netplan_0.106.bb b/meta-oe/dynamic-layers/meta-python/recipes-connectivity/netplan/netplan_0.106.bb
> index b7fe7ae3e..8c1eaa550 100644
> --- a/meta-oe/dynamic-layers/meta-python/recipes-connectivity/netplan/netplan_0.106.bb
> +++ b/meta-oe/dynamic-layers/meta-python/recipes-connectivity/netplan/netplan_0.106.bb
> @@ -26,7 +26,7 @@ PACKAGECONFIG ?= ""
>  
>  PACKAGECONFIG[tests] = ",,,python3-nose python3-coverage python3-netifaces python3-pycodestyle python3-pyflakes python3-pyyaml"
>  
> -RDEPENDS:${PN} = "python3 python3-core python3-netifaces python3-pyyaml util-linux-libuuid libnetplan"
> +RDEPENDS:${PN} = "python3 python3-core python3-netifaces python3-pyyaml util-linux-libuuid libnetplan python3-dbus python3-rich"
>  
>  inherit pkgconfig systemd
>  
> -- 
> 2.25.1
> 

> 
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#101425): https://lists.openembedded.org/g/openembedded-devel/message/101425
> Mute This Topic: https://lists.openembedded.org/mt/97472579/3617179
> Group Owner: openembedded-devel+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [alexandre.belloni@bootlin.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
Khem Raj March 10, 2023, 6:24 p.m. UTC | #2 
On Fri, Mar 10, 2023 at 8:46 AM Alexandre Belloni via
lists.openembedded.org
<alexandre.belloni=bootlin.com@lists.openembedded.org> wrote:
>
> Hello,
>
> This broke check-layer-nightly on the autobuilders:
>
> https://autobuilder.yoctoproject.org/typhoon/#/builders/121/builds/1227/steps/15/logs/stdio
> https://autobuilder.yoctoproject.org/typhoon/#/builders/121/builds/1227/steps/21/logs/stdio
> https://autobuilder.yoctoproject.org/typhoon/#/builders/121/builds/1227/steps/23/logs/stdio
>
> I'm not completely sure why yet.

it started to depend on python-rich and the recipe for python-rich is
now in meta-python but perhaps this went in ahead of the new recipe.
Ideally they should have
gone in atomically.

>
> On 08/03/2023 21:57:05+0800, Yi Zhao wrote:
> > Add python3-dbus and python3-rich[1] to RDEPENDS.
> >
> > [1] https://github.com/canonical/netplan/pull/290
> >
> > Signed-off-by: Yi Zhao <yi.zhao@windriver.com>
> > ---
> >  .../meta-python/recipes-connectivity/netplan/netplan_0.106.bb   | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/meta-oe/dynamic-layers/meta-python/recipes-connectivity/netplan/netplan_0.106.bb b/meta-oe/dynamic-layers/meta-python/recipes-connectivity/netplan/netplan_0.106.bb
> > index b7fe7ae3e..8c1eaa550 100644
> > --- a/meta-oe/dynamic-layers/meta-python/recipes-connectivity/netplan/netplan_0.106.bb
> > +++ b/meta-oe/dynamic-layers/meta-python/recipes-connectivity/netplan/netplan_0.106.bb
> > @@ -26,7 +26,7 @@ PACKAGECONFIG ?= ""
> >
> >  PACKAGECONFIG[tests] = ",,,python3-nose python3-coverage python3-netifaces python3-pycodestyle python3-pyflakes python3-pyyaml"
> >
> > -RDEPENDS:${PN} = "python3 python3-core python3-netifaces python3-pyyaml util-linux-libuuid libnetplan"
> > +RDEPENDS:${PN} = "python3 python3-core python3-netifaces python3-pyyaml util-linux-libuuid libnetplan python3-dbus python3-rich"
> >
> >  inherit pkgconfig systemd
> >
> > --
> > 2.25.1
> >
>
> >
> >
> >
>
>
> --
> Alexandre Belloni, co-owner and COO, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#101494): https://lists.openembedded.org/g/openembedded-devel/message/101494
> Mute This Topic: https://lists.openembedded.org/mt/97472579/1997914
> Group Owner: openembedded-devel+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [raj.khem@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
Alexandre Belloni March 10, 2023, 7:46 p.m. UTC | #3 
On 10/03/2023 10:24:20-0800, Khem Raj wrote:
> On Fri, Mar 10, 2023 at 8:46 AM Alexandre Belloni via
> lists.openembedded.org
> <alexandre.belloni=bootlin.com@lists.openembedded.org> wrote:
> >
> > Hello,
> >
> > This broke check-layer-nightly on the autobuilders:
> >
> > https://autobuilder.yoctoproject.org/typhoon/#/builders/121/builds/1227/steps/15/logs/stdio
> > https://autobuilder.yoctoproject.org/typhoon/#/builders/121/builds/1227/steps/21/logs/stdio
> > https://autobuilder.yoctoproject.org/typhoon/#/builders/121/builds/1227/steps/23/logs/stdio
> >
> > I'm not completely sure why yet.
> 
> it started to depend on python-rich and the recipe for python-rich is
> now in meta-python but perhaps this went in ahead of the new recipe.

Ok, this would explain why I found python-rich when looking for it but
not check-layer at the time.

> Ideally they should have
> gone in atomically.
> 
> >
> > On 08/03/2023 21:57:05+0800, Yi Zhao wrote:
> > > Add python3-dbus and python3-rich[1] to RDEPENDS.
> > >
> > > [1] https://github.com/canonical/netplan/pull/290
> > >
> > > Signed-off-by: Yi Zhao <yi.zhao@windriver.com>
> > > ---
> > >  .../meta-python/recipes-connectivity/netplan/netplan_0.106.bb   | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/meta-oe/dynamic-layers/meta-python/recipes-connectivity/netplan/netplan_0.106.bb b/meta-oe/dynamic-layers/meta-python/recipes-connectivity/netplan/netplan_0.106.bb
> > > index b7fe7ae3e..8c1eaa550 100644
> > > --- a/meta-oe/dynamic-layers/meta-python/recipes-connectivity/netplan/netplan_0.106.bb
> > > +++ b/meta-oe/dynamic-layers/meta-python/recipes-connectivity/netplan/netplan_0.106.bb
> > > @@ -26,7 +26,7 @@ PACKAGECONFIG ?= ""
> > >
> > >  PACKAGECONFIG[tests] = ",,,python3-nose python3-coverage python3-netifaces python3-pycodestyle python3-pyflakes python3-pyyaml"
> > >
> > > -RDEPENDS:${PN} = "python3 python3-core python3-netifaces python3-pyyaml util-linux-libuuid libnetplan"
> > > +RDEPENDS:${PN} = "python3 python3-core python3-netifaces python3-pyyaml util-linux-libuuid libnetplan python3-dbus python3-rich"
> > >
> > >  inherit pkgconfig systemd
> > >
> > > --
> > > 2.25.1
> > >
> >
> > >
> > >
> > >
> >
> >
> > --
> > Alexandre Belloni, co-owner and COO, Bootlin
> > Embedded Linux and Kernel engineering
> > https://bootlin.com
> >
> > -=-=-=-=-=-=-=-=-=-=-=-
> > Links: You receive all messages sent to this group.
> > View/Reply Online (#101494): https://lists.openembedded.org/g/openembedded-devel/message/101494
> > Mute This Topic: https://lists.openembedded.org/mt/97472579/1997914
> > Group Owner: openembedded-devel+owner@lists.openembedded.org
> > Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [raj.khem@gmail.com]
> > -=-=-=-=-=-=-=-=-=-=-=-
> >
diff mbox series

Patch

diff --git a/meta-oe/dynamic-layers/meta-python/recipes-connectivity/netplan/netplan_0.106.bb b/meta-oe/dynamic-layers/meta-python/recipes-connectivity/netplan/netplan_0.106.bb
index b7fe7ae3e..8c1eaa550 100644
--- a/meta-oe/dynamic-layers/meta-python/recipes-connectivity/netplan/netplan_0.106.bb
+++ b/meta-oe/dynamic-layers/meta-python/recipes-connectivity/netplan/netplan_0.106.bb
@@ -26,7 +26,7 @@  PACKAGECONFIG ?= ""
 
 PACKAGECONFIG[tests] = ",,,python3-nose python3-coverage python3-netifaces python3-pycodestyle python3-pyflakes python3-pyyaml"
 
-RDEPENDS:${PN} = "python3 python3-core python3-netifaces python3-pyyaml util-linux-libuuid libnetplan"
+RDEPENDS:${PN} = "python3 python3-core python3-netifaces python3-pyyaml util-linux-libuuid libnetplan python3-dbus python3-rich"
 
 inherit pkgconfig systemd