Message ID | 20230224143717.2669400-3-kareem.zarka@huawei.com |
---|---|
State | New |
Headers | show |
Series | meta/recipes-core/images/core-image-minimal: add mtools to IMAGE_INSTALL | expand |
On Fri, Feb 24, 2023 at 9:37 AM Kareem Zarka <zarkakareem@gmail.com> wrote: > > The wic.py selftest cases test_skip_kernel_install and > test_kernel_install for OpenEmbedded were failing on autobuilders due > to a missing dependency on the mtools package, which provides a set of > tools for working with MS-DOS file systems, including mcopy. > To address this issue, we added mtools to the IMAGE_INSTALL variable in > the core-image-minimal.bb recipe. This ensures that the package is > included in the core-image-minimal image, which enables the > test_skip_kernel_install and test_kernel_install selftest cases > to run correctly on autobuilders. > I can't immediately say where the right place to add this dependency is, since I don't run the selftest images myself, but I can say that adding mtools to everyone's minimal image is not something I'd like to see. At a minimum, can't the CORE_IMAGE_EXTRA_INSTALL variable be leveraged for this ? It's there to be used for cases like this. Bruce > Signed-off-by: Kareem Zarka <kareem.zarka@huawei.com> > --- > meta/recipes-core/images/core-image-minimal.bb | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/meta/recipes-core/images/core-image-minimal.bb b/meta/recipes-core/images/core-image-minimal.bb > index 84343adcd8..5d626898f0 100644 > --- a/meta/recipes-core/images/core-image-minimal.bb > +++ b/meta/recipes-core/images/core-image-minimal.bb > @@ -1,6 +1,6 @@ > SUMMARY = "A small image just capable of allowing a device to boot." > > -IMAGE_INSTALL = "packagegroup-core-boot ${CORE_IMAGE_EXTRA_INSTALL}" > +IMAGE_INSTALL = "mtools packagegroup-core-boot ${CORE_IMAGE_EXTRA_INSTALL}" > > IMAGE_LINGUAS = " " > > -- > 2.25.1 > > > -=-=-=-=-=-=-=-=-=-=-=- > Links: You receive all messages sent to this group. > View/Reply Online (#177688): https://lists.openembedded.org/g/openembedded-core/message/177688 > Mute This Topic: https://lists.openembedded.org/mt/97206738/1050810 > Group Owner: openembedded-core+owner@lists.openembedded.org > Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [bruce.ashfield@gmail.com] > -=-=-=-=-=-=-=-=-=-=-=- >
"Kareem Zarka" <zarkakareem@gmail.com> writes: > The wic.py selftest cases test_skip_kernel_install and > test_kernel_install for OpenEmbedded were failing on autobuilders due > to a missing dependency on the mtools package, which provides a set of > tools for working with MS-DOS file systems, including mcopy. probably you want to add mtools-native dependency to the test itself instead of installing into the image. maybe even simple bitbake("mtools-native") will help? > To address this issue, we added mtools to the IMAGE_INSTALL variable in > the core-image-minimal.bb recipe. This ensures that the package is > included in the core-image-minimal image, which enables the > test_skip_kernel_install and test_kernel_install selftest cases > to run correctly on autobuilders. > > Signed-off-by: Kareem Zarka <kareem.zarka@huawei.com> > --- > meta/recipes-core/images/core-image-minimal.bb | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/meta/recipes-core/images/core-image-minimal.bb b/meta/recipes-core/images/core-image-minimal.bb > index 84343adcd8..5d626898f0 100644 > --- a/meta/recipes-core/images/core-image-minimal.bb > +++ b/meta/recipes-core/images/core-image-minimal.bb > @@ -1,6 +1,6 @@ > SUMMARY = "A small image just capable of allowing a device to boot." > > -IMAGE_INSTALL = "packagegroup-core-boot ${CORE_IMAGE_EXTRA_INSTALL}" > +IMAGE_INSTALL = "mtools packagegroup-core-boot ${CORE_IMAGE_EXTRA_INSTALL}" > > IMAGE_LINGUAS = " "
diff --git a/meta/recipes-core/images/core-image-minimal.bb b/meta/recipes-core/images/core-image-minimal.bb index 84343adcd8..5d626898f0 100644 --- a/meta/recipes-core/images/core-image-minimal.bb +++ b/meta/recipes-core/images/core-image-minimal.bb @@ -1,6 +1,6 @@ SUMMARY = "A small image just capable of allowing a device to boot." -IMAGE_INSTALL = "packagegroup-core-boot ${CORE_IMAGE_EXTRA_INSTALL}" +IMAGE_INSTALL = "mtools packagegroup-core-boot ${CORE_IMAGE_EXTRA_INSTALL}" IMAGE_LINGUAS = " "
The wic.py selftest cases test_skip_kernel_install and test_kernel_install for OpenEmbedded were failing on autobuilders due to a missing dependency on the mtools package, which provides a set of tools for working with MS-DOS file systems, including mcopy. To address this issue, we added mtools to the IMAGE_INSTALL variable in the core-image-minimal.bb recipe. This ensures that the package is included in the core-image-minimal image, which enables the test_skip_kernel_install and test_kernel_install selftest cases to run correctly on autobuilders. Signed-off-by: Kareem Zarka <kareem.zarka@huawei.com> --- meta/recipes-core/images/core-image-minimal.bb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)