| Message ID | 20230206191142.17353-1-george.kelly1097@gmail.com |
|---|---|
| State | New |
| Headers | show |
| Series | [[bitbake] ] If you are behind a corporate proxy, the npm fetcher uses the proxy IP address already passed in the list of exports. However, it will error if the proxy injects its own root CA certificate. Thus, the NODE_EXTRA_CA_CERTS environment variable | expand |
Hello George,
thank you for your patch.
On Mon, 6 Feb 2023 14:11:42 -0500
"George Kelly" <george.kelly1097@gmail.com> wrote:
> Signed-off-by: George Kelly <george.kelly1097@gmail.com>
I'm not qualified to review the content of your changes, but
definitely your patch needs to have a better formatting. Don't
put a long description in the first line of the got commit
message (which also ends up in the e-mail subject).
The "[[bitbake][PATCH]]" also looks weird.
I recommend you to read the guidelines at
https://www.openembedded.org/wiki/How_to_submit_a_patch_to_OpenEmbedded
in order to prepare a good commit message and to send your patch
in a way that makes it more easily reviewed, applied and tested.
Best regards,
diff --git a/lib/bb/fetch2/__init__.py b/lib/bb/fetch2/__init__.py index 5a7a6024..747356df 100644 --- a/lib/bb/fetch2/__init__.py +++ b/lib/bb/fetch2/__init__.py @@ -851,6 +851,7 @@ FETCH_EXPORT_VARS = ['HOME', 'PATH', 'DBUS_SESSION_BUS_ADDRESS', 'P4CONFIG', 'SSL_CERT_FILE', + 'NODE_EXTRA_CA_CERTS', 'AWS_PROFILE', 'AWS_ACCESS_KEY_ID', 'AWS_SECRET_ACCESS_KEY',
Signed-off-by: George Kelly <george.kelly1097@gmail.com> --- lib/bb/fetch2/__init__.py | 1 + 1 file changed, 1 insertion(+)