diff mbox series

[RFC,3/3] pulseaudio: Disable 64 bit time with 32 bit glibc

Message ID 20221108000828.42824-3-niko.mauno@vaisala.com
State New
Headers show
Series [RFC,1/3] Try to ensure 64 bit time on 32 bit glibcful hosts | expand

Commit Message

Niko Mauno Nov. 8, 2022, 12:08 a.m. UTC
For now add exemption in order to avoid following kind of failures
during do_compile()

  | ../pulseaudio-16.1/src/modules/bluetooth/bt-codec-cvsd.c:55:22: warning: format '%lu' expects argument of type 'long unsigned int', but argument 6 has type 'size_t' {aka 'unsigned int'} [-Wformat=]
  |    55 |         pa_log_debug("Got invalid block size: %lu, rounding down", block_size);
  |       |                      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~  ~~~~~~~~~~
  |       |                                                                    |
  |       |                                                                    size_t {aka unsigned int}

Signed-off-by: Niko Mauno <niko.mauno@vaisala.com>
---
 meta/recipes-multimedia/pulseaudio/pulseaudio_16.1.bb | 3 +++
 1 file changed, 3 insertions(+)

Comments

Peter Kjellerstedt Nov. 8, 2022, 10:17 a.m. UTC | #1
> -----Original Message-----
> From: openembedded-core@lists.openembedded.org <openembedded-core@lists.openembedded.org> On Behalf Of Niko Mauno via
> lists.openembedded.org
> Sent: den 8 november 2022 01:08
> To: openembedded-core@lists.openembedded.org
> Cc: Niko Mauno <niko.mauno@vaisala.com>
> Subject: [OE-core] [RFC PATCH 3/3] pulseaudio: Disable 64 bit time with 32 bit glibc
> 
> For now add exemption in order to avoid following kind of failures
> during do_compile()
> 
>   | ../pulseaudio-16.1/src/modules/bluetooth/bt-codec-cvsd.c:55:22: warning: format '%lu' expects argument of type 'long unsigned int', but argument 6 has type 'size_t' {aka 'unsigned int'} [-Wformat=]
>   |    55 |         pa_log_debug("Got invalid block size: %lu, rounding down", block_size);
>   |       |                      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~  ~~~~~~~~~~
>   |       |                                                                    |
>   |       |                                                                    size_t {aka unsigned int}
> 
> Signed-off-by: Niko Mauno <niko.mauno@vaisala.com>
> ---
>  meta/recipes-multimedia/pulseaudio/pulseaudio_16.1.bb | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/meta/recipes-multimedia/pulseaudio/pulseaudio_16.1.bb b/meta/recipes-multimedia/pulseaudio/pulseaudio_16.1.bb
> index 64002cd1cc..ee4f8c7ed3 100644
> --- a/meta/recipes-multimedia/pulseaudio/pulseaudio_16.1.bb
> +++ b/meta/recipes-multimedia/pulseaudio/pulseaudio_16.1.bb
> @@ -8,3 +8,6 @@ SRC_URI =
> "http://freedesktop.org/software/pulseaudio/releases/${BP}.tar.xz \
>             "
>  SRC_URI[sha256sum] = "8eef32ce91d47979f95fd9a935e738cd7eb7463430dabc72863251751e504ae4"
>  UPSTREAM_CHECK_REGEX = "pulseaudio-(?P<pver>\d+(\.(?!99)\d+)+)\.tar"
> +
> +# Compiling 64 bit time for 32 bit host is broken
> +GLIBC_64BIT_TIME_CPPFLAGS = ""

Rather than hiding the problem, you should patch the code to use %zu instead 
of %lu. And please send the patch upstream.

> --
> 2.36.1

//Peter
diff mbox series

Patch

diff --git a/meta/recipes-multimedia/pulseaudio/pulseaudio_16.1.bb b/meta/recipes-multimedia/pulseaudio/pulseaudio_16.1.bb
index 64002cd1cc..ee4f8c7ed3 100644
--- a/meta/recipes-multimedia/pulseaudio/pulseaudio_16.1.bb
+++ b/meta/recipes-multimedia/pulseaudio/pulseaudio_16.1.bb
@@ -8,3 +8,6 @@  SRC_URI = "http://freedesktop.org/software/pulseaudio/releases/${BP}.tar.xz \
            "
 SRC_URI[sha256sum] = "8eef32ce91d47979f95fd9a935e738cd7eb7463430dabc72863251751e504ae4"
 UPSTREAM_CHECK_REGEX = "pulseaudio-(?P<pver>\d+(\.(?!99)\d+)+)\.tar"
+
+# Compiling 64 bit time for 32 bit host is broken
+GLIBC_64BIT_TIME_CPPFLAGS = ""