| Message ID | 20211114202648.316923-1-quaresma.jose@gmail.com |
|---|---|
| State | Accepted, archived |
| Commit | b26596f113ae13214cd7bdd18a78500ff6a8ce75 |
| Headers | show |
| Series | [1/5] spirv-headers: upgrade 1.5.4 -> 1.5.5 | expand |
There is no 1.5.5 release or tag here:
https://github.com/KhronosGroup/SPIRV-Headers
so this breaks version checks and automated updates.
If you want to bump SRCREV to a post-release commit, PV should be set like
this:
PV = "1.5.4+git${SRCPV}"
I'll send a patch to correct this.
Alex
On Sun, 14 Nov 2021 at 21:27, Jose Quaresma <quaresma.jose@gmail.com> wrote:
> Signed-off-by: Jose Quaresma <quaresma.jose@gmail.com>
> ---
> .../spir/{spirv-headers_1.5.4.bb => spirv-headers_1.5.5.bb} | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> rename meta/recipes-graphics/spir/{spirv-headers_1.5.4.bb =>
> spirv-headers_1.5.5.bb} (92%)
>
> diff --git a/meta/recipes-graphics/spir/spirv-headers_1.5.4.bb
> b/meta/recipes-graphics/spir/spirv-headers_1.5.5.bb
> similarity index 92%
> rename from meta/recipes-graphics/spir/spirv-headers_1.5.4.bb
> rename to meta/recipes-graphics/spir/spirv-headers_1.5.5.bb
> index 6c978ce51a..101a2e2948 100644
> --- a/meta/recipes-graphics/spir/spirv-headers_1.5.4.bb
> +++ b/meta/recipes-graphics/spir/spirv-headers_1.5.5.bb
> @@ -7,7 +7,7 @@ HOMEPAGE = "https://www.khronos.org/registry/spir-v"
> LICENSE = "MIT"
> LIC_FILES_CHKSUM = "file://LICENSE;md5=c938b85bceb8fb26c1a807f28a52ae2d"
>
> -SRCREV = "6cae8216a6ea19ff3f237af01e54378c1ff81fcd"
> +SRCREV = "c8213b3c5a2cf3a0f5c4d1e7d7b8fc2ac9f4806d"
> SRC_URI = "git://
> github.com/KhronosGroup/SPIRV-Headers;protocol=https;branch=master"
> UPSTREAM_CHECK_GITTAGREGEX = "^(?P<pver>\d+(\.\d+)+)$"
> S = "${WORKDIR}/git"
> --
> 2.33.1
>
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#158267):
> https://lists.openembedded.org/g/openembedded-core/message/158267
> Mute This Topic: https://lists.openembedded.org/mt/87054847/1686489
> Group Owner: openembedded-core+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [
> alex.kanavin@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
>
Alexander Kanavin <alex.kanavin@gmail.com> escreveu no dia segunda, 15/11/2021 à(s) 13:57: > There is no 1.5.5 release or tag here: > https://github.com/KhronosGroup/SPIRV-Headers > so this breaks version checks and automated updates. > > If you want to bump SRCREV to a post-release commit, PV should be set like > this: > PV = "1.5.4+git${SRCPV}" > > I'll send a patch to correct this. > I see on this MR that the version is bumped on CMakeLists.txt and the user asks to create a new tag. https://github.com/KhronosGroup/SPIRV-Headers/pull/246 But there ano updates on the code like on the last tag 1.5.4. https://github.com/KhronosGroup/SPIRV-Headers/commit/7845730cab6ebbdeb621e7349b7dc1a59c3377be You are right, the 1.5.5 is not concluded. Thanks for looking and for the patch with the fixup. > > Alex > > On Sun, 14 Nov 2021 at 21:27, Jose Quaresma <quaresma.jose@gmail.com> > wrote: > >> Signed-off-by: Jose Quaresma <quaresma.jose@gmail.com> >> --- >> .../spir/{spirv-headers_1.5.4.bb => spirv-headers_1.5.5.bb} | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> rename meta/recipes-graphics/spir/{spirv-headers_1.5.4.bb => >> spirv-headers_1.5.5.bb} (92%) >> >> diff --git a/meta/recipes-graphics/spir/spirv-headers_1.5.4.bb >> b/meta/recipes-graphics/spir/spirv-headers_1.5.5.bb >> similarity index 92% >> rename from meta/recipes-graphics/spir/spirv-headers_1.5.4.bb >> rename to meta/recipes-graphics/spir/spirv-headers_1.5.5.bb >> index 6c978ce51a..101a2e2948 100644 >> --- a/meta/recipes-graphics/spir/spirv-headers_1.5.4.bb >> +++ b/meta/recipes-graphics/spir/spirv-headers_1.5.5.bb >> @@ -7,7 +7,7 @@ HOMEPAGE = "https://www.khronos.org/registry/spir-v" >> LICENSE = "MIT" >> LIC_FILES_CHKSUM = "file://LICENSE;md5=c938b85bceb8fb26c1a807f28a52ae2d" >> >> -SRCREV = "6cae8216a6ea19ff3f237af01e54378c1ff81fcd" >> +SRCREV = "c8213b3c5a2cf3a0f5c4d1e7d7b8fc2ac9f4806d" >> SRC_URI = "git:// >> github.com/KhronosGroup/SPIRV-Headers;protocol=https;branch=master" >> UPSTREAM_CHECK_GITTAGREGEX = "^(?P<pver>\d+(\.\d+)+)$" >> S = "${WORKDIR}/git" >> -- >> 2.33.1 >> >> >> -=-=-=-=-=-=-=-=-=-=-=- >> Links: You receive all messages sent to this group. >> View/Reply Online (#158267): >> https://lists.openembedded.org/g/openembedded-core/message/158267 >> Mute This Topic: https://lists.openembedded.org/mt/87054847/1686489 >> Group Owner: openembedded-core+owner@lists.openembedded.org >> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [ >> alex.kanavin@gmail.com] >> -=-=-=-=-=-=-=-=-=-=-=- >> >>
diff --git a/meta/recipes-graphics/spir/spirv-headers_1.5.4.bb b/meta/recipes-graphics/spir/spirv-headers_1.5.5.bb similarity index 92% rename from meta/recipes-graphics/spir/spirv-headers_1.5.4.bb rename to meta/recipes-graphics/spir/spirv-headers_1.5.5.bb index 6c978ce51a..101a2e2948 100644 --- a/meta/recipes-graphics/spir/spirv-headers_1.5.4.bb +++ b/meta/recipes-graphics/spir/spirv-headers_1.5.5.bb @@ -7,7 +7,7 @@ HOMEPAGE = "https://www.khronos.org/registry/spir-v" LICENSE = "MIT" LIC_FILES_CHKSUM = "file://LICENSE;md5=c938b85bceb8fb26c1a807f28a52ae2d" -SRCREV = "6cae8216a6ea19ff3f237af01e54378c1ff81fcd" +SRCREV = "c8213b3c5a2cf3a0f5c4d1e7d7b8fc2ac9f4806d" SRC_URI = "git://github.com/KhronosGroup/SPIRV-Headers;protocol=https;branch=master" UPSTREAM_CHECK_GITTAGREGEX = "^(?P<pver>\d+(\.\d+)+)$" S = "${WORKDIR}/git"
Signed-off-by: Jose Quaresma <quaresma.jose@gmail.com> --- .../spir/{spirv-headers_1.5.4.bb => spirv-headers_1.5.5.bb} | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) rename meta/recipes-graphics/spir/{spirv-headers_1.5.4.bb => spirv-headers_1.5.5.bb} (92%)