| Message ID | 20221021165738.1803166-1-raj.khem@gmail.com |
|---|---|
| State | New |
| Headers | show |
| Series | protobuf: Enable protoc binary in nativesdk | expand |
Hi Khem, On Fri, 21 Oct 2022 at 18:57, Khem Raj <raj.khem@gmail.com> wrote: > > When it was disabled for target, it was enabled for native but not for > nativesdk explicitly, lets do it here. > > Signed-off-by: Khem Raj <raj.khem@gmail.com> I sent something similar 3 weeks ago: https://www.mail-archive.com/openembedded-devel@lists.openembedded.org/msg84850.html Just to be sure, is my submission format okay? BR, Clement > --- > meta-oe/recipes-devtools/protobuf/protobuf_3.21.5.bb | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/meta-oe/recipes-devtools/protobuf/protobuf_3.21.5.bb b/meta-oe/recipes-devtools/protobuf/protobuf_3.21.5.bb > index 0bc9cbedc0..c8b9158e6c 100644 > --- a/meta-oe/recipes-devtools/protobuf/protobuf_3.21.5.bb > +++ b/meta-oe/recipes-devtools/protobuf/protobuf_3.21.5.bb > @@ -26,6 +26,7 @@ inherit cmake pkgconfig ptest > > PACKAGECONFIG ??= "" > PACKAGECONFIG:class-native ?= "compiler" > +PACKAGECONFIG:class-nativesdk ?= "compiler" > PACKAGECONFIG[python] = ",," > PACKAGECONFIG[compiler] = "-Dprotobuf_BUILD_PROTOC_BINARIES=ON,-Dprotobuf_BUILD_PROTOC_BINARIES=OFF" > > -- > 2.38.1 > > > -=-=-=-=-=-=-=-=-=-=-=- > Links: You receive all messages sent to this group. > View/Reply Online (#99255): https://lists.openembedded.org/g/openembedded-devel/message/99255 > Mute This Topic: https://lists.openembedded.org/mt/94480264/4240582 > Group Owner: openembedded-devel+owner@lists.openembedded.org > Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [peron.clem@gmail.com] > -=-=-=-=-=-=-=-=-=-=-=- >
On Mon, Oct 24, 2022 at 4:41 AM Clément Péron <peron.clem@gmail.com> wrote: > > Hi Khem, > > On Fri, 21 Oct 2022 at 18:57, Khem Raj <raj.khem@gmail.com> wrote: > > > > When it was disabled for target, it was enabled for native but not for > > nativesdk explicitly, lets do it here. > > > > Signed-off-by: Khem Raj <raj.khem@gmail.com> > > I sent something similar 3 weeks ago: > https://www.mail-archive.com/openembedded-devel@lists.openembedded.org/msg84850.html > > Just to be sure, is my submission format okay? Thanks for bringing this to my attention. I can not find this patch in my inbox, which might be that I accidentally deleted it but I can not find it on patchwork either, which might be the reason that I never saw it. I have seen patchwork and lore not grok certain patches from the mailing list, and it does not seem to be obvious why. Unfortunately, the patch I sent is already applied to master, otherwise I would have credited it to you :) > > BR, > Clement > > > --- > > meta-oe/recipes-devtools/protobuf/protobuf_3.21.5.bb | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/meta-oe/recipes-devtools/protobuf/protobuf_3.21.5.bb b/meta-oe/recipes-devtools/protobuf/protobuf_3.21.5.bb > > index 0bc9cbedc0..c8b9158e6c 100644 > > --- a/meta-oe/recipes-devtools/protobuf/protobuf_3.21.5.bb > > +++ b/meta-oe/recipes-devtools/protobuf/protobuf_3.21.5.bb > > @@ -26,6 +26,7 @@ inherit cmake pkgconfig ptest > > > > PACKAGECONFIG ??= "" > > PACKAGECONFIG:class-native ?= "compiler" > > +PACKAGECONFIG:class-nativesdk ?= "compiler" > > PACKAGECONFIG[python] = ",," > > PACKAGECONFIG[compiler] = "-Dprotobuf_BUILD_PROTOC_BINARIES=ON,-Dprotobuf_BUILD_PROTOC_BINARIES=OFF" > > > > -- > > 2.38.1 > > > > > > -=-=-=-=-=-=-=-=-=-=-=- > > Links: You receive all messages sent to this group. > > View/Reply Online (#99255): https://lists.openembedded.org/g/openembedded-devel/message/99255 > > Mute This Topic: https://lists.openembedded.org/mt/94480264/4240582 > > Group Owner: openembedded-devel+owner@lists.openembedded.org > > Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [peron.clem@gmail.com] > > -=-=-=-=-=-=-=-=-=-=-=- > >
Hi Khem, On Mon, 24 Oct 2022 at 18:49, Khem Raj <raj.khem@gmail.com> wrote: > > On Mon, Oct 24, 2022 at 4:41 AM Clément Péron <peron.clem@gmail.com> wrote: > > > > Hi Khem, > > > > On Fri, 21 Oct 2022 at 18:57, Khem Raj <raj.khem@gmail.com> wrote: > > > > > > When it was disabled for target, it was enabled for native but not for > > > nativesdk explicitly, lets do it here. > > > > > > Signed-off-by: Khem Raj <raj.khem@gmail.com> > > > > I sent something similar 3 weeks ago: > > https://www.mail-archive.com/openembedded-devel@lists.openembedded.org/msg84850.html > > > > Just to be sure, is my submission format okay? > > Thanks for bringing this to my attention. I can not find this patch in > my inbox, which might be that I accidentally deleted it > but I can not find it on patchwork either, which might be the reason > that I never saw it. I have seen patchwork and lore not > grok certain patches from the mailing list, and it does not seem to be > obvious why. Unfortunately, the patch I sent is already > applied to master, otherwise I would have credited it to you :) No worries, I just wanted to confirm that my submission was correct. Thanks for checking this. BR, Clement > > > > > BR, > > Clement > > > > > --- > > > meta-oe/recipes-devtools/protobuf/protobuf_3.21.5.bb | 1 + > > > 1 file changed, 1 insertion(+) > > > > > > diff --git a/meta-oe/recipes-devtools/protobuf/protobuf_3.21.5.bb b/meta-oe/recipes-devtools/protobuf/protobuf_3.21.5.bb > > > index 0bc9cbedc0..c8b9158e6c 100644 > > > --- a/meta-oe/recipes-devtools/protobuf/protobuf_3.21.5.bb > > > +++ b/meta-oe/recipes-devtools/protobuf/protobuf_3.21.5.bb > > > @@ -26,6 +26,7 @@ inherit cmake pkgconfig ptest > > > > > > PACKAGECONFIG ??= "" > > > PACKAGECONFIG:class-native ?= "compiler" > > > +PACKAGECONFIG:class-nativesdk ?= "compiler" > > > PACKAGECONFIG[python] = ",," > > > PACKAGECONFIG[compiler] = "-Dprotobuf_BUILD_PROTOC_BINARIES=ON,-Dprotobuf_BUILD_PROTOC_BINARIES=OFF" > > > > > > -- > > > 2.38.1 > > > > > > > > > -=-=-=-=-=-=-=-=-=-=-=- > > > Links: You receive all messages sent to this group. > > > View/Reply Online (#99255): https://lists.openembedded.org/g/openembedded-devel/message/99255 > > > Mute This Topic: https://lists.openembedded.org/mt/94480264/4240582 > > > Group Owner: openembedded-devel+owner@lists.openembedded.org > > > Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [peron.clem@gmail.com] > > > -=-=-=-=-=-=-=-=-=-=-=- > > >
diff --git a/meta-oe/recipes-devtools/protobuf/protobuf_3.21.5.bb b/meta-oe/recipes-devtools/protobuf/protobuf_3.21.5.bb index 0bc9cbedc0..c8b9158e6c 100644 --- a/meta-oe/recipes-devtools/protobuf/protobuf_3.21.5.bb +++ b/meta-oe/recipes-devtools/protobuf/protobuf_3.21.5.bb @@ -26,6 +26,7 @@ inherit cmake pkgconfig ptest PACKAGECONFIG ??= "" PACKAGECONFIG:class-native ?= "compiler" +PACKAGECONFIG:class-nativesdk ?= "compiler" PACKAGECONFIG[python] = ",," PACKAGECONFIG[compiler] = "-Dprotobuf_BUILD_PROTOC_BINARIES=ON,-Dprotobuf_BUILD_PROTOC_BINARIES=OFF"
When it was disabled for target, it was enabled for native but not for nativesdk explicitly, lets do it here. Signed-off-by: Khem Raj <raj.khem@gmail.com> --- meta-oe/recipes-devtools/protobuf/protobuf_3.21.5.bb | 1 + 1 file changed, 1 insertion(+)