[doc,v3,2/2] kernel-dev/common.rst: remove SRC_URI:append from examples

It's better to use SRC_URI += to append patches etc. If anything
is added via :append, that can only be removed with :remove which
makes the changes rather permanent compared to light weight +=
amendmends.

Signed-off-by: Mikko Rapeli <mikko.rapeli@linaro.org>
---
 documentation/kernel-dev/common.rst | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

Hello Mikko

On 9/20/22 08:45, Mikko Rapeli wrote:
> It's better to use SRC_URI += to append patches etc. If anything
> is added via :append, that can only be removed with :remove which
> makes the changes rather permanent compared to light weight +=
> amendmends.
>
> Signed-off-by: Mikko Rapeli <mikko.rapeli@linaro.org>
> ---
>   documentation/kernel-dev/common.rst | 12 ++++++------
>   1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/documentation/kernel-dev/common.rst b/documentation/kernel-dev/common.rst
> index 16ef6453bd..fb8d7cd029 100644
> --- a/documentation/kernel-dev/common.rst
> +++ b/documentation/kernel-dev/common.rst
> @@ -360,9 +360,9 @@ home directory:
>   
>         FILESEXTRAPATHS:prepend := "${THISDIR}/${PN}:"
>   
> -      SRC_URI:append = " file://patch-file-one.patch"
> -      SRC_URI:append = " file://patch-file-two.patch"
> -      SRC_URI:append = " file://patch-file-three.patch"
> +      SRC_URI += "file://patch-file-one.patch"
> +      SRC_URI += "file://patch-file-two.patch"
> +      SRC_URI += "file://patch-file-three.patch"
>   
>      The :term:`FILESEXTRAPATHS` and :term:`SRC_URI` statements
>      enable the OpenEmbedded build system to find patch files. For more
> @@ -1002,7 +1002,7 @@ Section.
>      contents::
>   
>         FILESEXTRAPATHS:prepend := "${THISDIR}/${PN}:"
> -      SRC_URI:append = " file://0001-calibrate.c-Added-some-printk-statements.patch"
> +      SRC_URI += "file://0001-calibrate.c-Added-some-printk-statements.patch"
>   
>      The :term:`FILESEXTRAPATHS` and :term:`SRC_URI` statements
>      enable the OpenEmbedded build system to find the patch file.
> @@ -1875,7 +1875,7 @@ build.
>   2. *Add the Feature File to SRC_URI:* Add the ``.scc`` file to the
>      recipe's :term:`SRC_URI` statement::
>   
> -      SRC_URI:append = " file://test.scc"
> +      SRC_URI += "file://test.scc"
>   
>      The leading space before the path is important as the path is
>      appended to the existing path.
> @@ -1884,7 +1884,7 @@ build.
>      :term:`KERNEL_FEATURES` statement to specify the feature as a kernel
>      feature::
>   
> -      KERNEL_FEATURES:append = " test.scc"
> +      KERNEL_FEATURES += "test.scc"
>   
>      The OpenEmbedded build
>      system processes the kernel feature when it builds the kernel.


Reviewed-by: Michael Opdenacker <michael.opdenacker@bootlin.com>
... and merged into master-next too.

Will you send further commit message updates to the other patches in 
these series?

Thanks
Michael.

Hi,

On Tue, 20 Sept 2022 at 11:12, Michael Opdenacker
<michael.opdenacker@bootlin.com> wrote:
>
> Hello Mikko
>
> On 9/20/22 08:45, Mikko Rapeli wrote:
> > It's better to use SRC_URI += to append patches etc. If anything
> > is added via :append, that can only be removed with :remove which
> > makes the changes rather permanent compared to light weight +=
> > amendmends.
> >
> > Signed-off-by: Mikko Rapeli <mikko.rapeli@linaro.org>
> > ---
> >   documentation/kernel-dev/common.rst | 12 ++++++------
> >   1 file changed, 6 insertions(+), 6 deletions(-)
> >
> > diff --git a/documentation/kernel-dev/common.rst b/documentation/kernel-dev/common.rst
> > index 16ef6453bd..fb8d7cd029 100644
> > --- a/documentation/kernel-dev/common.rst
> > +++ b/documentation/kernel-dev/common.rst
> > @@ -360,9 +360,9 @@ home directory:
> >
> >         FILESEXTRAPATHS:prepend := "${THISDIR}/${PN}:"
> >
> > -      SRC_URI:append = " file://patch-file-one.patch"
> > -      SRC_URI:append = " file://patch-file-two.patch"
> > -      SRC_URI:append = " file://patch-file-three.patch"
> > +      SRC_URI += "file://patch-file-one.patch"
> > +      SRC_URI += "file://patch-file-two.patch"
> > +      SRC_URI += "file://patch-file-three.patch"
> >
> >      The :term:`FILESEXTRAPATHS` and :term:`SRC_URI` statements
> >      enable the OpenEmbedded build system to find patch files. For more
> > @@ -1002,7 +1002,7 @@ Section.
> >      contents::
> >
> >         FILESEXTRAPATHS:prepend := "${THISDIR}/${PN}:"
> > -      SRC_URI:append = " file://0001-calibrate.c-Added-some-printk-statements.patch"
> > +      SRC_URI += "file://0001-calibrate.c-Added-some-printk-statements.patch"
> >
> >      The :term:`FILESEXTRAPATHS` and :term:`SRC_URI` statements
> >      enable the OpenEmbedded build system to find the patch file.
> > @@ -1875,7 +1875,7 @@ build.
> >   2. *Add the Feature File to SRC_URI:* Add the ``.scc`` file to the
> >      recipe's :term:`SRC_URI` statement::
> >
> > -      SRC_URI:append = " file://test.scc"
> > +      SRC_URI += "file://test.scc"
> >
> >      The leading space before the path is important as the path is
> >      appended to the existing path.
> > @@ -1884,7 +1884,7 @@ build.
> >      :term:`KERNEL_FEATURES` statement to specify the feature as a kernel
> >      feature::
> >
> > -      KERNEL_FEATURES:append = " test.scc"
> > +      KERNEL_FEATURES += "test.scc"
> >
> >      The OpenEmbedded build
> >      system processes the kernel feature when it builds the kernel.
>
>
> Reviewed-by: Michael Opdenacker <michael.opdenacker@bootlin.com>
> ... and merged into master-next too.
>
> Will you send further commit message updates to the other patches in
> these series?

The other changes in the original series are already merged in master
so it's a bit
late for commit message updates.

Cheers,
-Mikko

Hi Mikko

On 9/20/22 09:16, Mikko Rapeli wrote:
>
> The other changes in the original series are already merged in master
> so it's a bit
> late for commit message updates.


Oops, my bad. I didn't realize they were not documentation changes :}
Thanks again
Michael.