diff mbox series

edk2-firmware: Fix configure sed typo

Message ID 20220915131530.1677573-1-andrei@gherzan.com
State New
Headers show
Series edk2-firmware: Fix configure sed typo | expand

Commit Message

Andrei Gherzan Sept. 15, 2022, 1:15 p.m. UTC 
From: Andrei Gherzan <andrei.gherzan@huawei.com>

The configure sed operation will not behave as expected because '*'
match misses a preceeding '.'.

Signed-off-by: Andrei Gherzan <andrei.gherzan@huawei.com>
---
 meta-arm/recipes-bsp/uefi/edk2-firmware.inc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Ross Burton Sept. 15, 2022, 3:06 p.m. UTC | #1 
On 15 Sep 2022, at 14:15, Andrei Gherzan via lists.yoctoproject.org <andrei=gherzan.com@lists.yoctoproject.org> wrote:
> -    sed -i -e "s#-target ${HOST_ARCH}-linux-gnu*#-target ${HOST_SYS}#" ${S}/BaseTools/Conf/tools_def.template
> +    sed -i -e "s#-target ${HOST_ARCH}-linux-gnu.*#-target ${HOST_SYS}#" ${S}/BaseTools/Conf/tools_def.template

Did this break something for you, or is this a line that can actually be removed?

Ross
Andrei Gherzan Sept. 15, 2022, 6:22 p.m. UTC | #2 
Hi,

On Thu, 15 Sep 2022, at 16:06, Ross Burton wrote:
> On 15 Sep 2022, at 14:15, Andrei Gherzan via lists.yoctoproject.org 
> <andrei=gherzan.com@lists.yoctoproject.org> wrote:
>> -    sed -i -e "s#-target ${HOST_ARCH}-linux-gnu*#-target ${HOST_SYS}#" ${S}/BaseTools/Conf/tools_def.template
>> +    sed -i -e "s#-target ${HOST_ARCH}-linux-gnu.*#-target ${HOST_SYS}#" ${S}/BaseTools/Conf/tools_def.template
>
> Did this break something for you, or is this a line that can actually 
> be removed?

It is definitely still needed. The template includes hardcoded values. It was breaking for me for arm EFI support.

Andrei
Jon Mason Sept. 20, 2022, 10:36 p.m. UTC | #3 
On Thu, 15 Sep 2022 15:15:30 +0200, Andrei Gherzan wrote:
> The configure sed operation will not behave as expected because '*'
> match misses a preceeding '.'.

Applied, thanks!

[1/1] edk2-firmware: Fix configure sed typo
      commit: fde0575aeac3b86102d521a55f4a26e6afa623fd

Best regards,
Andrei Gherzan Sept. 21, 2022, 2:49 p.m. UTC | #4 
On Tue, 20 Sep 2022, at 23:36, Jon Mason wrote:
> On Thu, 15 Sep 2022 15:15:30 +0200, Andrei Gherzan wrote:
>> The configure sed operation will not behave as expected because '*'
>> match misses a preceeding '.'.
>
> Applied, thanks!

Awesome. Thanks.

Andrei
diff mbox series

Patch

diff --git a/meta-arm/recipes-bsp/uefi/edk2-firmware.inc b/meta-arm/recipes-bsp/uefi/edk2-firmware.inc
index e0dfa28..c9f1f1d 100644
--- a/meta-arm/recipes-bsp/uefi/edk2-firmware.inc
+++ b/meta-arm/recipes-bsp/uefi/edk2-firmware.inc
@@ -81,7 +81,7 @@  export CLANG38_ARM_PREFIX = "${TARGET_PREFIX}"
 TOOLCHAIN:arm = "gcc"
 
 do_configure:prepend() {
-    sed -i -e "s#-target ${HOST_ARCH}-linux-gnu*#-target ${HOST_SYS}#" ${S}/BaseTools/Conf/tools_def.template
+    sed -i -e "s#-target ${HOST_ARCH}-linux-gnu.*#-target ${HOST_SYS}#" ${S}/BaseTools/Conf/tools_def.template
 }
 
 do_compile() {