diff mbox series

[honister] mobile-broadband-provider-info: update branch name in SRC_URI

Message ID 20220909103754.3036413-1-ross.burton@arm.com
State New
Headers show
Series [honister] mobile-broadband-provider-info: update branch name in SRC_URI | expand

Commit Message

Ross Burton Sept. 9, 2022, 10:37 a.m. UTC
The master branch has been renamed to main and now master no longer
exists, so fetches that don't use a source mirror will fail.

Signed-off-by: Ross Burton <ross.burton@arm.com>
---
 .../mobile-broadband-provider-info_git.bb                       | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Richard Purdie Sept. 9, 2022, 11:20 a.m. UTC | #1
On Fri, 2022-09-09 at 11:37 +0100, Ross Burton wrote:
> The master branch has been renamed to main and now master no longer
> exists, so fetches that don't use a source mirror will fail.
> 
> Signed-off-by: Ross Burton <ross.burton@arm.com>
> ---
>  .../mobile-broadband-provider-info_git.bb                       | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/meta/recipes-connectivity/mobile-broadband-provider-info/mobile-broadband-provider-info_git.bb b/meta/recipes-connectivity/mobile-broadband-provider-info/mobile-broadband-provider-info_git.bb
> index 4246f4dcbd3..3b170f4fdd2 100644
> --- a/meta/recipes-connectivity/mobile-broadband-provider-info/mobile-broadband-provider-info_git.bb
> +++ b/meta/recipes-connectivity/mobile-broadband-provider-info/mobile-broadband-provider-info_git.bb
> @@ -8,7 +8,7 @@ SRCREV = "11f2247eccd3c161b8fd9b41143862e9fb81193c"
>  PV = "20210805"
>  PE = "1"
>  
> -SRC_URI = "git://gitlab.gnome.org/GNOME/mobile-broadband-provider-info.git;protocol=https;branch=master"
> +SRC_URI = "git://gitlab.gnome.org/GNOME/mobile-broadband-provider-info.git;protocol=https;branch=main"
>  S = "${WORKDIR}/git"
>  
>  inherit autotools

The trouble is if I merged this, it would open the floodgates on other
patches...

Cheers,

Richard
Peter Kjellerstedt Sept. 11, 2022, 8:37 a.m. UTC | #2
> -----Original Message-----
> From: openembedded-core@lists.openembedded.org <openembedded-core@lists.openembedded.org> On Behalf Of Richard Purdie
> Sent: den 9 september 2022 13:21
> To: Ross Burton <ross.burton@arm.com>; openembedded-core@lists.openembedded.org
> Cc: nd@arm.com
> Subject: Re: [OE-core] [PATCH][honister] mobile-broadband-provider-info: update branch name in SRC_URI
> 
> On Fri, 2022-09-09 at 11:37 +0100, Ross Burton wrote:
> > The master branch has been renamed to main and now master no longer
> > exists, so fetches that don't use a source mirror will fail.
> >
> > Signed-off-by: Ross Burton <ross.burton@arm.com>
> > ---
> >  .../mobile-broadband-provider-info_git.bb                       | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/meta/recipes-connectivity/mobile-broadband-provider-info/mobile-broadband-provider-info_git.bb b/meta/recipes-connectivity/mobile-broadband-provider-info/mobile-broadband-provider-info_git.bb
> > index 4246f4dcbd3..3b170f4fdd2 100644
> > --- a/meta/recipes-connectivity/mobile-broadband-provider-info/mobile-broadband-provider-info_git.bb
> > +++ b/meta/recipes-connectivity/mobile-broadband-provider-info/mobile-broadband-provider-info_git.bb
> > @@ -8,7 +8,7 @@ SRCREV = "11f2247eccd3c161b8fd9b41143862e9fb81193c"
> >  PV = "20210805"
> >  PE = "1"
> >
> > -SRC_URI = "git://gitlab.gnome.org/GNOME/mobile-broadband-provider-info.git;protocol=https;branch=master"
> > +SRC_URI = "git://gitlab.gnome.org/GNOME/mobile-broadband-provider-info.git;protocol=https;branch=main"
> >  S = "${WORKDIR}/git"
> >
> >  inherit autotools
> 
> The trouble is if I merged this, it would open the floodgates on other
> patches...
> 
> Cheers,
> 
> Richard

But isn't having a recipe trying to fetch something that doesn't exist 
considered a bug? And thus it should be ok to merge even in feature freeze.
Or am I missing something?

//Peter
Peter Kjellerstedt Sept. 11, 2022, 8:44 a.m. UTC | #3
> -----Original Message-----
> From: openembedded-core@lists.openembedded.org <openembedded-core@lists.openembedded.org> On Behalf Of Peter Kjellerstedt
> Sent: den 11 september 2022 10:37
> To: Richard Purdie <richard.purdie@linuxfoundation.org>; Ross Burton <ross.burton@arm.com>; openembedded-core@lists.openembedded.org
> Cc: nd@arm.com
> Subject: Re: [OE-core] [PATCH][honister] mobile-broadband-provider-info: update branch name in SRC_URI
> 
> > -----Original Message-----
> > From: openembedded-core@lists.openembedded.org <openembedded-core@lists.openembedded.org> On Behalf Of Richard Purdie
> > Sent: den 9 september 2022 13:21
> > To: Ross Burton <ross.burton@arm.com>; openembedded-core@lists.openembedded.org
> > Cc: nd@arm.com
> > Subject: Re: [OE-core] [PATCH][honister] mobile-broadband-provider-info: update branch name in SRC_URI
> >
> > On Fri, 2022-09-09 at 11:37 +0100, Ross Burton wrote:
> > > The master branch has been renamed to main and now master no longer
> > > exists, so fetches that don't use a source mirror will fail.
> > >
> > > Signed-off-by: Ross Burton <ross.burton@arm.com>
> > > ---
> > >  .../mobile-broadband-provider-info_git.bb                       | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/meta/recipes-connectivity/mobile-broadband-provider-info/mobile-broadband-provider-info_git.bb b/meta/recipes-connectivity/mobile-broadband-provider-info/mobile-broadband-provider-info_git.bb
> > > index 4246f4dcbd3..3b170f4fdd2 100644
> > > --- a/meta/recipes-connectivity/mobile-broadband-provider-info/mobile-broadband-provider-info_git.bb
> > > +++ b/meta/recipes-connectivity/mobile-broadband-provider-info/mobile-broadband-provider-info_git.bb
> > > @@ -8,7 +8,7 @@ SRCREV = "11f2247eccd3c161b8fd9b41143862e9fb81193c"
> > >  PV = "20210805"
> > >  PE = "1"
> > >
> > > -SRC_URI = "git://gitlab.gnome.org/GNOME/mobile-broadband-provider-info.git;protocol=https;branch=master"
> > > +SRC_URI = "git://gitlab.gnome.org/GNOME/mobile-broadband-provider-info.git;protocol=https;branch=main"
> > >  S = "${WORKDIR}/git"
> > >
> > >  inherit autotools
> >
> > The trouble is if I merged this, it would open the floodgates on other
> > patches...
> >
> > Cheers,
> >
> > Richard
> 
> But isn't having a recipe trying to fetch something that doesn't exist
> considered a bug? And thus it should be ok to merge even in feature freeze.
> Or am I missing something?
> 
> //Peter

And what I was missing was of course that this was related to Honister and 
not master. Duh.

//Peter
diff mbox series

Patch

diff --git a/meta/recipes-connectivity/mobile-broadband-provider-info/mobile-broadband-provider-info_git.bb b/meta/recipes-connectivity/mobile-broadband-provider-info/mobile-broadband-provider-info_git.bb
index 4246f4dcbd3..3b170f4fdd2 100644
--- a/meta/recipes-connectivity/mobile-broadband-provider-info/mobile-broadband-provider-info_git.bb
+++ b/meta/recipes-connectivity/mobile-broadband-provider-info/mobile-broadband-provider-info_git.bb
@@ -8,7 +8,7 @@  SRCREV = "11f2247eccd3c161b8fd9b41143862e9fb81193c"
 PV = "20210805"
 PE = "1"
 
-SRC_URI = "git://gitlab.gnome.org/GNOME/mobile-broadband-provider-info.git;protocol=https;branch=master"
+SRC_URI = "git://gitlab.gnome.org/GNOME/mobile-broadband-provider-info.git;protocol=https;branch=main"
 S = "${WORKDIR}/git"
 
 inherit autotools