diff mbox series

[meta-ti,dunfell,2/2] optee-os: Lower log level for AM62x

Message ID 20220826191641.31116-2-afd@ti.com
State Accepted
Delegated to: Ryan Eatmon
Headers show
Series [meta-ti,dunfell,1/2] optee-os: Upgrade to upstream 3.18.0 | expand

Commit Message

Andrew Davis Aug. 26, 2022, 7:16 p.m. UTC
During resume from low power mode suspend OP-TEE prints some messages
on the UART. It seems this UART is not powered at this point in the
sequence breaking suspend/resume. We should track down the exact
prints and quiet them. Until we get that fix upstream, lets lower
the log level for this platform to unblock the LPM work.

Signed-off-by: Andrew Davis <afd@ti.com>
---
 recipes-security/optee/optee-os_%.bbappend | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Gadiyar, Anand Aug. 26, 2022, 7:37 p.m. UTC | #1
> From: Davis, Andrew <afd@ti.com>
> 
> During resume from low power mode suspend OP-TEE prints some messages
> on the UART. It seems this UART is not powered at this point in the
> sequence breaking suspend/resume. We should track down the exact
> prints and quiet them. Until we get that fix upstream, lets lower
> the log level for this platform to unblock the LPM work.
> 
> Signed-off-by: Andrew Davis <afd@ti.com>

Acked-by: Anand Gadiyar <gadiyar@ti.com>


> ---
>  recipes-security/optee/optee-os_%.bbappend | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/recipes-security/optee/optee-os_%.bbappend b/recipes-
> security/optee/optee-os_%.bbappend
> index 4081b324..3cda8559 100644
> --- a/recipes-security/optee/optee-os_%.bbappend
> +++ b/recipes-security/optee/optee-os_%.bbappend
> @@ -6,7 +6,7 @@ DEPENDS_append_ti-soc = " python3-cryptography-native"
> 
>  EXTRA_OEMAKE_append_k3 = "${@ 'CFG_CONSOLE_UART='+
> d.getVar('OPTEE_K3_USART') if d.getVar('OPTEE_K3_USART') else ''}"
> 
> -EXTRA_OEMAKE_append_am62xx-evm = " CFG_WITH_SOFTWARE_PRNG=y"
> +EXTRA_OEMAKE_append_am62xx-evm = " CFG_WITH_SOFTWARE_PRNG=y CFG_TEE_CORE_LOG_LEVEL=1"
>  EXTRA_OEMAKE_append_j721s2-evm = " CFG_WITH_SOFTWARE_PRNG=y"
>  EXTRA_OEMAKE_append_j721s2-hs-evm = " CFG_WITH_SOFTWARE_PRNG=y"
> 
> --
> 2.36.1
Andrew Davis Sept. 1, 2022, 6:56 p.m. UTC | #2
On 8/26/22 2:16 PM, Andrew Davis wrote:
> During resume from low power mode suspend OP-TEE prints some messages
> on the UART. It seems this UART is not powered at this point in the
> sequence breaking suspend/resume. We should track down the exact
> prints and quiet them. Until we get that fix upstream, lets lower
> the log level for this platform to unblock the LPM work.
> 
> Signed-off-by: Andrew Davis <afd@ti.com>
> ---
>   recipes-security/optee/optee-os_%.bbappend | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/recipes-security/optee/optee-os_%.bbappend b/recipes-security/optee/optee-os_%.bbappend
> index 4081b324..3cda8559 100644
> --- a/recipes-security/optee/optee-os_%.bbappend
> +++ b/recipes-security/optee/optee-os_%.bbappend
> @@ -6,7 +6,7 @@ DEPENDS_append_ti-soc = " python3-cryptography-native"
>   
>   EXTRA_OEMAKE_append_k3 = "${@ 'CFG_CONSOLE_UART='+ d.getVar('OPTEE_K3_USART') if d.getVar('OPTEE_K3_USART') else ''}"
>   
> -EXTRA_OEMAKE_append_am62xx-evm = " CFG_WITH_SOFTWARE_PRNG=y"
> +EXTRA_OEMAKE_append_am62xx-evm = " CFG_WITH_SOFTWARE_PRNG=y CFG_TEE_CORE_LOG_LEVEL=1"


ping.

Looks like there is now a merge conflict for this, easy enough to
fix, add CFG_TEE_CORE_LOG_LEVEL=1 to the new am62xx-lp-evm also.

If you want me to re-send let me know.

Andrew


>   EXTRA_OEMAKE_append_j721s2-evm = " CFG_WITH_SOFTWARE_PRNG=y"
>   EXTRA_OEMAKE_append_j721s2-hs-evm = " CFG_WITH_SOFTWARE_PRNG=y"
>
Gadiyar, Anand Sept. 1, 2022, 7:39 p.m. UTC | #3
> From: Davis, Andrew <afd@ti.com>
> 
> On 8/26/22 2:16 PM, Andrew Davis wrote:
> > During resume from low power mode suspend OP-TEE prints some messages
> > on the UART. It seems this UART is not powered at this point in the
> > sequence breaking suspend/resume. We should track down the exact
> > prints and quiet them. Until we get that fix upstream, lets lower
> > the log level for this platform to unblock the LPM work.
> >
> > Signed-off-by: Andrew Davis <afd@ti.com>
> > ---
> >   recipes-security/optee/optee-os_%.bbappend | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/recipes-security/optee/optee-os_%.bbappend b/recipes-
> security/optee/optee-os_%.bbappend
> > index 4081b324..3cda8559 100644
> > --- a/recipes-security/optee/optee-os_%.bbappend
> > +++ b/recipes-security/optee/optee-os_%.bbappend
> > @@ -6,7 +6,7 @@ DEPENDS_append_ti-soc = " python3-cryptography-native"
> >
> >   EXTRA_OEMAKE_append_k3 = "${@ 'CFG_CONSOLE_UART='+ d.getVar('OPTEE_K3_USART') if d.getVar('OPTEE_K3_USART') else ''}"
> >
> > -EXTRA_OEMAKE_append_am62xx-evm = " CFG_WITH_SOFTWARE_PRNG=y"
> > +EXTRA_OEMAKE_append_am62xx-evm = " CFG_WITH_SOFTWARE_PRNG=y CFG_TEE_CORE_LOG_LEVEL=1"
> 
> 
> ping.
> 
> Looks like there is now a merge conflict for this, easy enough to
> fix, add CFG_TEE_CORE_LOG_LEVEL=1 to the new am62xx-lp-evm also.
> 
> If you want me to re-send let me know.
> 
> Andrew

Probably best to resend - I thought I had added it for am62xx-lp-evm
when I sent it out but it seems I did not. Sorry.
diff mbox series

Patch

diff --git a/recipes-security/optee/optee-os_%.bbappend b/recipes-security/optee/optee-os_%.bbappend
index 4081b324..3cda8559 100644
--- a/recipes-security/optee/optee-os_%.bbappend
+++ b/recipes-security/optee/optee-os_%.bbappend
@@ -6,7 +6,7 @@  DEPENDS_append_ti-soc = " python3-cryptography-native"
 
 EXTRA_OEMAKE_append_k3 = "${@ 'CFG_CONSOLE_UART='+ d.getVar('OPTEE_K3_USART') if d.getVar('OPTEE_K3_USART') else ''}"
 
-EXTRA_OEMAKE_append_am62xx-evm = " CFG_WITH_SOFTWARE_PRNG=y"
+EXTRA_OEMAKE_append_am62xx-evm = " CFG_WITH_SOFTWARE_PRNG=y CFG_TEE_CORE_LOG_LEVEL=1"
 EXTRA_OEMAKE_append_j721s2-evm = " CFG_WITH_SOFTWARE_PRNG=y"
 EXTRA_OEMAKE_append_j721s2-hs-evm = " CFG_WITH_SOFTWARE_PRNG=y"