[meta-oe] msgpack-cpp: fix msgpack-cpp is a header only library

Message ID 20211117080956.1887223-2-sean@geanix.com
State New
Headers show
Series [meta-oe] msgpack-cpp: fix msgpack-cpp is a header only library | expand

Commit Message

Sean Nyekjaer Nov. 17, 2021, 8:09 a.m. UTC
From: Sean Nyekjaer <sean.nyekjaer.ext@siemensgamesa.com>

${PN} is empty so don't let the -dev package RDEPEND on it

Signed-off-by: Sean Nyekjaer <sean.nyekjaer.ext@siemensgamesa.com>
---
 meta-oe/recipes-devtools/msgpack/msgpack-cpp_4.0.2.bb | 4 ++++
 1 file changed, 4 insertions(+)

Comments

Martin Jansa Nov. 17, 2021, 9:28 a.m. UTC | #1
so ALLOW_EMPTY:${PN} isn't needed, right?

On Wed, Nov 17, 2021 at 9:10 AM Sean Nyekjaer <sean@geanix.com> wrote:

> From: Sean Nyekjaer <sean.nyekjaer.ext@siemensgamesa.com>
>
> ${PN} is empty so don't let the -dev package RDEPEND on it
>
> Signed-off-by: Sean Nyekjaer <sean.nyekjaer.ext@siemensgamesa.com>
> ---
>  meta-oe/recipes-devtools/msgpack/msgpack-cpp_4.0.2.bb | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/meta-oe/recipes-devtools/msgpack/msgpack-cpp_4.0.2.bb
> b/meta-oe/recipes-devtools/msgpack/msgpack-cpp_4.0.2.bb
> index ef066753d..dc8f13c26 100644
> --- a/meta-oe/recipes-devtools/msgpack/msgpack-cpp_4.0.2.bb
> +++ b/meta-oe/recipes-devtools/msgpack/msgpack-cpp_4.0.2.bb
> @@ -19,4 +19,8 @@ S = "${WORKDIR}/git"
>
>  inherit cmake pkgconfig
>
> +ALLOW_EMPTY:${PN} = "1"
> +
> +RDEPENDS:${PN}-dev = ""
> +
>  BBCLASSEXTEND += "native nativesdk"
> --
> 2.33.0
>
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#93990):
> https://lists.openembedded.org/g/openembedded-devel/message/93990
> Mute This Topic: https://lists.openembedded.org/mt/87115217/3617156
> Group Owner: openembedded-devel+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [
> Martin.Jansa@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
>
Sean Nyekjaer Nov. 17, 2021, 9:48 a.m. UTC | #2
On Wed, Nov 17, 2021 at 10:28:57AM +0100, Martin Jansa wrote:
> so ALLOW_EMPTY:${PN} isn't needed, right?
> 

Yes :)
V2 is on the way

/Sean

> On Wed, Nov 17, 2021 at 9:10 AM Sean Nyekjaer <sean@geanix.com> wrote:
> 
> > From: Sean Nyekjaer <sean.nyekjaer.ext@siemensgamesa.com>
> >
> > ${PN} is empty so don't let the -dev package RDEPEND on it
> >
> > Signed-off-by: Sean Nyekjaer <sean.nyekjaer.ext@siemensgamesa.com>
> > ---
> >  meta-oe/recipes-devtools/msgpack/msgpack-cpp_4.0.2.bb | 4 ++++
> >  1 file changed, 4 insertions(+)
> >
> > diff --git a/meta-oe/recipes-devtools/msgpack/msgpack-cpp_4.0.2.bb
> > b/meta-oe/recipes-devtools/msgpack/msgpack-cpp_4.0.2.bb
> > index ef066753d..dc8f13c26 100644
> > --- a/meta-oe/recipes-devtools/msgpack/msgpack-cpp_4.0.2.bb
> > +++ b/meta-oe/recipes-devtools/msgpack/msgpack-cpp_4.0.2.bb
> > @@ -19,4 +19,8 @@ S = "${WORKDIR}/git"
> >
> >  inherit cmake pkgconfig
> >
> > +ALLOW_EMPTY:${PN} = "1"
> > +
> > +RDEPENDS:${PN}-dev = ""
> > +
> >  BBCLASSEXTEND += "native nativesdk"
> > --
> > 2.33.0
> >
> >
> > -=-=-=-=-=-=-=-=-=-=-=-
> > Links: You receive all messages sent to this group.
> > View/Reply Online (#93990):
> > https://lists.openembedded.org/g/openembedded-devel/message/93990
> > Mute This Topic: https://lists.openembedded.org/mt/87115217/3617156
> > Group Owner: openembedded-devel+owner@lists.openembedded.org
> > Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [
> > Martin.Jansa@gmail.com]
> > -=-=-=-=-=-=-=-=-=-=-=-
> >
> >

Patch

diff --git a/meta-oe/recipes-devtools/msgpack/msgpack-cpp_4.0.2.bb b/meta-oe/recipes-devtools/msgpack/msgpack-cpp_4.0.2.bb
index ef066753d..dc8f13c26 100644
--- a/meta-oe/recipes-devtools/msgpack/msgpack-cpp_4.0.2.bb
+++ b/meta-oe/recipes-devtools/msgpack/msgpack-cpp_4.0.2.bb
@@ -19,4 +19,8 @@  S = "${WORKDIR}/git"
 
 inherit cmake pkgconfig
 
+ALLOW_EMPTY:${PN} = "1"
+
+RDEPENDS:${PN}-dev = ""
+
 BBCLASSEXTEND += "native nativesdk"