@@ -66,39 +66,39 @@ for release in releases_from_json:
active_release_dates.append(datetime.datetime.strptime(release["original_release_date"], "%Y-%m-%dT%H:%M:%S%z"))
oldest_supported_release_date = sorted(active_release_dates)[0]
-with tempfile.TemporaryDirectory() as tmpdir:
- mmdpath = Path(tmpdir) / "diagram.mmd"
- with open(mmdpath, "w", encoding="utf-8") as mmd:
- mmd.write(MMD_HEADER)
+with tempfile.NamedTemporaryFile("w") as mmd:
+ mmd.write(MMD_HEADER)
- first_active_rel_found = False
- for release in releases_from_json:
- codename = release["release_codename"]
- series_version = release["series_version"]
- if release["status"] == "Active Development":
- mmd.write(f" {codename} {series_version} :done, after current_rel, 6M\n")
- continue
- if not release["original_release_date"]:
- continue
- original_release_date = datetime.datetime.strptime(release["original_release_date"], "%Y-%m-%dT%H:%M:%S%z")
- if original_release_date < oldest_supported_release_date:
- continue
- original_release_date = original_release_date.date().isoformat()
- end_date = datetime.datetime.strptime(release["latest_release_date"], "%Y-%m-%dT%H:%M:%S%z")
- end_date = end_date.date().isoformat()
- lts = False
- if "LTS until" in release["status"]:
- lts = True
- status = "done"
- if release["series"] == "current":
- status = "active"
- if not first_active_rel_found:
- status += ", current_rel"
- first_active_rel_found = True
- end_date = "6M"
- if lts:
- end_date = "4y"
- mmd.write(f" {codename} {series_version}{" (LTS)" if lts else ""}"
- f" :{status}, {original_release_date}, {end_date}\n")
+ first_active_rel_found = False
+ for release in releases_from_json:
+ codename = release["release_codename"]
+ series_version = release["series_version"]
+ if release["status"] == "Active Development":
+ mmd.write(f" {codename} {series_version} :done, after current_rel, 6M\n")
+ continue
+ if not release["original_release_date"]:
+ continue
+ original_release_date = datetime.datetime.strptime(release["original_release_date"], "%Y-%m-%dT%H:%M:%S%z")
+ if original_release_date < oldest_supported_release_date:
+ continue
+ original_release_date = original_release_date.date().isoformat()
+ end_date = datetime.datetime.strptime(release["latest_release_date"], "%Y-%m-%dT%H:%M:%S%z")
+ end_date = end_date.date().isoformat()
+ lts = False
+ if "LTS until" in release["status"]:
+ lts = True
+ status = "done"
+ if release["series"] == "current":
+ status = "active"
+ if not first_active_rel_found:
+ status += ", current_rel"
+ first_active_rel_found = True
+ end_date = "6M"
+ if lts:
+ end_date = "4y"
+ mmd.write(f" {codename} {series_version}{" (LTS)" if lts else ""}"
+ f" :{status}, {original_release_date}, {end_date}\n")
- subprocess.check_call(["mmdc", "--input", mmdpath, "--output", args.output])
+ mmd.flush()
+
+ subprocess.check_call(["mmdc", "--input", mmd.name, "--output", args.output])
We can directly use tempfile.NamedTemporaryFile() to open a temporary file and use it for the diagram passed too mmdc. Make sure it's flushed before mmdc reads it. This simplifies code complexity. Suggested-by: Quentin Schulz <quentin.schulz@cherry.de> Signed-off-by: Antonin Godard <antonin.godard@bootlin.com> --- documentation/tools/gen-releases-svg | 68 ++++++++++++++++++------------------ 1 file changed, 34 insertions(+), 34 deletions(-)