| Message ID | 20261108204558.3577002-1-khem.raj@oss.qualcomm.com |
|---|---|
| State | New |
| Headers | show |
| Series | [v2] packagegroups: Add clang to the SDK | expand |
Thank you for your submission. Patchtest identified one or more issues with the patch. Please see the log below for more information: --- Testing patch /home/patchtest/share/mboxes/v2-packagegroups-Add-clang-to-the-SDK.patch FAIL: test lic files chksum presence: LIC_FILES_CHKSUM is missing in newly added recipe (test_metadata.TestMetadata.test_lic_files_chksum_presence) PASS: pretest src uri left files (test_metadata.TestMetadata.pretest_src_uri_left_files) PASS: test CVE check ignore (test_metadata.TestMetadata.test_cve_check_ignore) PASS: test Signed-off-by presence (test_mbox.TestMbox.test_signed_off_by_presence) PASS: test auh changelog truncation notice (test_mbox.TestMbox.test_auh_changelog_truncation_notice) PASS: test author valid (test_mbox.TestMbox.test_author_valid) PASS: test commit message presence (test_mbox.TestMbox.test_commit_message_presence) PASS: test commit message user tags (test_mbox.TestMbox.test_commit_message_user_tags) PASS: test lic files chksum modified not mentioned (test_metadata.TestMetadata.test_lic_files_chksum_modified_not_mentioned) PASS: test license presence (test_metadata.TestMetadata.test_license_presence) PASS: test max line length (test_metadata.TestMetadata.test_max_line_length) PASS: test mbox format (test_mbox.TestMbox.test_mbox_format) PASS: test non-AUH upgrade (test_mbox.TestMbox.test_non_auh_upgrade) PASS: test shortlog format (test_mbox.TestMbox.test_shortlog_format) PASS: test shortlog length (test_mbox.TestMbox.test_shortlog_length) PASS: test src uri left files (test_metadata.TestMetadata.test_src_uri_left_files) PASS: test summary presence (test_metadata.TestMetadata.test_summary_presence) PASS: test target mailing list (test_mbox.TestMbox.test_target_mailing_list) SKIP: pretest pylint: No python related patches, skipping test (test_python_pylint.PyLint.pretest_pylint) SKIP: test CVE tag format: No new source patches introduced (test_patch.TestPatch.test_cve_tag_format) SKIP: test Signed-off-by presence: No new source patches introduced (test_patch.TestPatch.test_signed_off_by_presence) SKIP: test Upstream-Status presence: No new source patches introduced (test_patch.TestPatch.test_upstream_status_presence_format) SKIP: test bugzilla entry format: No bug ID found (test_mbox.TestMbox.test_bugzilla_entry_format) SKIP: test pylint: No python related patches, skipping test (test_python_pylint.PyLint.test_pylint) SKIP: test series merge on head: Merge test is disabled for now (test_mbox.TestMbox.test_series_merge_on_head) --- Please address the issues identified and submit a new revision of the patch, or alternatively, reply to this email with an explanation of why the patch should be accepted. If you believe these results are due to an error in patchtest, please submit a bug at https://bugzilla.yoctoproject.org/ (use the 'Patchtest' category under 'Yocto Project Subprojects'). For more information on specific failures, see: https://wiki.yoctoproject.org/wiki/Patchtest. Thank you!
diff --git a/meta/classes-recipe/populate_sdk_base.bbclass b/meta/classes-recipe/populate_sdk_base.bbclass index 0d67ab6ac6..35d2f20339 100644 --- a/meta/classes-recipe/populate_sdk_base.bbclass +++ b/meta/classes-recipe/populate_sdk_base.bbclass @@ -71,12 +71,14 @@ SDK_FEATURES:remove:powerpc = "go" TOOLCHAIN_HOST_TASK ?= " \ nativesdk-packagegroup-sdk-host \ packagegroup-cross-canadian-${MACHINE} \ + ${@bb.utils.contains('SDK_FEATURES', 'clang', 'packagegroup-clang-cross-canadian-${MACHINE}', '', d)} \ ${@bb.utils.contains('SDK_FEATURES', 'go', 'packagegroup-go-cross-canadian-${MACHINE}', '', d)} \ ${@bb.utils.contains('SDK_FEATURES', 'rust', 'packagegroup-rust-cross-canadian-${MACHINE}', '', d)} \ " TOOLCHAIN_HOST_TASK_ATTEMPTONLY ?= "" TOOLCHAIN_TARGET_TASK ?= " \ ${@oe.utils.multilib_pkg_extend(d, 'packagegroup-core-standalone-sdk-target')} \ + ${@bb.utils.contains('SDK_FEATURES', 'clang', oe.utils.multilib_pkg_extend(d, 'packagegroup-clang-sdk-target'), '', d)} \ ${@bb.utils.contains('SDK_FEATURES', 'go', oe.utils.multilib_pkg_extend(d, 'packagegroup-go-sdk-target'), '', d)} \ ${@bb.utils.contains('SDK_FEATURES', 'rust', oe.utils.multilib_pkg_extend(d, 'libstd-rs'), '', d)} \ ${@bb.utils.contains('SDK_FEATURES', 'kernel-src', 'kernel-devsrc', '', d)} \ diff --git a/meta/recipes-core/packagegroups/packagegroup-clang-cross-canadian.bb b/meta/recipes-core/packagegroups/packagegroup-clang-cross-canadian.bb new file mode 100644 index 0000000000..a1d7445b71 --- /dev/null +++ b/meta/recipes-core/packagegroups/packagegroup-clang-cross-canadian.bb @@ -0,0 +1,11 @@ +SUMMARY = "Host SDK package for clang cross canadian toolchain" + +include recipes-core/packagegroups/packagegroup-cross-canadian.bb + +PN = "packagegroup-clang-cross-canadian-${MACHINE}" + +CLANG = "clang-cross-canadian-${TRANSLATED_TARGET_ARCH}" + +RDEPENDS:${PN} += "\ + ${@oe.utils.all_multilib_tune_values(d, 'CLANG')} \ +" diff --git a/meta/recipes-core/packagegroups/packagegroup-clang-sdk-target.bb b/meta/recipes-core/packagegroups/packagegroup-clang-sdk-target.bb new file mode 100644 index 0000000000..fb6eff8707 --- /dev/null +++ b/meta/recipes-core/packagegroups/packagegroup-clang-sdk-target.bb @@ -0,0 +1,13 @@ +SUMMARY = "Target packages for the clang SDK" + +inherit packagegroup + +RDEPENDS:${PN} = " \ + clang \ + clang-format \ + clang-tidy \ + compiler-rt-dev \ + compiler-rt-staticdev \ + libcxx-dev \ + libcxx-staticdev \ +" diff --git a/meta/recipes-core/packagegroups/packagegroup-core-sdk.bb b/meta/recipes-core/packagegroups/packagegroup-core-sdk.bb index b3010d7674..56a2588e35 100644 --- a/meta/recipes-core/packagegroups/packagegroup-core-sdk.bb +++ b/meta/recipes-core/packagegroups/packagegroup-core-sdk.bb @@ -10,7 +10,7 @@ inherit packagegroup #PACKAGEFUNCS =+ 'generate_sdk_pkgs' -TARGET_TOOLCHAIN_LANGS ??= "${@bb.utils.filter('SDK_FEATURES', 'go rust', d)}" +TARGET_TOOLCHAIN_LANGS ??= "${@bb.utils.filter('SDK_FEATURES', 'clang go rust', d)}" TARGET_TOOLCHAIN_LANGS:remove:sdkmingw32 = "rust" # libstd-rs doesn't build for mips n32 with compiler constraint errors TARGET_TOOLCHAIN_LANGS:remove:mipsarchn32 = "rust" @@ -30,6 +30,7 @@ RDEPENDS:packagegroup-core-sdk = "\ ldd \ file \ tcl \ + ${@bb.utils.contains('TARGET_TOOLCHAIN_LANGS', 'clang', 'packagegroup-clang-sdk-target', '', d)} \ ${@bb.utils.contains('TARGET_TOOLCHAIN_LANGS', 'go', 'packagegroup-go-sdk-target', '', d)} \ ${@bb.utils.contains('TARGET_TOOLCHAIN_LANGS', 'rust', 'packagegroup-rust-sdk-target', '', d)} \ " diff --git a/meta/recipes-core/packagegroups/packagegroup-core-standalone-sdk-target.bb b/meta/recipes-core/packagegroups/packagegroup-core-standalone-sdk-target.bb index 06fdda90c7..dbe9cc0449 100644 --- a/meta/recipes-core/packagegroups/packagegroup-core-standalone-sdk-target.bb +++ b/meta/recipes-core/packagegroups/packagegroup-core-standalone-sdk-target.bb @@ -12,6 +12,11 @@ RDEPENDS:${PN} = "\ libstdc++ \ libstdc++-dev \ ${LIBC_DEPENDENCIES} \ + ${@bb.utils.contains_any('TC_CXX_RUNTIME', 'llvm android', 'libcxx-dev \ + libcxx-staticdev \ + compiler-rt-dev \ + compiler-rt-staticdev \ + ', '', d)} \ " RRECOMMENDS:${PN}:mingw32 = "\
Add clang to packagegroup-clang-cross-canadian gate it on SDK_FEATURES Add packagegroup-clang-cross-canadian-${MACHINE}, mirroring the go and rust ones, and add it to TOOLCHAIN_HOST_TASK only when SDK_FEATURES contains 'clang'. This keeps clang out of SDKs that don't ask for it. Add llvm runtime knob to the SDK Signed-off-by: Khem Raj <khem.raj@oss.qualcomm.com> Cc: Sunil Dora <sunilkumar.dora@windriver.com> --- v2: Add it via SDK_FEATURES meta/classes-recipe/populate_sdk_base.bbclass | 2 ++ .../packagegroup-clang-cross-canadian.bb | 11 +++++++++++ .../packagegroups/packagegroup-clang-sdk-target.bb | 13 +++++++++++++ .../packagegroups/packagegroup-core-sdk.bb | 3 ++- .../packagegroup-core-standalone-sdk-target.bb | 5 +++++ 5 files changed, 33 insertions(+), 1 deletion(-) create mode 100644 meta/recipes-core/packagegroups/packagegroup-clang-cross-canadian.bb create mode 100644 meta/recipes-core/packagegroups/packagegroup-clang-sdk-target.bb