| Message ID | 20261021065114.169649-1-shuai.zhang@oss.qualcomm.com |
|---|---|
| State | Changes Requested, archived |
| Delegated to: | Yoann Congal |
| Headers | show |
| Series | [wrynose,backport,v1] bluez5: Abort continuing response on fragmented CT replies | expand |
Thank you for your submission. Patchtest identified one or more issues with the patch. Please see the log below for more information: --- Testing patch /home/patchtest/share/mboxes/wrynose-backport-v1-bluez5-Abort-continuing-response-on-fragmented-CT-replies.patch FAIL: test Signed-off-by presence: A patch file has been added without a Signed-off-by tag: '0001-avrcp-Abort-continuing-response-on-fragmented-CT-rep.patch' (test_patch.TestPatch.test_signed_off_by_presence) FAIL: test Upstream-Status presence: Added patch file is missing Upstream-Status: <Valid status> in the commit message (test_patch.TestPatch.test_upstream_status_presence_format) PASS: test CVE tag format (test_patch.TestPatch.test_cve_tag_format) PASS: test Signed-off-by presence (test_mbox.TestMbox.test_signed_off_by_presence) PASS: test auh changelog truncation notice (test_mbox.TestMbox.test_auh_changelog_truncation_notice) PASS: test author valid (test_mbox.TestMbox.test_author_valid) PASS: test commit message presence (test_mbox.TestMbox.test_commit_message_presence) PASS: test commit message user tags (test_mbox.TestMbox.test_commit_message_user_tags) PASS: test max line length (test_metadata.TestMetadata.test_max_line_length) PASS: test mbox format (test_mbox.TestMbox.test_mbox_format) PASS: test non-AUH upgrade (test_mbox.TestMbox.test_non_auh_upgrade) PASS: test shortlog format (test_mbox.TestMbox.test_shortlog_format) PASS: test shortlog length (test_mbox.TestMbox.test_shortlog_length) PASS: test target mailing list (test_mbox.TestMbox.test_target_mailing_list) SKIP: pretest pylint: No python related patches, skipping test (test_python_pylint.PyLint.pretest_pylint) SKIP: pretest src uri left files: Patch cannot be merged (test_metadata.TestMetadata.pretest_src_uri_left_files) SKIP: test CVE check ignore: No modified recipes or older target branch, skipping test (test_metadata.TestMetadata.test_cve_check_ignore) SKIP: test bugzilla entry format: No bug ID found (test_mbox.TestMbox.test_bugzilla_entry_format) SKIP: test lic files chksum modified not mentioned: No modified recipes, skipping test (test_metadata.TestMetadata.test_lic_files_chksum_modified_not_mentioned) SKIP: test lic files chksum presence: No added recipes, skipping test (test_metadata.TestMetadata.test_lic_files_chksum_presence) SKIP: test license presence: No added recipes, skipping test (test_metadata.TestMetadata.test_license_presence) SKIP: test pylint: No python related patches, skipping test (test_python_pylint.PyLint.test_pylint) SKIP: test series merge on head: Merge test is disabled for now (test_mbox.TestMbox.test_series_merge_on_head) SKIP: test src uri left files: Patch cannot be merged (test_metadata.TestMetadata.test_src_uri_left_files) SKIP: test summary presence: No added recipes, skipping test (test_metadata.TestMetadata.test_summary_presence) --- Please address the issues identified and submit a new revision of the patch, or alternatively, reply to this email with an explanation of why the patch should be accepted. If you believe these results are due to an error in patchtest, please submit a bug at https://bugzilla.yoctoproject.org/ (use the 'Patchtest' category under 'Yocto Project Subprojects'). For more information on specific failures, see: https://wiki.yoctoproject.org/wiki/Patchtest. Thank you!
diff --git a/meta/recipes-connectivity/bluez5/bluez5.inc b/meta/recipes-connectivity/bluez5/bluez5.inc index d857c23..2d0ee56 100644 --- a/meta/recipes-connectivity/bluez5/bluez5.inc +++ b/meta/recipes-connectivity/bluez5/bluez5.inc @@ -76,6 +76,7 @@ SRC_URI = "${KERNELORG_MIRROR}/linux/bluetooth/bluez-${PV}.tar.xz \ file://0001-src-device-Fix-stored-gatt-cache-DB-Hash-value-no.patch \ file://0001-profile-Set-L2CAP-IMTU-for-OBEX-profile-listeners.patch \ file://0001-adapter-restrict-delta-0-RSSI-to-proximity-filters.patch \ + file://0001-avrcp-Abort-continuing-response-on-fragmented-CT-rep.patch \ " S = "${UNPACKDIR}/bluez-${PV}" diff --git a/meta/recipes-connectivity/bluez5/bluez5/0001-avrcp-Abort-continuing-response-on-fragmented-CT-rep.patch b/meta/recipes-connectivity/bluez5/bluez5/0001-avrcp-Abort-continuing-response-on-fragmented-CT-rep.patch new file mode 100644 index 0000000..b0cc3b0 --- /dev/null +++ b/meta/recipes-connectivity/bluez5/bluez5/0001-avrcp-Abort-continuing-response-on-fragmented-CT-rep.patch @@ -0,0 +1,59 @@ +From 53bbb4577bc61a24459100ee86da287fdfbf856c Mon Sep 17 00:00:00 2001 +From: Simon Mikuda <simon.mikuda@streamunlimited.com> +Date: Tue, 9 Jun 2026 23:26:56 +0200 +Subject: [PATCH] avrcp: Abort continuing response on fragmented CT replies + +Send AbortContinuingResponse when a Get Element Attributes reply +arrives fragmented, as the CT side does not reassemble fragments. + +Fixes PTS test AVRCP/CT/RCR/BV-03-C +--- + profiles/audio/avrcp.c | 25 +++++++++++++++++++++++++ + 1 file changed, 25 insertions(+) + +diff --git a/profiles/audio/avrcp.c b/profiles/audio/avrcp.c +index 326dfda..557ed97 100644 +--- a/profiles/audio/avrcp.c ++++ b/profiles/audio/avrcp.c +@@ -2466,6 +2466,24 @@ static void avrcp_parse_attribute_list(struct avrcp_player *player, + } + } + ++static void avrcp_abort_continuing(struct avrcp *session, uint8_t pdu_id) ++{ ++ uint8_t buf[AVRCP_HEADER_LENGTH + 1]; ++ struct avrcp_header *pdu = (void *) buf; ++ ++ memset(buf, 0, sizeof(buf)); ++ ++ set_company_id(pdu->company_id, IEEEID_BTSIG); ++ pdu->pdu_id = AVRCP_ABORT_CONTINUING; ++ pdu->packet_type = AVRCP_PACKET_TYPE_SINGLE; ++ pdu->params_len = cpu_to_be16(1); ++ pdu->params[0] = pdu_id; ++ ++ avctp_send_vendordep_req(session->conn, AVC_CTYPE_CONTROL, ++ AVC_SUBUNIT_PANEL, buf, sizeof(buf), ++ NULL, session); ++} ++ + static gboolean avrcp_get_element_attributes_rsp(struct avctp *conn, + uint8_t code, uint8_t subunit, + uint8_t transaction, +@@ -2483,6 +2501,13 @@ static gboolean avrcp_get_element_attributes_rsp(struct avctp *conn, + if (code == AVC_CTYPE_REJECTED) + return FALSE; + ++ /* Abort fragmented responses as reassembly is not supported */ ++ if (pdu->packet_type == AVRCP_PACKET_TYPE_START || ++ pdu->packet_type == AVRCP_PACKET_TYPE_CONTINUING) { ++ avrcp_abort_continuing(session, AVRCP_GET_ELEMENT_ATTRIBUTES); ++ return FALSE; ++ } ++ + count = pdu->params[0]; + + if (be16_to_cpu(pdu->params_len) - 1 < count * 8) { +-- +2.34.1 +
Backport upstream bluez commit 249e2bedf ("avrcp: Abort continuing response on fragmented CT replies") to bluez 5.86. Fixes PTS test AVRCP/CT/RCR/BV-03-C. Signed-off-by: Shuai Zhang <shuai.zhang@oss.qualcomm.com> --- meta/recipes-connectivity/bluez5/bluez5.inc | 1 + ...inuing-response-on-fragmented-CT-rep.patch | 59 +++++++++++++++++++ 2 files changed, 60 insertions(+) create mode 100644 meta/recipes-connectivity/bluez5/bluez5/0001-avrcp-Abort-continuing-response-on-fragmented-CT-rep.patch