| Message ID | 20261009163214.3203833-2-joel.winarske@linux.com |
|---|---|
| State | New |
| Headers | show |
| Series | [meta-oe] python3-gammu: set PYPI_PACKAGE_SDIST | expand |
I have a sweep for the rest: 60 recipes in meta-python and python3-gammu
in meta-oe. That is every remaining recipe where the effective
PYPI_PACKAGE carries a hyphen and the sdist does not.
Left out as already covered:
yours async-timeout, google-api-core, googleapis-common-protos,
google-api-python-client, requests-toolbelt
Scott dateutil, systemd
Ankur pytest-benchmark, types-setuptools
51 use PYPI_PACKAGE_SDIST = "${PYPI_PACKAGE}" as yours do. The other 10
cannot: normalizing lowercases the name while the sdist keeps its case,
flask-restful against Flask-RESTful, so those name the sdist directly.
No PYPI_PACKAGE is removed. Dropping a non-redundant one repoints
HOMEPAGE, UPSTREAM_CHECK_URI and the SPDX purl at the name BPN derives,
which is not always the project.
Verified against oe-core master with an empty DL_DIR: every one fails
do_fetch before and fetches after, checksums unchanged.
Do you want it as one patch, or split up? I can also hold it until the
per-recipe patches land and send whatever is left, if that is easier
with three of us touching the same files.
On Fri, Oct 9, 2026 at 9:32 AM Joel Winarske <joel.winarske@gmail.com>
wrote:
> From: Joel Winarske <joel.winarske@gmail.com>
>
> oe-core 98049bf86 redefined PYPI_PACKAGE as the normalized project name and
> derives the sdist name from it by replacing - with _. The sdist here
> predates
> PEP 625 and is still python-gammu-3.2.4.tar.gz, so do_fetch asks for
> python_gammu-3.2.4.tar.gz and gets a 404.
>
> PYPI_PACKAGE stays: the project is python-gammu, while BPN derives gammu,
> so
> dropping it would repoint HOMEPAGE, UPSTREAM_CHECK_URI and the SPDX purl at
> the wrong project.
>
> Checksum is unaffected, only the URL. Verified against oe-core master with
> an
> empty DL_DIR: do_fetch fails before and succeeds after.
>
> Signed-off-by: Joel Winarske <joel.winarske@gmail.com>
> ---
> meta-oe/recipes-connectivity/gammu/python3-gammu_3.2.4.bb | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/meta-oe/recipes-connectivity/gammu/python3-gammu_3.2.4.bb
> b/meta-oe/recipes-connectivity/gammu/python3-gammu_3.2.4.bb
> index f5e2cc4da1..e9138462a3 100644
> --- a/meta-oe/recipes-connectivity/gammu/python3-gammu_3.2.4.bb
> +++ b/meta-oe/recipes-connectivity/gammu/python3-gammu_3.2.4.bb
> @@ -6,6 +6,7 @@ LICENSE = "GPL-2.0-or-later"
> LIC_FILES_CHKSUM = "file://COPYING;md5=b234ee4d69f5fce4486a80fdaf4a4263"
>
> PYPI_PACKAGE = "python-gammu"
> +PYPI_PACKAGE_SDIST = "${PYPI_PACKAGE}"
>
> inherit pypi setuptools3 pkgconfig
>
> --
> 2.56.0
>
>
diff --git a/meta-oe/recipes-connectivity/gammu/python3-gammu_3.2.4.bb b/meta-oe/recipes-connectivity/gammu/python3-gammu_3.2.4.bb index f5e2cc4da1..e9138462a3 100644 --- a/meta-oe/recipes-connectivity/gammu/python3-gammu_3.2.4.bb +++ b/meta-oe/recipes-connectivity/gammu/python3-gammu_3.2.4.bb @@ -6,6 +6,7 @@ LICENSE = "GPL-2.0-or-later" LIC_FILES_CHKSUM = "file://COPYING;md5=b234ee4d69f5fce4486a80fdaf4a4263" PYPI_PACKAGE = "python-gammu" +PYPI_PACKAGE_SDIST = "${PYPI_PACKAGE}" inherit pypi setuptools3 pkgconfig