| Message ID | 20260821-sbom-cve-check-fragment-desc-v1-2-e06feb747b07@bootlin.com |
|---|---|
| State | New |
| Headers | show |
| Series | Disk space monitoring fragment and minor tooling tweaks | expand |
Hi Antonin, On 8/21/26 2:26 PM, Antonin Godard via lists.openembedded.org wrote: > Make the output of "Available built-in fragments" and "Enabled built-in > fragments" use the same output format: > > Available built-in fragments: > machine/... Sets MACHINE = "..." > > Enabled built-in fragments: > machine/qemuarm64 Sets MACHINE = "qemuarm64" > > Signed-off-by: Antonin Godard <antonin.godard@bootlin.com> > --- > meta/lib/bbconfigbuild/configfragments.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/meta/lib/bbconfigbuild/configfragments.py b/meta/lib/bbconfigbuild/configfragments.py > index 47605f3ddb..ccc1d8b610 100644 > --- a/meta/lib/bbconfigbuild/configfragments.py > +++ b/meta/lib/bbconfigbuild/configfragments.py > @@ -66,7 +66,7 @@ class ConfigFragmentsPlugin(LayerPlugin): > print('Available built-in fragments:') > builtin_dict = {i[0]:i[1] for i in [f.split(':') for f in builtin]} > for prefix,var in builtin_dict.items(): > - print('{}/...\tSets {} = ...'.format(prefix, var)) > + print('{}/...\tSets {} = "..."'.format(prefix, var)) Wondering if we shouldn't simply store the string before .format() in a variable and reuse it? print_frag = '{}\tSets {} = "{}"' [...] print(print_frag.format(prefix + '/...', var, '...')) [...] print(print_frag.format(f, builtin_dict[prefix], value)) In any case: Reviewed-by: Quentin Schulz <quentin.schulz@cherry.de> Thanks! Quentin
diff --git a/meta/lib/bbconfigbuild/configfragments.py b/meta/lib/bbconfigbuild/configfragments.py index 47605f3ddb..ccc1d8b610 100644 --- a/meta/lib/bbconfigbuild/configfragments.py +++ b/meta/lib/bbconfigbuild/configfragments.py @@ -66,7 +66,7 @@ class ConfigFragmentsPlugin(LayerPlugin): print('Available built-in fragments:') builtin_dict = {i[0]:i[1] for i in [f.split(':') for f in builtin]} for prefix,var in builtin_dict.items(): - print('{}/...\tSets {} = ...'.format(prefix, var)) + print('{}/...\tSets {} = "..."'.format(prefix, var)) print('') enabled_builtin_fragments = [f for f in enabled if self.builtin_fragment_exists(f)] print('Enabled built-in fragments:')
Make the output of "Available built-in fragments" and "Enabled built-in fragments" use the same output format: Available built-in fragments: machine/... Sets MACHINE = "..." Enabled built-in fragments: machine/qemuarm64 Sets MACHINE = "qemuarm64" Signed-off-by: Antonin Godard <antonin.godard@bootlin.com> --- meta/lib/bbconfigbuild/configfragments.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)