| Message ID | 20260729143729.3759497-1-wes@mitsi.com |
|---|---|
| State | New |
| Headers | show |
| Series | [wrynose] cpan_build: disable .packlist and html doc | expand |
On Wed Jul 29, 2026 at 4:37 PM CEST, Wes Malone via lists.openembedded.org wrote: > Currently, Makefile.PL-built Perl recipes (cpan.bbclass) exclude > .packlist files with NO_PACKLIST=1, but Build.PL recipes > (cpan_build.bbclass) do not. This now results in a QA error due to the > TMPDIR paths included in the .packlist file. > > ERROR: x do_package_qa: QA Issue: File [...]/.packlist in package x > contains reference to TMPDIR [buildpaths] > > A similar error is produced by generated html doc. > > Here we add the corresponding Build.PL arg to disable packlists and html > doc. > > Signed-off-by: Wes Malone <wes@mitsi.com> > --- > meta/classes-recipe/cpan_build.bbclass | 7 +++++++ > meta/recipes-devtools/perl/libmodule-build-perl_0.4234.bb | 2 -- > 2 files changed, 7 insertions(+), 2 deletions(-) Hello, This patch should also apply to master. We have a strong master-first policy so any patch need to get an equivalent merged on master before being merged on stable branches. Can you send an equivalent patch on master so I can review this for wrynose? Thanks!
On Wednesday, July 29, 2026 09:42, Yoann Congal wrote: > This patch should also apply to master. We have a strong master-first > policy so any patch need to get an equivalent merged on master before > being merged on stable branches. > > Can you send an equivalent patch on master so I can review this for > wrynose? > Hi, thank you for the advice. I've resubmitted the patch on master. Sorry for any formatting mistakes. My workplace blocks non-outlook mail clients so I'm having to jump through some hoops. Wes Malone
On Wed Jul 29, 2026 at 6:08 PM CEST, Wes Malone wrote: > On Wednesday, July 29, 2026 09:42, Yoann Congal wrote: >> This patch should also apply to master. We have a strong master-first >> policy so any patch need to get an equivalent merged on master before >> being merged on stable branches. >> >> Can you send an equivalent patch on master so I can review this for >> wrynose? >> > > Hi, thank you for the advice. I've resubmitted the patch on master. Sorry for > any formatting mistakes. My workplace blocks non-outlook mail clients so I'm > having to jump through some hoops. Your patch does apply clean on wrynose, so , no formatting issues to report, well done! Do you know about "b4"? https://b4.docs.kernel.org/en/latest/contributor/send.html It has a web submission endpoint for contributor with "difficult" mail systems and should work with Yocto Project & Openembedded mailing lists. Regards,
diff --git a/meta/classes-recipe/cpan_build.bbclass b/meta/classes-recipe/cpan_build.bbclass index 026859b6c7..03289dc21c 100644 --- a/meta/classes-recipe/cpan_build.bbclass +++ b/meta/classes-recipe/cpan_build.bbclass @@ -25,6 +25,13 @@ cpan_build_do_configure () { fi perl Build.PL --installdirs vendor --destdir ${D} \ + --create_packlist=0 \ + --config installhtml1dir= \ + --config installhtml3dir= \ + --config installsitehtml1dir= \ + --config installsitehtml3dir= \ + --config installvendorhtml1dir= \ + --config installvendorhtml3dir= \ ${EXTRA_CPAN_BUILD_FLAGS} # Build.PLs can exit with success without generating a diff --git a/meta/recipes-devtools/perl/libmodule-build-perl_0.4234.bb b/meta/recipes-devtools/perl/libmodule-build-perl_0.4234.bb index b27a8c15e6..0f992dea6d 100644 --- a/meta/recipes-devtools/perl/libmodule-build-perl_0.4234.bb +++ b/meta/recipes-devtools/perl/libmodule-build-perl_0.4234.bb @@ -32,8 +32,6 @@ do_patch_module_build () { do_patch[postfuncs] += "do_patch_module_build" -EXTRA_CPAN_BUILD_FLAGS = "--create_packlist=0" - do_install:prepend () { # We do not have a recipe for libpod-parser-perl which is for # documentation (and is deprecated in favor of Pod::Simple)
Currently, Makefile.PL-built Perl recipes (cpan.bbclass) exclude .packlist files with NO_PACKLIST=1, but Build.PL recipes (cpan_build.bbclass) do not. This now results in a QA error due to the TMPDIR paths included in the .packlist file. ERROR: x do_package_qa: QA Issue: File [...]/.packlist in package x contains reference to TMPDIR [buildpaths] A similar error is produced by generated html doc. Here we add the corresponding Build.PL arg to disable packlists and html doc. Signed-off-by: Wes Malone <wes@mitsi.com> --- meta/classes-recipe/cpan_build.bbclass | 7 +++++++ meta/recipes-devtools/perl/libmodule-build-perl_0.4234.bb | 2 -- 2 files changed, 7 insertions(+), 2 deletions(-)