| Message ID | 20260721030510.2071878-1-priyadarshini.babu@windriver.com |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | vulkan-samples: disable VKB_ray_tracing_position_fetch and add install | expand |
On Tue, 21 Jul 2026 at 05:05, Babu, Priyadarshini via lists.openembedded.org <Priyadarshini.Babu=windriver.com@lists.openembedded.org> wrote: > Disable ray_tracing_position_fetch sample by default as it depends on > pica_pica_robot which is licensed under CC-BY-NC-4.0. This can be > re-enabled via the pica_pica_robot PACKAGECONFIG option. > > Add do_install to properly install the vulkan_samples binary along with > its required assets and shaders directories. Please split this in two separate patches. They are completely different issues and should not be squashed together. Also, I don't understand why something needs to be disabled because it has a certain license. This needs to be explained. Are there particularly problematic terms in there? We should instead tweak the LICENSE field, or packaging. Alex
diff --git a/meta/recipes-graphics/vulkan/vulkan-samples_git.bb b/meta/recipes-graphics/vulkan/vulkan-samples_git.bb index 75d7a39eb6..0ac63f2068 100644 --- a/meta/recipes-graphics/vulkan/vulkan-samples_git.bb +++ b/meta/recipes-graphics/vulkan/vulkan-samples_git.bb @@ -29,8 +29,23 @@ EXTRA_OECMAKE += "-DCMAKE_DISABLE_PRECOMPILE_HEADERS=ON" # This needs to be specified explicitly to avoid xcb/xlib dependencies EXTRA_OECMAKE += "-DVKB_WSI_SELECTION=D2D" +# Disable ray_tracing_position_fetch sample compilation by default, +# as it uses pica_pica_robot which is under CC-BY-NC-4.0 license +PACKAGECONFIG ??= "" +PACKAGECONFIG[pica_pica_robot] = "-DVKB_ray_tracing_position_fetch=ON,-DVKB_ray_tracing_position_fetch=OFF" + # Clang is fussy about incompatible options on aarch64/x86_64 # x86_64-poky-linux-clang++: error: overriding '-ffp-model=precise' option with '-ffp-contract=fast' [-Werror,-Woverriding-option] CXXFLAGS:append:toolchain-clang = " -Wno-error=overriding-option" COMPATIBLE_HOST = "(aarch64|x86_64).*-linux" + +do_install:append() { + install -d ${D}${bindir} + install -m 0755 ${B}/app/bin/${TARGET_ARCH}/vulkan_samples ${D}${bindir}/ + cp --no-preserve=ownership -r ${S}/assets ${D}${bindir}/ + cp --no-preserve=ownership -r ${S}/shaders ${D}${bindir}/ + if ! ${@bb.utils.contains('PACKAGECONFIG', 'pica_pica_robot', 'true', 'false', d)}; then + rm -rf ${D}${bindir}/assets/scenes/pica_pica_robot + fi +}
Disable ray_tracing_position_fetch sample by default as it depends on pica_pica_robot which is licensed under CC-BY-NC-4.0. This can be re-enabled via the pica_pica_robot PACKAGECONFIG option. Add do_install to properly install the vulkan_samples binary along with its required assets and shaders directories. Signed-off-by: Priyadarshini Babu <priyadarshini.babu@windriver.com> --- .../recipes-graphics/vulkan/vulkan-samples_git.bb | 15 +++++++++++++++ 1 file changed, 15 insertions(+)