| Message ID | 20260720-runstrip-not-tuple-arg-v1-1-e07764fe3f41@cherry.de |
|---|---|
| State | Under Review |
| Headers | show |
| Series | kernel.bbclass: pass args instead of tuple of args to runstrip() | expand |
On Mon, 20 Jul 2026, Quentin Schulz wrote: > From: Quentin Schulz <quentin.schulz@cherry.de> > > Since commit 7c99f90079e7 ("lib/package/utils: Improve > multiprocess_launch argument passing"), runstrip() now expects arguments > individually instead as a big tuple so let's fix the one user in OE-Core > of that function which we forgot to migrate. > > Fixes: 7c99f90079e7 ("lib/package/utils: Improve multiprocess_launch argument passing") > Reported-by: Robert P. J. Day <rpjday@crashcourse.ca> > Closes: https://lore.kernel.org/openembedded-core/319bb00c-9712-4aa7-38b0-e1ad2bab840b@crashcourse.ca/ > Signed-off-by: Quentin Schulz <quentin.schulz@cherry.de> > --- > Not tested. Just read the code and found an issue. Robert, can you give > this a try maybe? > --- > meta/classes-recipe/kernel.bbclass | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/meta/classes-recipe/kernel.bbclass b/meta/classes-recipe/kernel.bbclass > index 48e394b650..91248467be 100644 > --- a/meta/classes-recipe/kernel.bbclass > +++ b/meta/classes-recipe/kernel.bbclass > @@ -750,7 +750,7 @@ python do_strip() { > if (extra_sections and kernel_image.find(d.getVar('KERNEL_IMAGEDEST') + '/vmlinux') != -1): > kernel_image_stripped = kernel_image + ".stripped" > shutil.copy2(kernel_image, kernel_image_stripped) > - oe.package.runstrip((kernel_image_stripped, 8, strip, extra_sections)) > + oe.package.runstrip(kernel_image_stripped, 8, strip, extra_sections) > bb.debug(1, "KERNEL_IMAGE_STRIP_EXTRA_SECTIONS is set, stripping sections: " + \ > extra_sections) > } > > --- > base-commit: aa33c4317dbe3e46e903d5350771413959462b37 > change-id: 20260720-runstrip-not-tuple-arg-97483264ad89 > > Best regards, > -- > Quentin Schulz <quentin.schulz@cherry.de> > Tested-by: Robert P. J. Day <rpjday@crashcourse.ca>
diff --git a/meta/classes-recipe/kernel.bbclass b/meta/classes-recipe/kernel.bbclass index 48e394b650..91248467be 100644 --- a/meta/classes-recipe/kernel.bbclass +++ b/meta/classes-recipe/kernel.bbclass @@ -750,7 +750,7 @@ python do_strip() { if (extra_sections and kernel_image.find(d.getVar('KERNEL_IMAGEDEST') + '/vmlinux') != -1): kernel_image_stripped = kernel_image + ".stripped" shutil.copy2(kernel_image, kernel_image_stripped) - oe.package.runstrip((kernel_image_stripped, 8, strip, extra_sections)) + oe.package.runstrip(kernel_image_stripped, 8, strip, extra_sections) bb.debug(1, "KERNEL_IMAGE_STRIP_EXTRA_SECTIONS is set, stripping sections: " + \ extra_sections) }