diff mbox series

[1/3] wget: remove pcre packageconfig option

Message ID 20260616194959.3748347-1-peter.marko@siemens.com
State Changes Requested
Headers show
Series [1/3] wget: remove pcre packageconfig option | expand

Commit Message

Peter Marko June 16, 2026, 7:49 p.m. UTC
From: Peter Marko <peter.marko@siemens.com>

libpcre is obsolete project replaced by libpcre2.
Also libpcre2 is the current default packageconfig option.

Signed-off-by: Peter Marko <peter.marko@siemens.com>
---
 meta/recipes-extended/wget/wget_1.25.0.bb | 1 -
 1 file changed, 1 deletion(-)

Comments

Richard Purdie June 17, 2026, 7:06 a.m. UTC | #1
On Tue, 2026-06-16 at 21:49 +0200, Peter Marko via lists.openembedded.org wrote:
> From: Peter Marko <peter.marko@siemens.com>
> 
> libpcre is obsolete project replaced by libpcre2.
> Also libpcre2 is the current default packageconfig option.
> 
> Signed-off-by: Peter Marko <peter.marko@siemens.com>
> ---
>  meta/recipes-extended/wget/wget_1.25.0.bb | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/meta/recipes-extended/wget/wget_1.25.0.bb b/meta/recipes-extended/wget/wget_1.25.0.bb
> index f0d3458462..28e27396a4 100644
> --- a/meta/recipes-extended/wget/wget_1.25.0.bb
> +++ b/meta/recipes-extended/wget/wget_1.25.0.bb
> @@ -34,7 +34,6 @@ PACKAGECONFIG[iri] = "--enable-iri,--disable-iri,libidn2"
>  PACKAGECONFIG[libpsl] = "--with-libpsl,--without-libpsl,libpsl"
>  PACKAGECONFIG[libuuid] = "--with-libuuid,--without-libuuid,util-linux"
>  PACKAGECONFIG[openssl] = "--with-ssl=openssl,,openssl"
> -PACKAGECONFIG[pcre] = "--enable-pcre,--disable-pcre,libpcre"
>  PACKAGECONFIG[pcre2] = "--enable-pcre2,--disable-pcre2,libpcre2"
>  PACKAGECONFIG[zlib] = "--with-zlib,--without-zlib,zlib"

Either this should be left, or it should be turned into a --disable-
pcre in EXTRA_OECONF. Removing it entirely risks determinism issues,
even if it is unlikely in this specific case due to pcre2.

Thanks for spotting the removal though!

Cheers,

Richard
diff mbox series

Patch

diff --git a/meta/recipes-extended/wget/wget_1.25.0.bb b/meta/recipes-extended/wget/wget_1.25.0.bb
index f0d3458462..28e27396a4 100644
--- a/meta/recipes-extended/wget/wget_1.25.0.bb
+++ b/meta/recipes-extended/wget/wget_1.25.0.bb
@@ -34,7 +34,6 @@  PACKAGECONFIG[iri] = "--enable-iri,--disable-iri,libidn2"
 PACKAGECONFIG[libpsl] = "--with-libpsl,--without-libpsl,libpsl"
 PACKAGECONFIG[libuuid] = "--with-libuuid,--without-libuuid,util-linux"
 PACKAGECONFIG[openssl] = "--with-ssl=openssl,,openssl"
-PACKAGECONFIG[pcre] = "--enable-pcre,--disable-pcre,libpcre"
 PACKAGECONFIG[pcre2] = "--enable-pcre2,--disable-pcre2,libpcre2"
 PACKAGECONFIG[zlib] = "--with-zlib,--without-zlib,zlib"