| Message ID | 20260421104147.1994119-2-richard.purdie@linuxfoundation.org |
|---|---|
| State | Accepted, archived |
| Commit | ef0856c18378d7ad444e56480bfab953dda52cb0 |
| Headers | show |
| Series | [1/3] pseudo: Update to 1.7.4 | expand |
Thank you for your submission. Patchtest identified one or more issues with the patch. Please see the log below for more information: --- Testing patch /home/patchtest/share/mboxes/2-3-shadow-Disable-tallylog-execution.patch FAIL: test Signed-off-by presence: A patch file has been added without a Signed-off-by tag: 'notallylog.patch' (test_patch.TestPatch.test_signed_off_by_presence) PASS: test CVE tag format (test_patch.TestPatch.test_cve_tag_format) PASS: test Signed-off-by presence (test_mbox.TestMbox.test_signed_off_by_presence) PASS: test Upstream-Status presence (test_patch.TestPatch.test_upstream_status_presence_format) PASS: test author valid (test_mbox.TestMbox.test_author_valid) PASS: test commit message presence (test_mbox.TestMbox.test_commit_message_presence) PASS: test commit message user tags (test_mbox.TestMbox.test_commit_message_user_tags) PASS: test mbox format (test_mbox.TestMbox.test_mbox_format) PASS: test non-AUH upgrade (test_mbox.TestMbox.test_non_auh_upgrade) PASS: test shortlog format (test_mbox.TestMbox.test_shortlog_format) PASS: test shortlog length (test_mbox.TestMbox.test_shortlog_length) PASS: test target mailing list (test_mbox.TestMbox.test_target_mailing_list) SKIP: pretest pylint: No python related patches, skipping test (test_python_pylint.PyLint.pretest_pylint) SKIP: test bugzilla entry format: No bug ID found (test_mbox.TestMbox.test_bugzilla_entry_format) SKIP: test pylint: No python related patches, skipping test (test_python_pylint.PyLint.test_pylint) SKIP: test series merge on head: Merge test is disabled for now (test_mbox.TestMbox.test_series_merge_on_head) --- Please address the issues identified and submit a new revision of the patch, or alternatively, reply to this email with an explanation of why the patch should be accepted. If you believe these results are due to an error in patchtest, please submit a bug at https://bugzilla.yoctoproject.org/ (use the 'Patchtest' category under 'Yocto Project Subprojects'). For more information on specific failures, see: https://wiki.yoctoproject.org/wiki/Patchtest. Thank you!
diff --git a/meta/recipes-extended/shadow/files/notallylog.patch b/meta/recipes-extended/shadow/files/notallylog.patch new file mode 100644 index 00000000000..94773ace2ba --- /dev/null +++ b/meta/recipes-extended/shadow/files/notallylog.patch @@ -0,0 +1,19 @@ +We don't want to call /sbin/pam_tally2 in the native tools case so +disable this function. + +Upstream-Status: Inappropriate [OE cross configuration specific] + +Index: shadow-4.19.4/src/useradd.c +=================================================================== +--- shadow-4.19.4.orig/src/useradd.c ++++ shadow-4.19.4/src/useradd.c +@@ -2046,6 +2046,9 @@ static void tallylog_reset (const char * + int failed; + int status; + ++ /* Don't call /sbin/pam_tally2 in native builds */ ++ return; ++ + if (access(pam_tally2, X_OK) == -1) + return; + diff --git a/meta/recipes-extended/shadow/shadow_4.19.4.bb b/meta/recipes-extended/shadow/shadow_4.19.4.bb index 9fe6a27e411..3ab9ae9c287 100644 --- a/meta/recipes-extended/shadow/shadow_4.19.4.bb +++ b/meta/recipes-extended/shadow/shadow_4.19.4.bb @@ -25,6 +25,7 @@ SRC_URI:append:class-target = " \ SRC_URI:append:class-native = " \ file://commonio.c-fix-unexpected-open-failure-in-chroot-env.patch \ file://disable_syslog.patch \ + file://notallylog.patch \ " SRC_URI[sha256sum] = "ba7e9aed1c5420203ac549583d6e6f485a819ac7505af9c7cd8c13b2013210b8" UPSTREAM_CHECK_REGEX = "releases/tag/v?(?P<pver>\d+(\.\d+)+)$"
We don't want to be calling tallylog from our native tools, disable it. Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org> --- .../shadow/files/notallylog.patch | 19 +++++++++++++++++++ meta/recipes-extended/shadow/shadow_4.19.4.bb | 1 + 2 files changed, 20 insertions(+) create mode 100644 meta/recipes-extended/shadow/files/notallylog.patch