diff mbox series

[meta-arago,master] flutter-samples-material-3-demo: Add --no-pub build option

Message ID 20260317210138.46226-1-a-christidis@ti.com
State Accepted
Delegated to: Ryan Eatmon
Headers show
Series [meta-arago,master] flutter-samples-material-3-demo: Add --no-pub build option | expand

Commit Message

Antonios Christidis March 17, 2026, 9:01 p.m. UTC 
From: Antonios Christidis <a-christidis@ti.com>

Append "--no-pub" option to flutter.

There is a patch pending upstream, [1]. The maintainer is inactive/on
vacation.

The upstream patch modifies a class, there is no clean way to modify
a class, so I'm editing FLUTTER_BUILD_ARGS which gets consumed by the
class. The end behavior is the same.

[1] https://github.com/meta-flutter/meta-flutter/pull/744

Signed-off-by: Antonios Christidis <a-christidis@ti.com>
---
 check_yocto_rules.json                                        | 1 +
 .../flutter/flutter-samples-material-3-demo-arago.inc         | 1 +
 .../flutter/flutter-samples-material-3-demo_%.bbappend        | 4 ++++
 3 files changed, 6 insertions(+)
 create mode 100644 meta-arago-test/dynamic-layers/flutter-layer/recipes-graphics/flutter/flutter-samples-material-3-demo-arago.inc
 create mode 100644 meta-arago-test/dynamic-layers/flutter-layer/recipes-graphics/flutter/flutter-samples-material-3-demo_%.bbappend

Comments

Denys Dmytriyenko March 17, 2026, 9:05 p.m. UTC | #1 
On Tue, Mar 17, 2026 at 04:01:38PM -0500, Antonios Christidis via lists.yoctoproject.org wrote:
> From: Antonios Christidis <a-christidis@ti.com>
> 
> Append "--no-pub" option to flutter.
> 
> There is a patch pending upstream, [1]. The maintainer is inactive/on
> vacation.
> 
> The upstream patch modifies a class, there is no clean way to modify
> a class, so I'm editing FLUTTER_BUILD_ARGS which gets consumed by the
> class. The end behavior is the same.
> 
> [1] https://github.com/meta-flutter/meta-flutter/pull/744
> 
> Signed-off-by: Antonios Christidis <a-christidis@ti.com>
> ---
>  check_yocto_rules.json                                        | 1 +
>  .../flutter/flutter-samples-material-3-demo-arago.inc         | 1 +
>  .../flutter/flutter-samples-material-3-demo_%.bbappend        | 4 ++++
>  3 files changed, 6 insertions(+)
>  create mode 100644 meta-arago-test/dynamic-layers/flutter-layer/recipes-graphics/flutter/flutter-samples-material-3-demo-arago.inc
>  create mode 100644 meta-arago-test/dynamic-layers/flutter-layer/recipes-graphics/flutter/flutter-samples-material-3-demo_%.bbappend
> 
> diff --git a/check_yocto_rules.json b/check_yocto_rules.json
> index 25c8c952..70bbe734 100644
> --- a/check_yocto_rules.json
> +++ b/check_yocto_rules.json
> @@ -23,6 +23,7 @@
>              "meta-arago-extras/recipes-extended/sysrepo/libyang_%.bbappend",
>              "meta-arago-test/dynamic-layers/qt6-layer/recipes-core/packagegroups/ti-test.bbappend",
>              "meta-arago-test/dynamic-layers/flutter-layer/recipes-graphics/flutter/flutter-wayland-client_%.bbappend",
> +            "meta-arago-test/dynamic-layers/flutter-layer/recipes-graphics/flutter/flutter-samples-material-3-demo_%.bbappend",
>              "meta-arago-test/recipes-benchmark/stream/stream_%.bbappend",
>              "meta-arago-test/recipes-extended/bc/bc_%.bbappend"
>          ]
> diff --git a/meta-arago-test/dynamic-layers/flutter-layer/recipes-graphics/flutter/flutter-samples-material-3-demo-arago.inc b/meta-arago-test/dynamic-layers/flutter-layer/recipes-graphics/flutter/flutter-samples-material-3-demo-arago.inc
> new file mode 100644
> index 00000000..b2c9e13d
> --- /dev/null
> +++ b/meta-arago-test/dynamic-layers/flutter-layer/recipes-graphics/flutter/flutter-samples-material-3-demo-arago.inc
> @@ -0,0 +1 @@
> +FLUTTER_BUILD_ARGS:append = " --no-pub"

Will it work with += here instead of :append?


> diff --git a/meta-arago-test/dynamic-layers/flutter-layer/recipes-graphics/flutter/flutter-samples-material-3-demo_%.bbappend b/meta-arago-test/dynamic-layers/flutter-layer/recipes-graphics/flutter/flutter-samples-material-3-demo_%.bbappend
> new file mode 100644
> index 00000000..f0ae3799
> --- /dev/null
> +++ b/meta-arago-test/dynamic-layers/flutter-layer/recipes-graphics/flutter/flutter-samples-material-3-demo_%.bbappend
> @@ -0,0 +1,4 @@
> +FLUTTER_ARAGO = ""
> +FLUTTER_ARAGO:arago = "flutter-samples-material-3-demo-arago.inc"
> +
> +require ${FLUTTER_ARAGO}
> -- 
> 2.34.1
PRC Automation March 17, 2026, 9:08 p.m. UTC | #2 
meta-arago / na / 20260317210138.46226-1-a-christidis

PRC Results: FAIL

=========================================================
  check-yocto-patches: PASS
=========================================================
Patches
----------------------------------------
All patches passed



=========================================================
  apply-yocto-patch: PASS
=========================================================
master
=====================
Summary:
- Patch Series: [meta-arago][master][PATCH] flutter-samples-material-3-demo: Add --no-pub build option
- Submitter: From: <a-christidis@ti.com>
From: Antonios Christidis <a-christidis@ti.com>
- Date: Date: Tue, 17 Mar 2026 16:01:38 -0500
- Num Patches: 1
- Mailing List (public inbox) Commit SHA: b8597ff36002f6b147b7574e1a6ce11a9f3ad524

Applied to:
- Repository: lcpd-prc-meta-arago
- Base Branch: master-wip
- Commit Author: Thorsten Lannynd <t-lannynd@ti.com>
- Commit Subject: ti-test: Add request and websocket-client to packagegroup
- Commit SHA: 64d6190f700d54addcd17687b7428a64c2bbb0fb

Patches
----------------------------------------
All patches applied



=========================================================
  check-yocto-repo: PASS
=========================================================
master
=====================
PASS



=========================================================
  yocto-check-layers: FAIL
=========================================================
master - FAIL
=====================
ERROR: Nothing PROVIDES 'gstreamer1.0-vaapi' (but <build-dir>/sources/meta-openembedded/meta-networking/recipes-support/spice/spice-gtk_0.42.bb DEPENDS on or otherwise requires it). Close matches:
ERROR: Required build target 'meta-world-pkgdata' has no buildable providers.
Antonios Christidis March 18, 2026, 3:59 p.m. UTC | #3 
On 3/17/26 4:05 PM, Denys Dmytriyenko wrote:
> On Tue, Mar 17, 2026 at 04:01:38PM -0500, Antonios Christidis via lists.yoctoproject.org wrote:
>> From: Antonios Christidis <a-christidis@ti.com>
>>
>> Append "--no-pub" option to flutter.
>>
>> There is a patch pending upstream, [1]. The maintainer is inactive/on
>> vacation.
>>
>> The upstream patch modifies a class, there is no clean way to modify
>> a class, so I'm editing FLUTTER_BUILD_ARGS which gets consumed by the
>> class. The end behavior is the same.
>>
>> [1] https://github.com/meta-flutter/meta-flutter/pull/744
>>
>> Signed-off-by: Antonios Christidis <a-christidis@ti.com>
>> ---
>>   check_yocto_rules.json                                        | 1 +
>>   .../flutter/flutter-samples-material-3-demo-arago.inc         | 1 +
>>   .../flutter/flutter-samples-material-3-demo_%.bbappend        | 4 ++++
>>   3 files changed, 6 insertions(+)
>>   create mode 100644 meta-arago-test/dynamic-layers/flutter-layer/recipes-graphics/flutter/flutter-samples-material-3-demo-arago.inc
>>   create mode 100644 meta-arago-test/dynamic-layers/flutter-layer/recipes-graphics/flutter/flutter-samples-material-3-demo_%.bbappend
>>
>> diff --git a/check_yocto_rules.json b/check_yocto_rules.json
>> index 25c8c952..70bbe734 100644
>> --- a/check_yocto_rules.json
>> +++ b/check_yocto_rules.json
>> @@ -23,6 +23,7 @@
>>               "meta-arago-extras/recipes-extended/sysrepo/libyang_%.bbappend",
>>               "meta-arago-test/dynamic-layers/qt6-layer/recipes-core/packagegroups/ti-test.bbappend",
>>               "meta-arago-test/dynamic-layers/flutter-layer/recipes-graphics/flutter/flutter-wayland-client_%.bbappend",
>> +            "meta-arago-test/dynamic-layers/flutter-layer/recipes-graphics/flutter/flutter-samples-material-3-demo_%.bbappend",
>>               "meta-arago-test/recipes-benchmark/stream/stream_%.bbappend",
>>               "meta-arago-test/recipes-extended/bc/bc_%.bbappend"
>>           ]
>> diff --git a/meta-arago-test/dynamic-layers/flutter-layer/recipes-graphics/flutter/flutter-samples-material-3-demo-arago.inc b/meta-arago-test/dynamic-layers/flutter-layer/recipes-graphics/flutter/flutter-samples-material-3-demo-arago.inc
>> new file mode 100644
>> index 00000000..b2c9e13d
>> --- /dev/null
>> +++ b/meta-arago-test/dynamic-layers/flutter-layer/recipes-graphics/flutter/flutter-samples-material-3-demo-arago.inc
>> @@ -0,0 +1 @@
>> +FLUTTER_BUILD_ARGS:append = " --no-pub"
> Will it work with += here instead of :append?
>
It would not work, the variable has a soft default that I want to abide 
by and append to. If I use "+=" it overrides the soft default value.

I finally got a proper use case for ":append" lol.

>> diff --git a/meta-arago-test/dynamic-layers/flutter-layer/recipes-graphics/flutter/flutter-samples-material-3-demo_%.bbappend b/meta-arago-test/dynamic-layers/flutter-layer/recipes-graphics/flutter/flutter-samples-material-3-demo_%.bbappend
>> new file mode 100644
>> index 00000000..f0ae3799
>> --- /dev/null
>> +++ b/meta-arago-test/dynamic-layers/flutter-layer/recipes-graphics/flutter/flutter-samples-material-3-demo_%.bbappend
>> @@ -0,0 +1,4 @@
>> +FLUTTER_ARAGO = ""
>> +FLUTTER_ARAGO:arago = "flutter-samples-material-3-demo-arago.inc"
>> +
>> +require ${FLUTTER_ARAGO}
>> -- 
>> 2.34.1
Denys Dmytriyenko March 18, 2026, 6:45 p.m. UTC | #4 
On Wed, Mar 18, 2026 at 10:59:51AM -0500, Antonios Christidis wrote:
> 
> On 3/17/26 4:05 PM, Denys Dmytriyenko wrote:
> >On Tue, Mar 17, 2026 at 04:01:38PM -0500, Antonios Christidis via lists.yoctoproject.org wrote:
> >>From: Antonios Christidis <a-christidis@ti.com>
> >>
> >>Append "--no-pub" option to flutter.
> >>
> >>There is a patch pending upstream, [1]. The maintainer is inactive/on
> >>vacation.
> >>
> >>The upstream patch modifies a class, there is no clean way to modify
> >>a class, so I'm editing FLUTTER_BUILD_ARGS which gets consumed by the
> >>class. The end behavior is the same.
> >>
> >>[1] https://github.com/meta-flutter/meta-flutter/pull/744
> >>
> >>Signed-off-by: Antonios Christidis <a-christidis@ti.com>
> >>---
> >>  check_yocto_rules.json                                        | 1 +
> >>  .../flutter/flutter-samples-material-3-demo-arago.inc         | 1 +
> >>  .../flutter/flutter-samples-material-3-demo_%.bbappend        | 4 ++++
> >>  3 files changed, 6 insertions(+)
> >>  create mode 100644 meta-arago-test/dynamic-layers/flutter-layer/recipes-graphics/flutter/flutter-samples-material-3-demo-arago.inc
> >>  create mode 100644 meta-arago-test/dynamic-layers/flutter-layer/recipes-graphics/flutter/flutter-samples-material-3-demo_%.bbappend
> >>
> >>diff --git a/check_yocto_rules.json b/check_yocto_rules.json
> >>index 25c8c952..70bbe734 100644
> >>--- a/check_yocto_rules.json
> >>+++ b/check_yocto_rules.json
> >>@@ -23,6 +23,7 @@
> >>              "meta-arago-extras/recipes-extended/sysrepo/libyang_%.bbappend",
> >>              "meta-arago-test/dynamic-layers/qt6-layer/recipes-core/packagegroups/ti-test.bbappend",
> >>              "meta-arago-test/dynamic-layers/flutter-layer/recipes-graphics/flutter/flutter-wayland-client_%.bbappend",
> >>+            "meta-arago-test/dynamic-layers/flutter-layer/recipes-graphics/flutter/flutter-samples-material-3-demo_%.bbappend",
> >>              "meta-arago-test/recipes-benchmark/stream/stream_%.bbappend",
> >>              "meta-arago-test/recipes-extended/bc/bc_%.bbappend"
> >>          ]
> >>diff --git a/meta-arago-test/dynamic-layers/flutter-layer/recipes-graphics/flutter/flutter-samples-material-3-demo-arago.inc b/meta-arago-test/dynamic-layers/flutter-layer/recipes-graphics/flutter/flutter-samples-material-3-demo-arago.inc
> >>new file mode 100644
> >>index 00000000..b2c9e13d
> >>--- /dev/null
> >>+++ b/meta-arago-test/dynamic-layers/flutter-layer/recipes-graphics/flutter/flutter-samples-material-3-demo-arago.inc
> >>@@ -0,0 +1 @@
> >>+FLUTTER_BUILD_ARGS:append = " --no-pub"
> >Will it work with += here instead of :append?
> >
> It would not work, the variable has a soft default that I want to
> abide by and append to. If I use "+=" it overrides the soft default
> value.
> 
> I finally got a proper use case for ":append" lol.

Ack, thanks.


> >>diff --git a/meta-arago-test/dynamic-layers/flutter-layer/recipes-graphics/flutter/flutter-samples-material-3-demo_%.bbappend b/meta-arago-test/dynamic-layers/flutter-layer/recipes-graphics/flutter/flutter-samples-material-3-demo_%.bbappend
> >>new file mode 100644
> >>index 00000000..f0ae3799
> >>--- /dev/null
> >>+++ b/meta-arago-test/dynamic-layers/flutter-layer/recipes-graphics/flutter/flutter-samples-material-3-demo_%.bbappend
> >>@@ -0,0 +1,4 @@
> >>+FLUTTER_ARAGO = ""
> >>+FLUTTER_ARAGO:arago = "flutter-samples-material-3-demo-arago.inc"
> >>+
> >>+require ${FLUTTER_ARAGO}
> >>-- 
> >>2.34.1
diff mbox series

Patch

diff --git a/check_yocto_rules.json b/check_yocto_rules.json
index 25c8c952..70bbe734 100644
--- a/check_yocto_rules.json
+++ b/check_yocto_rules.json
@@ -23,6 +23,7 @@ 
             "meta-arago-extras/recipes-extended/sysrepo/libyang_%.bbappend",
             "meta-arago-test/dynamic-layers/qt6-layer/recipes-core/packagegroups/ti-test.bbappend",
             "meta-arago-test/dynamic-layers/flutter-layer/recipes-graphics/flutter/flutter-wayland-client_%.bbappend",
+            "meta-arago-test/dynamic-layers/flutter-layer/recipes-graphics/flutter/flutter-samples-material-3-demo_%.bbappend",
             "meta-arago-test/recipes-benchmark/stream/stream_%.bbappend",
             "meta-arago-test/recipes-extended/bc/bc_%.bbappend"
         ]
diff --git a/meta-arago-test/dynamic-layers/flutter-layer/recipes-graphics/flutter/flutter-samples-material-3-demo-arago.inc b/meta-arago-test/dynamic-layers/flutter-layer/recipes-graphics/flutter/flutter-samples-material-3-demo-arago.inc
new file mode 100644
index 00000000..b2c9e13d
--- /dev/null
+++ b/meta-arago-test/dynamic-layers/flutter-layer/recipes-graphics/flutter/flutter-samples-material-3-demo-arago.inc
@@ -0,0 +1 @@ 
+FLUTTER_BUILD_ARGS:append = " --no-pub"
diff --git a/meta-arago-test/dynamic-layers/flutter-layer/recipes-graphics/flutter/flutter-samples-material-3-demo_%.bbappend b/meta-arago-test/dynamic-layers/flutter-layer/recipes-graphics/flutter/flutter-samples-material-3-demo_%.bbappend
new file mode 100644
index 00000000..f0ae3799
--- /dev/null
+++ b/meta-arago-test/dynamic-layers/flutter-layer/recipes-graphics/flutter/flutter-samples-material-3-demo_%.bbappend
@@ -0,0 +1,4 @@ 
+FLUTTER_ARAGO = ""
+FLUTTER_ARAGO:arago = "flutter-samples-material-3-demo-arago.inc"
+
+require ${FLUTTER_ARAGO}