| Message ID | 20220531213206.7119-2-marcel@ziswiler.com |
|---|---|
| State | New |
| Headers | show |
| Series | [v3,1/2] alsa-plugins: fix libavtp vs. avtp packageconfig | expand |
This should go to meta-oe I think. Does it have to be in core, and if so why? Alex On Tue, 31 May 2022 at 23:32, Marcel Ziswiler <marcel@ziswiler.com> wrote: > > From: Peter Bergin <peter@berginkonsult.se> > > In order to enable configuration option aaf (AVTP Audio Format) > used for AVB the library libavtp is a dependency but no recipe for > this library was present. aaf support for alsa-plugins was > introduced in ddf5421331180bc45697511b44cdd4a4e6dda6ff. > > Signed-off-by: Peter Bergin <peter@berginkonsult.se> > Signed-off-by: Marcel Ziswiler <marcel.ziswiler@toradex.com> > > --- > Resurrect from mailing list [1] as this is still not upstream. > End-to-end tested on Verdin iMX8M Plus. > Will talk about it at the Embedded World Conference in the TSN & Linux > track next month [2]. > > [1] https://lore.kernel.org/all/20210604090216.553285-1-peter@berginkonsult.se/ > [2] https://events.weka-fachmedien.de/embedded-world-conference/program/ > > Changes in v3: > - Rename recipe to officially released PV of 0.2.0. > - Drop PROVIDES of avtp which just works around alsa-plugins refering to > it as such instead of libavtp. Will update PACKAGECONFIG in > alsa-plugins instead. > > Changes in v2: > - Updated SRC_URI specifying mandatory protocol as https. > - Updated SRCREV to latest. > > meta/recipes-multimedia/libavtp/libavtp_0.2.0.bb | 14 ++++++++++++++ > 1 file changed, 14 insertions(+) > create mode 100644 meta/recipes-multimedia/libavtp/libavtp_0.2.0.bb > > diff --git a/meta/recipes-multimedia/libavtp/libavtp_0.2.0.bb b/meta/recipes-multimedia/libavtp/libavtp_0.2.0.bb > new file mode 100644 > index 0000000000..563debde3c > --- /dev/null > +++ b/meta/recipes-multimedia/libavtp/libavtp_0.2.0.bb > @@ -0,0 +1,14 @@ > +DESCRIPTION = "Open source implementation of Audio Video Transport Protocol (AVTP) \ > + specified in IEEE 1722-2016 spec." > +HOMEPAGE = "https://github.com/Avnu/libavtp" > +LICENSE = "BSD-3-Clause" > +LIC_FILES_CHKSUM = "file://LICENSE;md5=7fcb4331e23e45e171cd5693c1ff7d3e" > + > +SRC_URI = "git://github.com/Avnu/libavtp.git;branch=v${PV};protocol=https;nobranch=1" > +SRCREV = "3599a5bf2d18fc3ae89b64f208d8380e6ee3a866" > + > +S = "${WORKDIR}/git" > + > +inherit meson pkgconfig > + > +EXTRA_OEMESON = "-Dtests=disabled" > -- > 2.36.1 > > > -=-=-=-=-=-=-=-=-=-=-=- > Links: You receive all messages sent to this group. > View/Reply Online (#166338): https://lists.openembedded.org/g/openembedded-core/message/166338 > Mute This Topic: https://lists.openembedded.org/mt/91462033/1686489 > Group Owner: openembedded-core+owner@lists.openembedded.org > Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [alex.kanavin@gmail.com] > -=-=-=-=-=-=-=-=-=-=-=- >
On Wed, 2022-06-01 at 09:30 +0200, Alexander Kanavin wrote: > This should go to meta-oe I think. Does it have to be in core, and if so why? Good question. However, alsa-plugins (and gstreamer1.0-plugins-bad for that matter) also live there and may depend on it. > Alex Cheers Marcel > On Tue, 31 May 2022 at 23:32, Marcel Ziswiler <marcel@ziswiler.com> wrote: > > > > From: Peter Bergin <peter@berginkonsult.se> > > > > In order to enable configuration option aaf (AVTP Audio Format) > > used for AVB the library libavtp is a dependency but no recipe for > > this library was present. aaf support for alsa-plugins was > > introduced in ddf5421331180bc45697511b44cdd4a4e6dda6ff. > > > > Signed-off-by: Peter Bergin <peter@berginkonsult.se> > > Signed-off-by: Marcel Ziswiler <marcel.ziswiler@toradex.com> > > > > --- > > Resurrect from mailing list [1] as this is still not upstream. > > End-to-end tested on Verdin iMX8M Plus. > > Will talk about it at the Embedded World Conference in the TSN & Linux > > track next month [2]. > > > > [1] https://lore.kernel.org/all/20210604090216.553285-1-peter@berginkonsult.se/ > > [2] https://events.weka-fachmedien.de/embedded-world-conference/program/ > > > > Changes in v3: > > - Rename recipe to officially released PV of 0.2.0. > > - Drop PROVIDES of avtp which just works around alsa-plugins refering to > > it as such instead of libavtp. Will update PACKAGECONFIG in > > alsa-plugins instead. > > > > Changes in v2: > > - Updated SRC_URI specifying mandatory protocol as https. > > - Updated SRCREV to latest. > > > > meta/recipes-multimedia/libavtp/libavtp_0.2.0.bb | 14 ++++++++++++++ > > 1 file changed, 14 insertions(+) > > create mode 100644 meta/recipes-multimedia/libavtp/libavtp_0.2.0.bb > > > > diff --git a/meta/recipes-multimedia/libavtp/libavtp_0.2.0.bb b/meta/recipes- > > multimedia/libavtp/libavtp_0.2.0.bb > > new file mode 100644 > > index 0000000000..563debde3c > > --- /dev/null > > +++ b/meta/recipes-multimedia/libavtp/libavtp_0.2.0.bb > > @@ -0,0 +1,14 @@ > > +DESCRIPTION = "Open source implementation of Audio Video Transport Protocol (AVTP) \ > > + specified in IEEE 1722-2016 spec." > > +HOMEPAGE = "https://github.com/Avnu/libavtp" > > +LICENSE = "BSD-3-Clause" > > +LIC_FILES_CHKSUM = "file://LICENSE;md5=7fcb4331e23e45e171cd5693c1ff7d3e" > > + > > +SRC_URI = "git://github.com/Avnu/libavtp.git;branch=v${PV};protocol=https;nobranch=1" > > +SRCREV = "3599a5bf2d18fc3ae89b64f208d8380e6ee3a866" > > + > > +S = "${WORKDIR}/git" > > + > > +inherit meson pkgconfig > > + > > +EXTRA_OEMESON = "-Dtests=disabled" > > -- > > 2.36.1 > > > > > > -=-=-=-=-=-=-=-=-=-=-=- > > Links: You receive all messages sent to this group. > > View/Reply Online (#166338): https://lists.openembedded.org/g/openembedded-core/message/166338 > > Mute This Topic: https://lists.openembedded.org/mt/91462033/1686489 > > Group Owner: openembedded-core+owner@lists.openembedded.org > > Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [alex.kanavin@gmail.com] > > -=-=-=-=-=-=-=-=-=-=-=-
Marcel, Peter, On 5/31/22 23:32, Marcel Ziswiler wrote: > From: Peter Bergin <peter@berginkonsult.se> > > In order to enable configuration option aaf (AVTP Audio Format) > used for AVB the library libavtp is a dependency but no recipe for > this library was present. aaf support for alsa-plugins was > introduced in ddf5421331180bc45697511b44cdd4a4e6dda6ff. > > Signed-off-by: Peter Bergin <peter@berginkonsult.se> > Signed-off-by: Marcel Ziswiler <marcel.ziswiler@toradex.com> > > --- > Resurrect from mailing list [1] as this is still not upstream. > End-to-end tested on Verdin iMX8M Plus. > Will talk about it at the Embedded World Conference in the TSN & Linux > track next month [2]. > > [1] https://urldefense.proofpoint.com/v2/url?u=https-3A__lore.kernel.org_all_20210604090216.553285-2D1-2Dpeter-40berginkonsult.se_&d=DwIDAg&c=_sEr5x9kUWhuk4_nFwjJtA&r=LYjLexDn7rXIzVmkNPvw5ymA1XTSqHGq8yBP6m6qZZ4njZguQhZhkI_-172IIy1t&m=j5mDhOeNcVWNco5eYp6S60KnL4GmuLwFOeDnKizzUfY4ScAsBe2IQUQckKzHOrVn&s=1nRYQeY7NOzqrW7qZafcgBMa2RIx8BtF-kVsHpEX-5c&e= > [2] https://urldefense.proofpoint.com/v2/url?u=https-3A__events.weka-2Dfachmedien.de_embedded-2Dworld-2Dconference_program_&d=DwIDAg&c=_sEr5x9kUWhuk4_nFwjJtA&r=LYjLexDn7rXIzVmkNPvw5ymA1XTSqHGq8yBP6m6qZZ4njZguQhZhkI_-172IIy1t&m=j5mDhOeNcVWNco5eYp6S60KnL4GmuLwFOeDnKizzUfY4ScAsBe2IQUQckKzHOrVn&s=EnuuWrWZcXP5wNN4T2S7S57HMhsQNkAZRpv0q1iyMW8&e= > > Changes in v3: > - Rename recipe to officially released PV of 0.2.0. > - Drop PROVIDES of avtp which just works around alsa-plugins refering to > it as such instead of libavtp. Will update PACKAGECONFIG in > alsa-plugins instead. > > Changes in v2: > - Updated SRC_URI specifying mandatory protocol as https. > - Updated SRCREV to latest. > > meta/recipes-multimedia/libavtp/libavtp_0.2.0.bb | 14 ++++++++++++++ > 1 file changed, 14 insertions(+) > create mode 100644 meta/recipes-multimedia/libavtp/libavtp_0.2.0.bb > > diff --git a/meta/recipes-multimedia/libavtp/libavtp_0.2.0.bb b/meta/recipes-multimedia/libavtp/libavtp_0.2.0.bb > new file mode 100644 > index 0000000000..563debde3c > --- /dev/null > +++ b/meta/recipes-multimedia/libavtp/libavtp_0.2.0.bb > @@ -0,0 +1,14 @@ > +DESCRIPTION = "Open source implementation of Audio Video Transport Protocol (AVTP) \ > + specified in IEEE 1722-2016 spec." > +HOMEPAGE = "https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_Avnu_libavtp&d=DwIDAg&c=_sEr5x9kUWhuk4_nFwjJtA&r=LYjLexDn7rXIzVmkNPvw5ymA1XTSqHGq8yBP6m6qZZ4njZguQhZhkI_-172IIy1t&m=j5mDhOeNcVWNco5eYp6S60KnL4GmuLwFOeDnKizzUfY4ScAsBe2IQUQckKzHOrVn&s=CDG7OGmgTZNqph7uuR6Au6HBdZZmu_0lUYUC1dYWjsg&e= " > +LICENSE = "BSD-3-Clause" > +LIC_FILES_CHKSUM = "file://LICENSE;md5=7fcb4331e23e45e171cd5693c1ff7d3e" > + > +SRC_URI = "git://github.com/Avnu/libavtp.git;branch=v${PV};protocol=https;nobranch=1" We don't have a single recipe with nobranch set in poky, so I think we should keep it this way. I assume this was needed because, there's no ${PV} branch available in the git repo (it's a tag). Technically, ${PV} is a tag on github and not a branch. We don't have a single recipe with tag set in poky, so I think we also should keep it this way (tag= requires network to check that the tag hasn't moved between builds). What I've seen some recipes do instead is to use github archives. See: https://git.yoctoproject.org/poky/tree/meta/recipes-support/re2c/re2c_3.0.bb Re: alsa-plugins which may require it in a PACKAGECONFIG option, it's not really a reason for inclusion if not enabled by default. Otherwise we would have one big layer only with all possible optional dependencies and their possible optional dependencies, etc... Cheers, Quentin
As long as the dependency is optional and controlled via PACKAGECONFIG and off by default, the recipe does not have to be in core, and we have plenty of examples of similar arrangements. Alex On Wed, 1 Jun 2022 at 10:05, Marcel Ziswiler <marcel@ziswiler.com> wrote: > > On Wed, 2022-06-01 at 09:30 +0200, Alexander Kanavin wrote: > > This should go to meta-oe I think. Does it have to be in core, and if so why? > > Good question. However, alsa-plugins (and gstreamer1.0-plugins-bad for that matter) also live there and may > depend on it. > > > Alex > > Cheers > > Marcel > > > On Tue, 31 May 2022 at 23:32, Marcel Ziswiler <marcel@ziswiler.com> wrote: > > > > > > From: Peter Bergin <peter@berginkonsult.se> > > > > > > In order to enable configuration option aaf (AVTP Audio Format) > > > used for AVB the library libavtp is a dependency but no recipe for > > > this library was present. aaf support for alsa-plugins was > > > introduced in ddf5421331180bc45697511b44cdd4a4e6dda6ff. > > > > > > Signed-off-by: Peter Bergin <peter@berginkonsult.se> > > > Signed-off-by: Marcel Ziswiler <marcel.ziswiler@toradex.com> > > > > > > --- > > > Resurrect from mailing list [1] as this is still not upstream. > > > End-to-end tested on Verdin iMX8M Plus. > > > Will talk about it at the Embedded World Conference in the TSN & Linux > > > track next month [2]. > > > > > > [1] https://lore.kernel.org/all/20210604090216.553285-1-peter@berginkonsult.se/ > > > [2] https://events.weka-fachmedien.de/embedded-world-conference/program/ > > > > > > Changes in v3: > > > - Rename recipe to officially released PV of 0.2.0. > > > - Drop PROVIDES of avtp which just works around alsa-plugins refering to > > > it as such instead of libavtp. Will update PACKAGECONFIG in > > > alsa-plugins instead. > > > > > > Changes in v2: > > > - Updated SRC_URI specifying mandatory protocol as https. > > > - Updated SRCREV to latest. > > > > > > meta/recipes-multimedia/libavtp/libavtp_0.2.0.bb | 14 ++++++++++++++ > > > 1 file changed, 14 insertions(+) > > > create mode 100644 meta/recipes-multimedia/libavtp/libavtp_0.2.0.bb > > > > > > diff --git a/meta/recipes-multimedia/libavtp/libavtp_0.2.0.bb b/meta/recipes- > > > multimedia/libavtp/libavtp_0.2.0.bb > > > new file mode 100644 > > > index 0000000000..563debde3c > > > --- /dev/null > > > +++ b/meta/recipes-multimedia/libavtp/libavtp_0.2.0.bb > > > @@ -0,0 +1,14 @@ > > > +DESCRIPTION = "Open source implementation of Audio Video Transport Protocol (AVTP) \ > > > + specified in IEEE 1722-2016 spec." > > > +HOMEPAGE = "https://github.com/Avnu/libavtp" > > > +LICENSE = "BSD-3-Clause" > > > +LIC_FILES_CHKSUM = "file://LICENSE;md5=7fcb4331e23e45e171cd5693c1ff7d3e" > > > + > > > +SRC_URI = "git://github.com/Avnu/libavtp.git;branch=v${PV};protocol=https;nobranch=1" > > > +SRCREV = "3599a5bf2d18fc3ae89b64f208d8380e6ee3a866" > > > + > > > +S = "${WORKDIR}/git" > > > + > > > +inherit meson pkgconfig > > > + > > > +EXTRA_OEMESON = "-Dtests=disabled" > > > -- > > > 2.36.1 > > > > > > > > > -=-=-=-=-=-=-=-=-=-=-=- > > > Links: You receive all messages sent to this group. > > > View/Reply Online (#166338): https://lists.openembedded.org/g/openembedded-core/message/166338 > > > Mute This Topic: https://lists.openembedded.org/mt/91462033/1686489 > > > Group Owner: openembedded-core+owner@lists.openembedded.org > > > Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [alex.kanavin@gmail.com] > > > -=-=-=-=-=-=-=-=-=-=-=-
Hi Quentin On Wed, 2022-06-01 at 10:13 +0200, Quentin Schulz wrote: > Marcel, Peter, > > On 5/31/22 23:32, Marcel Ziswiler wrote: > > From: Peter Bergin <peter@berginkonsult.se> > > [snip] > > + > > +SRC_URI = "git://github.com/Avnu/libavtp.git;branch=v${PV};protocol=https;nobranch=1" > > We don't have a single recipe with nobranch set in poky, so I think we > should keep it this way. I assume this was needed because, there's no > ${PV} branch available in the git repo (it's a tag). > > Technically, ${PV} is a tag on github and not a branch. We don't have a > single recipe with tag set in poky, so I think we also should keep it > this way (tag= requires network to check that the tag hasn't moved > between builds). Well, remember. It wasn't me suggesting the use of PV. However, at least at first it really sounded like a sensible goal. > What I've seen some recipes do instead is to use github archives. See: > https://git.yoctoproject.org/poky/tree/meta/recipes-support/re2c/re2c_3.0.bb I have been there before, but, unfortunately, Avnu's libavtp on github only uses their archive [1] and not some other download facility whose use is also discouraged as per [2]. I mean I guess I could just rename the recipe and otherwise keep relying on git with a hash but that also does not seem like a really good option (e.g. keeping PV and hash in sync and/or even checking on this would be a completely manual task). Not sure. I hope somebody more experienced might present the golden trick to this dilemma. Thanks! [1] https://github.com/Avnu/libavtp/archive/refs/tags/v0.2.0.tar.gz [2] https://git.yoctoproject.org/poky/tree/scripts/lib/recipetool/create.py#n430 > Re: alsa-plugins which may require it in a PACKAGECONFIG option, it's > not really a reason for inclusion if not enabled by default. Otherwise > we would have one big layer only with all possible optional dependencies > and their possible optional dependencies, etc... > > Cheers, > Quentin Cheers Marcel
On Wed, 2022-06-01 at 10:22 +0200, Alexander Kanavin wrote: > As long as the dependency is optional and controlled via PACKAGECONFIG > and off by default, the recipe does not have to be in core, and we > have plenty of examples of similar arrangements. Understood and agreed. Let me move it. Still waiting on the resolution of the git hash tag vs. PV download dilemma though... Thanks! > Alex Cheers Marcel > On Wed, 1 Jun 2022 at 10:05, Marcel Ziswiler <marcel@ziswiler.com> wrote: > > > > On Wed, 2022-06-01 at 09:30 +0200, Alexander Kanavin wrote: > > > This should go to meta-oe I think. Does it have to be in core, and if so why? > > > > Good question. However, alsa-plugins (and gstreamer1.0-plugins-bad for that matter) also live there and may > > depend on it. > > > > > Alex > > > > Cheers > > > > Marcel > > > > > On Tue, 31 May 2022 at 23:32, Marcel Ziswiler <marcel@ziswiler.com> wrote: > > > > > > > > From: Peter Bergin <peter@berginkonsult.se> > > > > > > > > In order to enable configuration option aaf (AVTP Audio Format) > > > > used for AVB the library libavtp is a dependency but no recipe for > > > > this library was present. aaf support for alsa-plugins was > > > > introduced in ddf5421331180bc45697511b44cdd4a4e6dda6ff. > > > > > > > > Signed-off-by: Peter Bergin <peter@berginkonsult.se> > > > > Signed-off-by: Marcel Ziswiler <marcel.ziswiler@toradex.com> > > > > > > > > --- > > > > Resurrect from mailing list [1] as this is still not upstream. > > > > End-to-end tested on Verdin iMX8M Plus. > > > > Will talk about it at the Embedded World Conference in the TSN & Linux > > > > track next month [2]. > > > > > > > > [1] https://lore.kernel.org/all/20210604090216.553285-1-peter@berginkonsult.se/ > > > > [2] https://events.weka-fachmedien.de/embedded-world-conference/program/ > > > > > > > > Changes in v3: > > > > - Rename recipe to officially released PV of 0.2.0. > > > > - Drop PROVIDES of avtp which just works around alsa-plugins refering to > > > > it as such instead of libavtp. Will update PACKAGECONFIG in > > > > alsa-plugins instead. > > > > > > > > Changes in v2: > > > > - Updated SRC_URI specifying mandatory protocol as https. > > > > - Updated SRCREV to latest. > > > > > > > > meta/recipes-multimedia/libavtp/libavtp_0.2.0.bb | 14 ++++++++++++++ > > > > 1 file changed, 14 insertions(+) > > > > create mode 100644 meta/recipes-multimedia/libavtp/libavtp_0.2.0.bb > > > > > > > > diff --git a/meta/recipes-multimedia/libavtp/libavtp_0.2.0.bb b/meta/recipes- > > > > multimedia/libavtp/libavtp_0.2.0.bb > > > > new file mode 100644 > > > > index 0000000000..563debde3c > > > > --- /dev/null > > > > +++ b/meta/recipes-multimedia/libavtp/libavtp_0.2.0.bb > > > > @@ -0,0 +1,14 @@ > > > > +DESCRIPTION = "Open source implementation of Audio Video Transport Protocol (AVTP) \ > > > > + specified in IEEE 1722-2016 spec." > > > > +HOMEPAGE = "https://github.com/Avnu/libavtp" > > > > +LICENSE = "BSD-3-Clause" > > > > +LIC_FILES_CHKSUM = "file://LICENSE;md5=7fcb4331e23e45e171cd5693c1ff7d3e" > > > > + > > > > +SRC_URI = "git://github.com/Avnu/libavtp.git;branch=v${PV};protocol=https;nobranch=1" > > > > +SRCREV = "3599a5bf2d18fc3ae89b64f208d8380e6ee3a866" > > > > + > > > > +S = "${WORKDIR}/git" > > > > + > > > > +inherit meson pkgconfig > > > > + > > > > +EXTRA_OEMESON = "-Dtests=disabled" > > > > -- > > > > 2.36.1 > > > > > > > > > > > > -=-=-=-=-=-=-=-=-=-=-=- > > > > Links: You receive all messages sent to this group. > > > > View/Reply Online (#166338): https://lists.openembedded.org/g/openembedded-core/message/166338 > > > > Mute This Topic: https://lists.openembedded.org/mt/91462033/1686489 > > > > Group Owner: openembedded-core+owner@lists.openembedded.org > > > > Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [alex.kanavin@gmail.com] > > > > -=-=-=-=-=-=-=-=-=-=-=-
I'm not sure what the dilemma is, inspecting the repo shows that there's a standard 0.2.0 tag pointing to a commit in the master branch. You can look at pretty much any other recipe fetching from git. https://github.com/Avnu/libavtp/tags Alex On Wed, 1 Jun 2022 at 10:34, Marcel Ziswiler <marcel@ziswiler.com> wrote: > > On Wed, 2022-06-01 at 10:22 +0200, Alexander Kanavin wrote: > > As long as the dependency is optional and controlled via PACKAGECONFIG > > and off by default, the recipe does not have to be in core, and we > > have plenty of examples of similar arrangements. > > Understood and agreed. Let me move it. > > Still waiting on the resolution of the git hash tag vs. PV download dilemma though... > > Thanks! > > > Alex > > Cheers > > Marcel > > > On Wed, 1 Jun 2022 at 10:05, Marcel Ziswiler <marcel@ziswiler.com> wrote: > > > > > > On Wed, 2022-06-01 at 09:30 +0200, Alexander Kanavin wrote: > > > > This should go to meta-oe I think. Does it have to be in core, and if so why? > > > > > > Good question. However, alsa-plugins (and gstreamer1.0-plugins-bad for that matter) also live there and may > > > depend on it. > > > > > > > Alex > > > > > > Cheers > > > > > > Marcel > > > > > > > On Tue, 31 May 2022 at 23:32, Marcel Ziswiler <marcel@ziswiler.com> wrote: > > > > > > > > > > From: Peter Bergin <peter@berginkonsult.se> > > > > > > > > > > In order to enable configuration option aaf (AVTP Audio Format) > > > > > used for AVB the library libavtp is a dependency but no recipe for > > > > > this library was present. aaf support for alsa-plugins was > > > > > introduced in ddf5421331180bc45697511b44cdd4a4e6dda6ff. > > > > > > > > > > Signed-off-by: Peter Bergin <peter@berginkonsult.se> > > > > > Signed-off-by: Marcel Ziswiler <marcel.ziswiler@toradex.com> > > > > > > > > > > --- > > > > > Resurrect from mailing list [1] as this is still not upstream. > > > > > End-to-end tested on Verdin iMX8M Plus. > > > > > Will talk about it at the Embedded World Conference in the TSN & Linux > > > > > track next month [2]. > > > > > > > > > > [1] https://lore.kernel.org/all/20210604090216.553285-1-peter@berginkonsult.se/ > > > > > [2] https://events.weka-fachmedien.de/embedded-world-conference/program/ > > > > > > > > > > Changes in v3: > > > > > - Rename recipe to officially released PV of 0.2.0. > > > > > - Drop PROVIDES of avtp which just works around alsa-plugins refering to > > > > > it as such instead of libavtp. Will update PACKAGECONFIG in > > > > > alsa-plugins instead. > > > > > > > > > > Changes in v2: > > > > > - Updated SRC_URI specifying mandatory protocol as https. > > > > > - Updated SRCREV to latest. > > > > > > > > > > meta/recipes-multimedia/libavtp/libavtp_0.2.0.bb | 14 ++++++++++++++ > > > > > 1 file changed, 14 insertions(+) > > > > > create mode 100644 meta/recipes-multimedia/libavtp/libavtp_0.2.0.bb > > > > > > > > > > diff --git a/meta/recipes-multimedia/libavtp/libavtp_0.2.0.bb b/meta/recipes- > > > > > multimedia/libavtp/libavtp_0.2.0.bb > > > > > new file mode 100644 > > > > > index 0000000000..563debde3c > > > > > --- /dev/null > > > > > +++ b/meta/recipes-multimedia/libavtp/libavtp_0.2.0.bb > > > > > @@ -0,0 +1,14 @@ > > > > > +DESCRIPTION = "Open source implementation of Audio Video Transport Protocol (AVTP) \ > > > > > + specified in IEEE 1722-2016 spec." > > > > > +HOMEPAGE = "https://github.com/Avnu/libavtp" > > > > > +LICENSE = "BSD-3-Clause" > > > > > +LIC_FILES_CHKSUM = "file://LICENSE;md5=7fcb4331e23e45e171cd5693c1ff7d3e" > > > > > + > > > > > +SRC_URI = "git://github.com/Avnu/libavtp.git;branch=v${PV};protocol=https;nobranch=1" > > > > > +SRCREV = "3599a5bf2d18fc3ae89b64f208d8380e6ee3a866" > > > > > + > > > > > +S = "${WORKDIR}/git" > > > > > + > > > > > +inherit meson pkgconfig > > > > > + > > > > > +EXTRA_OEMESON = "-Dtests=disabled" > > > > > -- > > > > > 2.36.1 > > > > > > > > > > > > > > > -=-=-=-=-=-=-=-=-=-=-=- > > > > > Links: You receive all messages sent to this group. > > > > > View/Reply Online (#166338): https://lists.openembedded.org/g/openembedded-core/message/166338 > > > > > Mute This Topic: https://lists.openembedded.org/mt/91462033/1686489 > > > > > Group Owner: openembedded-core+owner@lists.openembedded.org > > > > > Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [alex.kanavin@gmail.com] > > > > > -=-=-=-=-=-=-=-=-=-=-=-
On 2022-06-01 11:43, Alexander Kanavin wrote: > I'm not sure what the dilemma is, inspecting the repo shows that > there's a standard 0.2.0 tag pointing to a commit in the master > branch. You can look at pretty much any other recipe fetching from > git. > https://github.com/Avnu/libavtp/tags > Agree. My suggestion for solution is 'SRC_URI=-...;branch=master...' + 'SRCREV=<sha-sum of tag 0.2.0>' and rename recipe to libavtp_0.2.0.bb. I don't know if that is against any style guide or rules? And also fine with a move to meta-openembedded. /Peter
On Wed, 2022-06-01 at 12:52 +0200, Peter Bergin wrote: > On 2022-06-01 11:43, Alexander Kanavin wrote: > > I'm not sure what the dilemma is, inspecting the repo shows that > > there's a standard 0.2.0 tag pointing to a commit in the master > > branch. You can look at pretty much any other recipe fetching from > > git. > > https://github.com/Avnu/libavtp/tags > > > Agree. I also fully agree. Sorry for my confusion in this regard. > My suggestion for solution is 'SRC_URI=-...;branch=master...' + > 'SRCREV=<sha-sum of tag 0.2.0>' and rename recipe to libavtp_0.2.0.bb. I > don't know if that is against any style guide or rules? > > And also fine with a move to meta-openembedded. Sure, let me do that. Thanks! > /Peter Cheers Marcel
Hi Marcel, On Tue, 31 May 2022 23:32:06 +0200 "Marcel Ziswiler" <marcel@ziswiler.com> wrote: > From: Peter Bergin <peter@berginkonsult.se> > > In order to enable configuration option aaf (AVTP Audio Format) > used for AVB the library libavtp is a dependency but no recipe for > this library was present. aaf support for alsa-plugins was > introduced in ddf5421331180bc45697511b44cdd4a4e6dda6ff. > > Signed-off-by: Peter Bergin <peter@berginkonsult.se> > Signed-off-by: Marcel Ziswiler <marcel.ziswiler@toradex.com> This patch is failing on musl builds: https://autobuilder.yoctoproject.org/typhoon/#/builders/45/builds/5308/steps/11/logs/stdio https://autobuilder.yoctoproject.org/typhoon/#/builders/64/builds/5294/steps/12/logs/stdio
Hi Marcel, On Wed, 1 Jun 2022 15:48:15 +0200 "Luca Ceresoli via lists.openembedded.org" <luca.ceresoli=bootlin.com@lists.openembedded.org> wrote: > Hi Marcel, > > On Tue, 31 May 2022 23:32:06 +0200 > "Marcel Ziswiler" <marcel@ziswiler.com> wrote: > > > From: Peter Bergin <peter@berginkonsult.se> > > > > In order to enable configuration option aaf (AVTP Audio Format) > > used for AVB the library libavtp is a dependency but no recipe for > > this library was present. aaf support for alsa-plugins was > > introduced in ddf5421331180bc45697511b44cdd4a4e6dda6ff. > > > > Signed-off-by: Peter Bergin <peter@berginkonsult.se> > > Signed-off-by: Marcel Ziswiler <marcel.ziswiler@toradex.com> > > This patch is failing on musl builds: > > https://autobuilder.yoctoproject.org/typhoon/#/builders/45/builds/5308/steps/11/logs/stdio > https://autobuilder.yoctoproject.org/typhoon/#/builders/64/builds/5294/steps/12/logs/stdio This patch also triggers selftest errors because the new recipe has no maintainer: https://autobuilder.yoctoproject.org/typhoon/#/builders/79/builds/3657/steps/15/logs/stdio https://autobuilder.yoctoproject.org/typhoon/#/builders/87/builds/3661/steps/14/logs/stdio
On Wed, 2022-06-01 at 15:48 +0200, Luca Ceresoli wrote: > Hi Marcel, > > On Tue, 31 May 2022 23:32:06 +0200 > "Marcel Ziswiler" <marcel@ziswiler.com> wrote: > > > From: Peter Bergin <peter@berginkonsult.se> > > > > In order to enable configuration option aaf (AVTP Audio Format) > > used for AVB the library libavtp is a dependency but no recipe for > > this library was present. aaf support for alsa-plugins was > > introduced in ddf5421331180bc45697511b44cdd4a4e6dda6ff. > > > > Signed-off-by: Peter Bergin <peter@berginkonsult.se> > > Signed-off-by: Marcel Ziswiler <marcel.ziswiler@toradex.com> > > This patch is failing on musl builds: > > https://autobuilder.yoctoproject.org/typhoon/#/builders/45/builds/5308/steps/11/logs/stdio > https://autobuilder.yoctoproject.org/typhoon/#/builders/64/builds/5294/steps/12/logs/stdio To be honest, I don't know nothing about musl and will need to get familiar with that topic first. If anybody has some suggestions that would be highly appreciated. Thanks! Cheers Marcel
On Wed, 2022-06-01 at 17:05 +0200, Luca Ceresoli wrote: > Hi Marcel, > > On Wed, 1 Jun 2022 15:48:15 +0200 > "Luca Ceresoli via lists.openembedded.org" > <luca.ceresoli=bootlin.com@lists.openembedded.org> wrote: > > > Hi Marcel, > > > > On Tue, 31 May 2022 23:32:06 +0200 > > "Marcel Ziswiler" <marcel@ziswiler.com> wrote: > > > > > From: Peter Bergin <peter@berginkonsult.se> > > > > > > In order to enable configuration option aaf (AVTP Audio Format) > > > used for AVB the library libavtp is a dependency but no recipe for > > > this library was present. aaf support for alsa-plugins was > > > introduced in ddf5421331180bc45697511b44cdd4a4e6dda6ff. > > > > > > Signed-off-by: Peter Bergin <peter@berginkonsult.se> > > > Signed-off-by: Marcel Ziswiler <marcel.ziswiler@toradex.com> > > > > This patch is failing on musl builds: > > > > https://autobuilder.yoctoproject.org/typhoon/#/builders/45/builds/5308/steps/11/logs/stdio > > https://autobuilder.yoctoproject.org/typhoon/#/builders/64/builds/5294/steps/12/logs/stdio > > This patch also triggers selftest errors because the new recipe has no > maintainer: > > https://autobuilder.yoctoproject.org/typhoon/#/builders/79/builds/3657/steps/15/logs/stdio > https://autobuilder.yoctoproject.org/typhoon/#/builders/87/builds/3661/steps/14/logs/stdio Okay, thanks. Sorry, I missed this being a mandatory requirement now. I guess I can add me and/or Peter as maintainer. No biggy really. Cheers Marcel
On Wed, Jun 1, 2022 at 5:14 PM Marcel Ziswiler <marcel@ziswiler.com> wrote: > > On Wed, 2022-06-01 at 15:48 +0200, Luca Ceresoli wrote: > > Hi Marcel, > > > > On Tue, 31 May 2022 23:32:06 +0200 > > "Marcel Ziswiler" <marcel@ziswiler.com> wrote: > > > > > From: Peter Bergin <peter@berginkonsult.se> > > > > > > In order to enable configuration option aaf (AVTP Audio Format) > > > used for AVB the library libavtp is a dependency but no recipe for > > > this library was present. aaf support for alsa-plugins was > > > introduced in ddf5421331180bc45697511b44cdd4a4e6dda6ff. > > > > > > Signed-off-by: Peter Bergin <peter@berginkonsult.se> > > > Signed-off-by: Marcel Ziswiler <marcel.ziswiler@toradex.com> > > > > This patch is failing on musl builds: > > > > https://autobuilder.yoctoproject.org/typhoon/#/builders/45/builds/5308/steps/11/logs/stdio > > https://autobuilder.yoctoproject.org/typhoon/#/builders/64/builds/5294/steps/12/logs/stdio > > To be honest, I don't know nothing about musl and will need to get familiar with that topic first. If anybody > has some suggestions that would be highly appreciated. Thanks! > > Cheers > > Marcel > I have the patch ready for Marcel. So with the move to meta-openembedded the recipe will also build with musl. Max
diff --git a/meta/recipes-multimedia/libavtp/libavtp_0.2.0.bb b/meta/recipes-multimedia/libavtp/libavtp_0.2.0.bb new file mode 100644 index 0000000000..563debde3c --- /dev/null +++ b/meta/recipes-multimedia/libavtp/libavtp_0.2.0.bb @@ -0,0 +1,14 @@ +DESCRIPTION = "Open source implementation of Audio Video Transport Protocol (AVTP) \ + specified in IEEE 1722-2016 spec." +HOMEPAGE = "https://github.com/Avnu/libavtp" +LICENSE = "BSD-3-Clause" +LIC_FILES_CHKSUM = "file://LICENSE;md5=7fcb4331e23e45e171cd5693c1ff7d3e" + +SRC_URI = "git://github.com/Avnu/libavtp.git;branch=v${PV};protocol=https;nobranch=1" +SRCREV = "3599a5bf2d18fc3ae89b64f208d8380e6ee3a866" + +S = "${WORKDIR}/git" + +inherit meson pkgconfig + +EXTRA_OEMESON = "-Dtests=disabled"