diff mbox series

[OE-core] bitbake-setup: Add strip to dldir

Message ID 20260205024502.2382-1-liuyd.fnst@fujitsu.com
State New
Headers show
Series [OE-core] bitbake-setup: Add strip to dldir | expand

Commit Message

Liu Yiding Feb. 5, 2026, 2:45 a.m. UTC
If user add "" to dl-dir as DL_DIR, it will show FetchError as following.

 raise FetchError("Unable to fetch URL from any source.", u)
bb.fetch2.FetchError: Fetcher failure for URL: 'git://git.openembedded.org/bitbake;protocol=https;rev=master;branch=master;destsuffix=bitbake'. Unable to fetch URL from any source.

But from this log, user can't locate the real reason which is that the path "/aa/bb" is invalid.

So I make this fix, even if user add "" to dl-dir, the dl-dir will be the valid path.

Signed-off-by: Liu Yiding <liuyd.fnst@fujitsu.com>
---
 bin/bitbake-setup | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Alexander Kanavin Feb. 5, 2026, 9:35 a.m. UTC | #1
On Thu, 5 Feb 2026 at 08:03, Yiding Liu (Fujitsu) via
lists.openembedded.org <liuyd.fnst=fujitsu.com@lists.openembedded.org>
wrote:
> -    dldir = settings["default"]["dl-dir"]
> +    dldir = settings["default"]["dl-dir"].strip('"')

This makes sense, but we should be doing it consistently with all the
settings that are strings, particularly top dir prefix and name would
have the same issue. Can you look into it please?

Alex
diff mbox series

Patch

diff --git a/bin/bitbake-setup b/bin/bitbake-setup
index abe7614c8..2ea5a5f3b 100755
--- a/bin/bitbake-setup
+++ b/bin/bitbake-setup
@@ -41,7 +41,7 @@  def cache_dir(top_dir):
     return os.path.join(top_dir, '.bitbake-setup-cache')
 
 def init_bb_cache(top_dir, settings, args):
-    dldir = settings["default"]["dl-dir"]
+    dldir = settings["default"]["dl-dir"].strip('"')
     bb_cachedir = os.path.join(cache_dir(top_dir), 'bitbake-cache')
 
     d = bb.data.init()