| Message ID | 20260123060348.2493115-4-p-bhagat@ti.com |
|---|---|
| State | RFC |
| Delegated to: | Ryan Eatmon |
| Headers | show |
| Series | Add pipeWire audio stack for am62dxx | expand |
Hi Paresh, On 11:33-20260123, Paresh Bhagat via lists.yoctoproject.org wrote: > Add pipewire and wireplumber audio stack support for am62dxx: > - Include pipewire core components and tools > - Add ALSA and PulseAudio compatibility layers > - Include wireplumber session manager > - Add GStreamer pipewire plugin > - Configure pipewire with proper modules and plugins > > Signed-off-by: Paresh Bhagat <p-bhagat@ti.com> > --- Thanks for your patch! > .../recipes-core/images/tisdk-default-image.bb | 17 +++++++++++++++++ > 1 file changed, 17 insertions(+) > > diff --git a/meta-arago-distro/recipes-core/images/tisdk-default-image.bb b/meta-arago-distro/recipes-core/images/tisdk-default-image.bb > index 264d1b2d..d5db6fd4 100644 > --- a/meta-arago-distro/recipes-core/images/tisdk-default-image.bb > +++ b/meta-arago-distro/recipes-core/images/tisdk-default-image.bb > @@ -47,3 +47,20 @@ IMAGE_INSTALL += "\ > ${@bb.utils.contains('TUNE_FEATURES', 'armv7a', 'valgrind', '', d)} \ > docker \ > " > + > +IMAGE_INSTALL:append:am62dxx = " \ > + pipewire \ > + pipewire-tools \ > + pipewire-alsa \ > + pipewire-pulse \ > + wireplumber \ > + speexdsp \ > + libpipewire \ > + pipewire-spa-plugins-meta \ > + pipewire-spa-tools \ > + pipewire-modules-meta \ > + pipewire-alsa-card-profile \ > + gstreamer1.0-pipewire \ > +" > +PACKAGECONFIG:append:am62dxx:pn-pipewire = " pipewire-jack pipewire-modules pipewire-spa-plugins" > +PACKAGECONFIG:remove:am62dxx:pn-pipewire = " jack" As per yocto docs [0], `pn-pipewire` would not work inside an image recipe. I suggest dropping PACKAGECONFIG lines, Instead put the PACKAGECONFIG lines in `pipewire_%.bbappend` ``` PACKAGECONFIG:append:am62dxx = " pipewire-jack pipewire-modules pipewire-spa-plugins" PACKAGECONFIG:remove:am62dxx = " jack" ``` [0]: https://docs.yoctoproject.org/ref-manual/variables.html#term-OVERRIDES Regards, - Yogesh
On 1/23/2026 12:03 AM, Paresh Bhagat wrote: > Add pipewire and wireplumber audio stack support for am62dxx: > - Include pipewire core components and tools > - Add ALSA and PulseAudio compatibility layers > - Include wireplumber session manager > - Add GStreamer pipewire plugin > - Configure pipewire with proper modules and plugins > > Signed-off-by: Paresh Bhagat <p-bhagat@ti.com> > --- > .../recipes-core/images/tisdk-default-image.bb | 17 +++++++++++++++++ > 1 file changed, 17 insertions(+) > > diff --git a/meta-arago-distro/recipes-core/images/tisdk-default-image.bb b/meta-arago-distro/recipes-core/images/tisdk-default-image.bb > index 264d1b2d..d5db6fd4 100644 > --- a/meta-arago-distro/recipes-core/images/tisdk-default-image.bb > +++ b/meta-arago-distro/recipes-core/images/tisdk-default-image.bb > @@ -47,3 +47,20 @@ IMAGE_INSTALL += "\ > ${@bb.utils.contains('TUNE_FEATURES', 'armv7a', 'valgrind', '', d)} \ > docker \ > " > + > +IMAGE_INSTALL:append:am62dxx = " \ > + pipewire \ > + pipewire-tools \ > + pipewire-alsa \ > + pipewire-pulse \ > + wireplumber \ > + speexdsp \ > + libpipewire \ > + pipewire-spa-plugins-meta \ > + pipewire-spa-tools \ > + pipewire-modules-meta \ > + pipewire-alsa-card-profile \ > + gstreamer1.0-pipewire \ > +" I'm sure at some point we will want to push the "more modern" pipewire to other boards as well. What is the reasoning for only doing this on am62d? Please create a PIPEWIRE variable that contains the above list and then: IMAGE_INSTALL:append:am62dxx = " ${PIPEWIRE}" Also, for ease of looking up packages, please sort the list alphabetically. > +PACKAGECONFIG:append:am62dxx:pn-pipewire = " pipewire-jack pipewire-modules pipewire-spa-plugins" > +PACKAGECONFIG:remove:am62dxx:pn-pipewire = " jack" Agree with Yogesh. This is not appropriate in this file. This should be in a pipewire bbappend.
On Fri, Jan 23, 2026 at 10:11:06AM -0600, Ryan Eatmon wrote: > > > On 1/23/2026 12:03 AM, Paresh Bhagat wrote: > >Add pipewire and wireplumber audio stack support for am62dxx: > >- Include pipewire core components and tools > >- Add ALSA and PulseAudio compatibility layers > >- Include wireplumber session manager > >- Add GStreamer pipewire plugin > >- Configure pipewire with proper modules and plugins > > > >Signed-off-by: Paresh Bhagat <p-bhagat@ti.com> > >--- > > .../recipes-core/images/tisdk-default-image.bb | 17 +++++++++++++++++ > > 1 file changed, 17 insertions(+) > > > >diff --git a/meta-arago-distro/recipes-core/images/tisdk-default-image.bb b/meta-arago-distro/recipes-core/images/tisdk-default-image.bb > >index 264d1b2d..d5db6fd4 100644 > >--- a/meta-arago-distro/recipes-core/images/tisdk-default-image.bb > >+++ b/meta-arago-distro/recipes-core/images/tisdk-default-image.bb > >@@ -47,3 +47,20 @@ IMAGE_INSTALL += "\ > > ${@bb.utils.contains('TUNE_FEATURES', 'armv7a', 'valgrind', '', d)} \ > > docker \ > > " > >+ > >+IMAGE_INSTALL:append:am62dxx = " \ > >+ pipewire \ > >+ pipewire-tools \ > >+ pipewire-alsa \ > >+ pipewire-pulse \ > >+ wireplumber \ > >+ speexdsp \ > >+ libpipewire \ > >+ pipewire-spa-plugins-meta \ > >+ pipewire-spa-tools \ > >+ pipewire-modules-meta \ > >+ pipewire-alsa-card-profile \ > >+ gstreamer1.0-pipewire \ > >+" > > I'm sure at some point we will want to push the "more modern" > pipewire to other boards as well. What is the reasoning for only > doing this on am62d? > > Please create a PIPEWIRE variable that contains the above list and then: > > IMAGE_INSTALL:append:am62dxx = " ${PIPEWIRE}" > > Also, for ease of looking up packages, please sort the list alphabetically. > > > >+PACKAGECONFIG:append:am62dxx:pn-pipewire = " pipewire-jack pipewire-modules pipewire-spa-plugins" Huh? pipewire-modules and pipewire-spa-plugins are not PACKAGECONFIGs, but packages... > >+PACKAGECONFIG:remove:am62dxx:pn-pipewire = " jack" No leading space is needed here. > Agree with Yogesh. This is not appropriate in this file. This > should be in a pipewire bbappend. Or rather generically in the distro config, as I suggested last week.
On 1/23/2026 11:01 AM, Denys Dmytriyenko wrote: > On Fri, Jan 23, 2026 at 10:11:06AM -0600, Ryan Eatmon wrote: >> >> >> On 1/23/2026 12:03 AM, Paresh Bhagat wrote: >>> Add pipewire and wireplumber audio stack support for am62dxx: >>> - Include pipewire core components and tools >>> - Add ALSA and PulseAudio compatibility layers >>> - Include wireplumber session manager >>> - Add GStreamer pipewire plugin >>> - Configure pipewire with proper modules and plugins >>> >>> Signed-off-by: Paresh Bhagat <p-bhagat@ti.com> >>> --- >>> .../recipes-core/images/tisdk-default-image.bb | 17 +++++++++++++++++ >>> 1 file changed, 17 insertions(+) >>> >>> diff --git a/meta-arago-distro/recipes-core/images/tisdk-default-image.bb b/meta-arago-distro/recipes-core/images/tisdk-default-image.bb >>> index 264d1b2d..d5db6fd4 100644 >>> --- a/meta-arago-distro/recipes-core/images/tisdk-default-image.bb >>> +++ b/meta-arago-distro/recipes-core/images/tisdk-default-image.bb >>> @@ -47,3 +47,20 @@ IMAGE_INSTALL += "\ >>> ${@bb.utils.contains('TUNE_FEATURES', 'armv7a', 'valgrind', '', d)} \ >>> docker \ >>> " >>> + >>> +IMAGE_INSTALL:append:am62dxx = " \ >>> + pipewire \ >>> + pipewire-tools \ >>> + pipewire-alsa \ >>> + pipewire-pulse \ >>> + wireplumber \ >>> + speexdsp \ >>> + libpipewire \ >>> + pipewire-spa-plugins-meta \ >>> + pipewire-spa-tools \ >>> + pipewire-modules-meta \ >>> + pipewire-alsa-card-profile \ >>> + gstreamer1.0-pipewire \ >>> +" >> >> I'm sure at some point we will want to push the "more modern" >> pipewire to other boards as well. What is the reasoning for only >> doing this on am62d? >> >> Please create a PIPEWIRE variable that contains the above list and then: >> >> IMAGE_INSTALL:append:am62dxx = " ${PIPEWIRE}" >> >> Also, for ease of looking up packages, please sort the list alphabetically. >> >> >>> +PACKAGECONFIG:append:am62dxx:pn-pipewire = " pipewire-jack pipewire-modules pipewire-spa-plugins" > > Huh? pipewire-modules and pipewire-spa-plugins are not PACKAGECONFIGs, but > packages... > > >>> +PACKAGECONFIG:remove:am62dxx:pn-pipewire = " jack" > > No leading space is needed here. > > >> Agree with Yogesh. This is not appropriate in this file. This >> should be in a pipewire bbappend. > > Or rather generically in the distro config, as I suggested last week. Good point.
diff --git a/meta-arago-distro/recipes-core/images/tisdk-default-image.bb b/meta-arago-distro/recipes-core/images/tisdk-default-image.bb index 264d1b2d..d5db6fd4 100644 --- a/meta-arago-distro/recipes-core/images/tisdk-default-image.bb +++ b/meta-arago-distro/recipes-core/images/tisdk-default-image.bb @@ -47,3 +47,20 @@ IMAGE_INSTALL += "\ ${@bb.utils.contains('TUNE_FEATURES', 'armv7a', 'valgrind', '', d)} \ docker \ " + +IMAGE_INSTALL:append:am62dxx = " \ + pipewire \ + pipewire-tools \ + pipewire-alsa \ + pipewire-pulse \ + wireplumber \ + speexdsp \ + libpipewire \ + pipewire-spa-plugins-meta \ + pipewire-spa-tools \ + pipewire-modules-meta \ + pipewire-alsa-card-profile \ + gstreamer1.0-pipewire \ +" +PACKAGECONFIG:append:am62dxx:pn-pipewire = " pipewire-jack pipewire-modules pipewire-spa-plugins" +PACKAGECONFIG:remove:am62dxx:pn-pipewire = " jack"
Add pipewire and wireplumber audio stack support for am62dxx: - Include pipewire core components and tools - Add ALSA and PulseAudio compatibility layers - Include wireplumber session manager - Add GStreamer pipewire plugin - Configure pipewire with proper modules and plugins Signed-off-by: Paresh Bhagat <p-bhagat@ti.com> --- .../recipes-core/images/tisdk-default-image.bb | 17 +++++++++++++++++ 1 file changed, 17 insertions(+)