| Message ID | 20260105222205.2503660-1-afd@ti.com |
|---|---|
| State | Under Review |
| Delegated to: | Ryan Eatmon |
| Headers | show |
| Series | [meta-arago,master,1/2] tisdk-default-image: Use core packagegroup to include valgrind | expand |
meta-arago / na / 20260105222205.2503660-1-afd PRC Results: PASS ========================================================= check-yocto-patches: PASS ========================================================= Patches ---------------------------------------- All patches passed ========================================================= apply-yocto-patch: PASS ========================================================= master ===================== Summary: - Patch Series: [meta-arago][master][PATCH 1/2] tisdk-default-image: Use core packagegroup to include valgrind - Submitter: From: Andrew Davis <afd@ti.com> - Date: Date: Mon, 5 Jan 2026 16:22:04 -0600 - Num Patches: 2 - Mailing List (public inbox) Commit SHA: 196cc6fcca1cccdac12fbed2302b1f8a28db5b94 Applied to: - Repository: lcpd-prc-meta-arago - Base Branch: master-wip - Commit Author: Ryan Eatmon <reatmon@ti.com> - Commit Subject: libdrm: Remove upstreamed patch - Commit SHA: 8c190b1e4f6a53ea641ba9d6150ef873f561c706 Patches ---------------------------------------- All patches applied ========================================================= check-yocto-repo: PASS ========================================================= master ===================== PASS ========================================================= yocto-check-layers: PASS ========================================================= master - PASS ===================== All checks passed
Build issue with this patch. Including that packagegroup includes the
lttng package which is a tracing tool. That code requires that the
kernel have CONFIG_TRACEPOINTS turned on to compile, but it is not
turned on for our kernels.
We need to resolve this issue before we can take this patch series.
scratch/builds/arago-master-wip/build/build/arago-tmp-default/work/am62pxx_evm-oe-linux/lttng-modules/2.14.3/sources/lttng-modules-2.14.3/src/lttng-tracepoint.c:
In function 'lttng_tracepoint_coming':
/scratch/builds/arago-master-wip/build/build/arago-tmp-default/work/am62pxx_evm-oe-linux/lttng-modules/2.14.3/sources/lttng-modules-2.14.3/src/lttng-tracepoint.c:227:36:
error: 'struct module' has no member named 'num_tracepoints'
227 | for (i = 0; i < tp_mod->mod->num_tracepoints; i++) {
| ^~
/scratch/builds/arago-master-wip/build/build/arago-tmp-default/work/am62pxx_evm-oe-linux/lttng-modules/2.14.3/sources/lttng-modules-2.14.3/src/lttng-tracepoint.c:232:61:
error: 'struct module' has no member named 'tracepoints_ptrs'
232 | tp =
lttng_tracepoint_ptr_deref(&tp_mod->mod->tracepoints_ptrs[i]);
| ^~
/scratch/builds/arago-master-wip/build/build/arago-tmp-default/work/am62pxx_evm-oe-linux/lttng-modules/2.14.3/sources/lttng-modules-2.14.3/src/lttng-tracepoint.c:
In function 'lttng_tracepoint_going':
/scratch/builds/arago-master-wip/build/build/arago-tmp-default/work/am62pxx_evm-oe-linux/lttng-modules/2.14.3/sources/lttng-modules-2.14.3/src/lttng-tracepoint.c:268:36:
error: 'struct module' has no member named 'num_tracepoints'
268 | for (i = 0; i < tp_mod->mod->num_tracepoints; i++) {
| ^~
/scratch/builds/arago-master-wip/build/build/arago-tmp-default/work/am62pxx_evm-oe-linux/lttng-modules/2.14.3/sources/lttng-modules-2.14.3/src/lttng-tracepoint.c:273:61:
error: 'struct module' has no member named 'tracepoints_ptrs'
273 | tp =
lttng_tracepoint_ptr_deref(&tp_mod->mod->tracepoints_ptrs[i]);
| ^~
On 1/5/2026 4:22 PM, Andrew Davis wrote:
> This packagegroup includes valgrind and handles the arch compatibility
> selection for us.
>
> Signed-off-by: Andrew Davis <afd@ti.com>
> ---
> meta-arago-distro/recipes-core/images/tisdk-default-image.bb | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta-arago-distro/recipes-core/images/tisdk-default-image.bb b/meta-arago-distro/recipes-core/images/tisdk-default-image.bb
> index bc067857..a35e8321 100644
> --- a/meta-arago-distro/recipes-core/images/tisdk-default-image.bb
> +++ b/meta-arago-distro/recipes-core/images/tisdk-default-image.bb
> @@ -34,12 +34,12 @@ DEVTOOLS = " \
> linux-libc-headers-dev \
> build-essential \
> packagegroup-core-tools-debug \
> + packagegroup-core-tools-profile \
> git \
> dtc \
> "
>
> IMAGE_INSTALL += "\
> ${DEVTOOLS} \
> - ${@bb.utils.contains('TUNE_FEATURES', 'armv7a', 'valgrind', '', d)} \
> docker \
> "
On 1/22/26 4:42 PM, Ryan Eatmon wrote: > > > Build issue with this patch. Including that packagegroup includes the lttng package which is a tracing tool. That code requires that the kernel have CONFIG_TRACEPOINTS turned on to compile, but it is not turned on for our kernels. > Looks like there was a fix for this, but it is not functioning as it should, https://git.openembedded.org/openembedded-core/tree/meta/recipes-kernel/lttng/lttng-modules/0001-src-Kbuild-change-missing-CONFIG_TRACEPOINTS-to-warn.patch > We need to resolve this issue before we can take this patch series. > > scratch/builds/arago-master-wip/build/build/arago-tmp-default/work/am62pxx_evm-oe-linux/lttng-modules/2.14.3/sources/lttng-modules-2.14.3/src/lttng-tracepoint.c: In function 'lttng_tracepoint_coming': > /scratch/builds/arago-master-wip/build/build/arago-tmp-default/work/am62pxx_evm-oe-linux/lttng-modules/2.14.3/sources/lttng-modules-2.14.3/src/lttng-tracepoint.c:227:36: error: 'struct module' has no member named 'num_tracepoints' > 227 | for (i = 0; i < tp_mod->mod->num_tracepoints; i++) { > | ^~ > /scratch/builds/arago-master-wip/build/build/arago-tmp-default/work/am62pxx_evm-oe-linux/lttng-modules/2.14.3/sources/lttng-modules-2.14.3/src/lttng-tracepoint.c:232:61: error: 'struct module' has no member named 'tracepoints_ptrs' > 232 | tp = lttng_tracepoint_ptr_deref(&tp_mod->mod->tracepoints_ptrs[i]); > | ^~ > /scratch/builds/arago-master-wip/build/build/arago-tmp-default/work/am62pxx_evm-oe-linux/lttng-modules/2.14.3/sources/lttng-modules-2.14.3/src/lttng-tracepoint.c: In function 'lttng_tracepoint_going': > /scratch/builds/arago-master-wip/build/build/arago-tmp-default/work/am62pxx_evm-oe-linux/lttng-modules/2.14.3/sources/lttng-modules-2.14.3/src/lttng-tracepoint.c:268:36: error: 'struct module' has no member named 'num_tracepoints' > 268 | for (i = 0; i < tp_mod->mod->num_tracepoints; i++) { > | ^~ > /scratch/builds/arago-master-wip/build/build/arago-tmp-default/work/am62pxx_evm-oe-linux/lttng-modules/2.14.3/sources/lttng-modules-2.14.3/src/lttng-tracepoint.c:273:61: error: 'struct module' has no member named 'tracepoints_ptrs' > 273 | tp = lttng_tracepoint_ptr_deref(&tp_mod->mod->tracepoints_ptrs[i]); > | ^~ > > > > > On 1/5/2026 4:22 PM, Andrew Davis wrote: >> This packagegroup includes valgrind and handles the arch compatibility >> selection for us. >> >> Signed-off-by: Andrew Davis <afd@ti.com> >> --- >> meta-arago-distro/recipes-core/images/tisdk-default-image.bb | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/meta-arago-distro/recipes-core/images/tisdk-default-image.bb b/meta-arago-distro/recipes-core/images/tisdk-default-image.bb >> index bc067857..a35e8321 100644 >> --- a/meta-arago-distro/recipes-core/images/tisdk-default-image.bb >> +++ b/meta-arago-distro/recipes-core/images/tisdk-default-image.bb >> @@ -34,12 +34,12 @@ DEVTOOLS = " \ >> linux-libc-headers-dev \ >> build-essential \ >> packagegroup-core-tools-debug \ >> + packagegroup-core-tools-profile \ >> git \ >> dtc \ >> " >> IMAGE_INSTALL += "\ >> ${DEVTOOLS} \ >> - ${@bb.utils.contains('TUNE_FEATURES', 'armv7a', 'valgrind', '', d)} \ >> docker \ >> " >
On 1/23/2026 3:30 PM, Andrew Davis wrote: > On 1/22/26 4:42 PM, Ryan Eatmon wrote: >> >> >> Build issue with this patch. Including that packagegroup includes the >> lttng package which is a tracing tool. That code requires that the >> kernel have CONFIG_TRACEPOINTS turned on to compile, but it is not >> turned on for our kernels. >> > > Looks like there was a fix for this, but it is not functioning as it > should, > > https://git.openembedded.org/openembedded-core/tree/meta/recipes-kernel/lttng/lttng-modules/0001-src-Kbuild-change-missing-CONFIG_TRACEPOINTS-to-warn.patch Sigh. ifdef CONFIG_LOCALVERSION # Check if dot-config is included. ifeq ($(CONFIG_TRACEPOINTS),) $(warning The option CONFIG_TRACEPOINTS needs to be enabled in your kernel configuration) DISABLE_MODULE = y endif # CONFIG_TRACEPOINTS endif # ifdef CONFIG_LOCALVERSION ifneq ($(DISABLE_MODULE),y) > grep CONFIG_LOCALVERSION .config CONFIG_LOCALVERSION="" CONFIG_LOCALVERSION_AUTO=y So the checking code doesn't kick in because CONFIG_LOCALVERSION is ""... Does the #ifdef return false if the variable is set to "" ? >> We need to resolve this issue before we can take this patch series. >> >> scratch/builds/arago-master-wip/build/build/arago-tmp-default/work/am62pxx_evm-oe-linux/lttng-modules/2.14.3/sources/lttng-modules-2.14.3/src/lttng-tracepoint.c: In function 'lttng_tracepoint_coming': >> /scratch/builds/arago-master-wip/build/build/arago-tmp-default/work/am62pxx_evm-oe-linux/lttng-modules/2.14.3/sources/lttng-modules-2.14.3/src/lttng-tracepoint.c:227:36: error: 'struct module' has no member named 'num_tracepoints' >> 227 | for (i = 0; i < tp_mod->mod->num_tracepoints; i++) { >> | ^~ >> /scratch/builds/arago-master-wip/build/build/arago-tmp-default/work/am62pxx_evm-oe-linux/lttng-modules/2.14.3/sources/lttng-modules-2.14.3/src/lttng-tracepoint.c:232:61: error: 'struct module' has no member named 'tracepoints_ptrs' >> 232 | tp = >> lttng_tracepoint_ptr_deref(&tp_mod->mod->tracepoints_ptrs[i]); >> | ^~ >> /scratch/builds/arago-master-wip/build/build/arago-tmp-default/work/am62pxx_evm-oe-linux/lttng-modules/2.14.3/sources/lttng-modules-2.14.3/src/lttng-tracepoint.c: In function 'lttng_tracepoint_going': >> /scratch/builds/arago-master-wip/build/build/arago-tmp-default/work/am62pxx_evm-oe-linux/lttng-modules/2.14.3/sources/lttng-modules-2.14.3/src/lttng-tracepoint.c:268:36: error: 'struct module' has no member named 'num_tracepoints' >> 268 | for (i = 0; i < tp_mod->mod->num_tracepoints; i++) { >> | ^~ >> /scratch/builds/arago-master-wip/build/build/arago-tmp-default/work/am62pxx_evm-oe-linux/lttng-modules/2.14.3/sources/lttng-modules-2.14.3/src/lttng-tracepoint.c:273:61: error: 'struct module' has no member named 'tracepoints_ptrs' >> 273 | tp = >> lttng_tracepoint_ptr_deref(&tp_mod->mod->tracepoints_ptrs[i]); >> | ^~ >> >> >> >> >> On 1/5/2026 4:22 PM, Andrew Davis wrote: >>> This packagegroup includes valgrind and handles the arch compatibility >>> selection for us. >>> >>> Signed-off-by: Andrew Davis <afd@ti.com> >>> --- >>> meta-arago-distro/recipes-core/images/tisdk-default-image.bb | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git >>> a/meta-arago-distro/recipes-core/images/tisdk-default-image.bb >>> b/meta-arago-distro/recipes-core/images/tisdk-default-image.bb >>> index bc067857..a35e8321 100644 >>> --- a/meta-arago-distro/recipes-core/images/tisdk-default-image.bb >>> +++ b/meta-arago-distro/recipes-core/images/tisdk-default-image.bb >>> @@ -34,12 +34,12 @@ DEVTOOLS = " \ >>> linux-libc-headers-dev \ >>> build-essential \ >>> packagegroup-core-tools-debug \ >>> + packagegroup-core-tools-profile \ >>> git \ >>> dtc \ >>> " >>> IMAGE_INSTALL += "\ >>> ${DEVTOOLS} \ >>> - ${@bb.utils.contains('TUNE_FEATURES', 'armv7a', 'valgrind', '', >>> d)} \ >>> docker \ >>> " >> >
On 1/23/26 4:26 PM, Ryan Eatmon wrote: > > > On 1/23/2026 3:30 PM, Andrew Davis wrote: >> On 1/22/26 4:42 PM, Ryan Eatmon wrote: >>> >>> >>> Build issue with this patch. Including that packagegroup includes the lttng package which is a tracing tool. That code requires that the kernel have CONFIG_TRACEPOINTS turned on to compile, but it is not turned on for our kernels. >>> >> >> Looks like there was a fix for this, but it is not functioning as it should, >> >> https://git.openembedded.org/openembedded-core/tree/meta/recipes-kernel/lttng/lttng-modules/0001-src-Kbuild-change-missing-CONFIG_TRACEPOINTS-to-warn.patch > > Sigh. > > ifdef CONFIG_LOCALVERSION # Check if dot-config is included. > ifeq ($(CONFIG_TRACEPOINTS),) > $(warning The option CONFIG_TRACEPOINTS needs to be enabled in your kernel configuration) > DISABLE_MODULE = y > endif # CONFIG_TRACEPOINTS > endif # ifdef CONFIG_LOCALVERSION > > ifneq ($(DISABLE_MODULE),y) > > > > grep CONFIG_LOCALVERSION .config > CONFIG_LOCALVERSION="" > CONFIG_LOCALVERSION_AUTO=y > > So the checking code doesn't kick in because CONFIG_LOCALVERSION is ""... > > Does the #ifdef return false if the variable is set to "" ? > > You would think it would still work, but yeah I noticed the same, I just removed the `ifdef CONFIG_LOCALVERSION` check altogether and the rest of the `ifeq` checks do still work as they should. Surprised this must have been broken upstream for a while now, either no one uses lttng-modules/lttng-tools, or everyone just uses a kernel with `TRACEPOINTS` set. (actually it seems our v6.12 kernel *does* have this set, the issue is also `CONFIG_KPROBES` must be set too, so even when we fix the LOCALVERSION thing, we will need to add `KPROBES` to the first check). > > >>> We need to resolve this issue before we can take this patch series. >>> >>> scratch/builds/arago-master-wip/build/build/arago-tmp-default/work/am62pxx_evm-oe-linux/lttng-modules/2.14.3/sources/lttng-modules-2.14.3/src/lttng-tracepoint.c: In function 'lttng_tracepoint_coming': >>> /scratch/builds/arago-master-wip/build/build/arago-tmp-default/work/am62pxx_evm-oe-linux/lttng-modules/2.14.3/sources/lttng-modules-2.14.3/src/lttng-tracepoint.c:227:36: error: 'struct module' has no member named 'num_tracepoints' >>> 227 | for (i = 0; i < tp_mod->mod->num_tracepoints; i++) { >>> | ^~ >>> /scratch/builds/arago-master-wip/build/build/arago-tmp-default/work/am62pxx_evm-oe-linux/lttng-modules/2.14.3/sources/lttng-modules-2.14.3/src/lttng-tracepoint.c:232:61: error: 'struct module' has no member named 'tracepoints_ptrs' >>> 232 | tp = lttng_tracepoint_ptr_deref(&tp_mod->mod->tracepoints_ptrs[i]); >>> | ^~ >>> /scratch/builds/arago-master-wip/build/build/arago-tmp-default/work/am62pxx_evm-oe-linux/lttng-modules/2.14.3/sources/lttng-modules-2.14.3/src/lttng-tracepoint.c: In function 'lttng_tracepoint_going': >>> /scratch/builds/arago-master-wip/build/build/arago-tmp-default/work/am62pxx_evm-oe-linux/lttng-modules/2.14.3/sources/lttng-modules-2.14.3/src/lttng-tracepoint.c:268:36: error: 'struct module' has no member named 'num_tracepoints' >>> 268 | for (i = 0; i < tp_mod->mod->num_tracepoints; i++) { >>> | ^~ >>> /scratch/builds/arago-master-wip/build/build/arago-tmp-default/work/am62pxx_evm-oe-linux/lttng-modules/2.14.3/sources/lttng-modules-2.14.3/src/lttng-tracepoint.c:273:61: error: 'struct module' has no member named 'tracepoints_ptrs' >>> 273 | tp = lttng_tracepoint_ptr_deref(&tp_mod->mod->tracepoints_ptrs[i]); >>> | ^~ >>> >>> >>> >>> >>> On 1/5/2026 4:22 PM, Andrew Davis wrote: >>>> This packagegroup includes valgrind and handles the arch compatibility >>>> selection for us. >>>> >>>> Signed-off-by: Andrew Davis <afd@ti.com> >>>> --- >>>> meta-arago-distro/recipes-core/images/tisdk-default-image.bb | 2 +- >>>> 1 file changed, 1 insertion(+), 1 deletion(-) >>>> >>>> diff --git a/meta-arago-distro/recipes-core/images/tisdk-default-image.bb b/meta-arago-distro/recipes-core/images/tisdk-default-image.bb >>>> index bc067857..a35e8321 100644 >>>> --- a/meta-arago-distro/recipes-core/images/tisdk-default-image.bb >>>> +++ b/meta-arago-distro/recipes-core/images/tisdk-default-image.bb >>>> @@ -34,12 +34,12 @@ DEVTOOLS = " \ >>>> linux-libc-headers-dev \ >>>> build-essential \ >>>> packagegroup-core-tools-debug \ >>>> + packagegroup-core-tools-profile \ >>>> git \ >>>> dtc \ >>>> " >>>> IMAGE_INSTALL += "\ >>>> ${DEVTOOLS} \ >>>> - ${@bb.utils.contains('TUNE_FEATURES', 'armv7a', 'valgrind', '', d)} \ >>>> docker \ >>>> " >>> >> >
diff --git a/meta-arago-distro/recipes-core/images/tisdk-default-image.bb b/meta-arago-distro/recipes-core/images/tisdk-default-image.bb index bc067857..a35e8321 100644 --- a/meta-arago-distro/recipes-core/images/tisdk-default-image.bb +++ b/meta-arago-distro/recipes-core/images/tisdk-default-image.bb @@ -34,12 +34,12 @@ DEVTOOLS = " \ linux-libc-headers-dev \ build-essential \ packagegroup-core-tools-debug \ + packagegroup-core-tools-profile \ git \ dtc \ " IMAGE_INSTALL += "\ ${DEVTOOLS} \ - ${@bb.utils.contains('TUNE_FEATURES', 'armv7a', 'valgrind', '', d)} \ docker \ "
This packagegroup includes valgrind and handles the arch compatibility selection for us. Signed-off-by: Andrew Davis <afd@ti.com> --- meta-arago-distro/recipes-core/images/tisdk-default-image.bb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)