diff mbox series

[meta-arago,scarthgap] nnshark: Set missing PV

Message ID 20251119215228.185294-1-reatmon@ti.com
State New
Headers show
Series [meta-arago,scarthgap] nnshark: Set missing PV | expand

Commit Message

Ryan Eatmon Nov. 19, 2025, 9:52 p.m. UTC
Based on the git repo, the latest tag was v0.6.1 and then some
additional commits in git.  So tag the current PV to 0.6.1+git.

Signed-off-by: Ryan Eatmon <reatmon@ti.com>
---
 meta-arago-extras/recipes-multimedia/nnshark/nnshark_git.bb | 2 ++
 1 file changed, 2 insertions(+)

Comments

PRC Automation Nov. 19, 2025, 10:13 p.m. UTC | #1
meta-arago / na / 20251119215228.185294-1-reatmon

PRC Results: PASS

=========================================================
  check-yocto-patches: PASS
=========================================================
Patches
----------------------------------------
All patches passed



=========================================================
  apply-yocto-patch: PASS
=========================================================
scarthgap
=====================
Summary:
- Patch Series: [meta-arago][scarthgap][PATCH] nnshark: Set missing PV
- Submitter: From: Ryan Eatmon <reatmon@ti.com>
- Date: Date: Wed, 19 Nov 2025 15:52:28 -0600
- Num Patches: 1
- Mailing List (public inbox) Commit SHA: 028c4ca44a777e72909836163b30e4935b1075dd

Applied to:
- Repository: lcpd-prc-meta-arago
- Base Branch: scarthgap-next
- Commit Author: LCPD Automation Script <lcpdbld@list.ti.com>
- Commit Subject: CI/CD Auto-Merger: cicd.scarthgap.202511190400
- Commit SHA: c273081b9e50cd3d742cbaae1e78a8439d6ff710

Patches
----------------------------------------
All patches applied



=========================================================
  check-yocto-repo: PASS
=========================================================
scarthgap
=====================
PASS



=========================================================
  yocto-check-layers: PASS
=========================================================
scarthgap - PASS
=====================
All checks passed
Andrew Davis Nov. 20, 2025, 4:09 p.m. UTC | #2
On 11/19/25 3:52 PM, Ryan Eatmon via lists.yoctoproject.org wrote:
> Based on the git repo, the latest tag was v0.6.1 and then some
> additional commits in git.  So tag the current PV to 0.6.1+git.
> 
> Signed-off-by: Ryan Eatmon <reatmon@ti.com>
> ---
>   meta-arago-extras/recipes-multimedia/nnshark/nnshark_git.bb | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/meta-arago-extras/recipes-multimedia/nnshark/nnshark_git.bb b/meta-arago-extras/recipes-multimedia/nnshark/nnshark_git.bb
> index 505aaa4c..89be15f5 100644
> --- a/meta-arago-extras/recipes-multimedia/nnshark/nnshark_git.bb
> +++ b/meta-arago-extras/recipes-multimedia/nnshark/nnshark_git.bb
> @@ -5,6 +5,8 @@ LICENSE = "GPL-2.0-only & LGPL-2.1-only"
>   LIC_FILES_CHKSUM = "file://COPYING;md5=e1caa368743492879002ad032445fa97 \
>                       file://COPYING.LESSER;md5=66c40c88533cd228b5b85936709801c8"
>   
> +PV = "0.6.1+git"
> +

That tag was 6 years ago, same issue for Coremark in that other thread,
seems some projects just gave up on doing tagged releases. I wonder at
what point the "version" stops making sense and we should fallback to
only the git sha? Oh well, problem for another time,

Reviewed-by: Andrew Davis <afd@ti.com>

>   SRC_URI = "git://github.com/nnstreamer/nnshark.git;protocol=https;branch=master;name=nnshark \
>              git://github.com/GStreamer/common.git;protocol=https;branch=master;name=common;subdir=${S}/common \
>   "
Ryan Eatmon Nov. 20, 2025, 4:13 p.m. UTC | #3
On 11/20/2025 10:09 AM, Andrew Davis wrote:
> On 11/19/25 3:52 PM, Ryan Eatmon via lists.yoctoproject.org wrote:
>> Based on the git repo, the latest tag was v0.6.1 and then some
>> additional commits in git.  So tag the current PV to 0.6.1+git.
>>
>> Signed-off-by: Ryan Eatmon <reatmon@ti.com>
>> ---
>>   meta-arago-extras/recipes-multimedia/nnshark/nnshark_git.bb | 2 ++
>>   1 file changed, 2 insertions(+)
>>
>> diff --git 
>> a/meta-arago-extras/recipes-multimedia/nnshark/nnshark_git.bb 
>> b/meta-arago-extras/recipes-multimedia/nnshark/nnshark_git.bb
>> index 505aaa4c..89be15f5 100644
>> --- a/meta-arago-extras/recipes-multimedia/nnshark/nnshark_git.bb
>> +++ b/meta-arago-extras/recipes-multimedia/nnshark/nnshark_git.bb
>> @@ -5,6 +5,8 @@ LICENSE = "GPL-2.0-only & LGPL-2.1-only"
>>   LIC_FILES_CHKSUM = 
>> "file://COPYING;md5=e1caa368743492879002ad032445fa97 \
>>                       
>> file://COPYING.LESSER;md5=66c40c88533cd228b5b85936709801c8"
>> +PV = "0.6.1+git"
>> +
> 
> That tag was 6 years ago, same issue for Coremark in that other thread,
> seems some projects just gave up on doing tagged releases. I wonder at
> what point the "version" stops making sense and we should fallback to
> only the git sha? Oh well, problem for another time,

Generally I would agree, but if the tag was six years ago and the last 
commit was three years ago...  So all in all it feels like a dead project.

> Reviewed-by: Andrew Davis <afd@ti.com>
> 
>>   SRC_URI = 
>> "git://github.com/nnstreamer/nnshark.git;protocol=https;branch=master;name=nnshark \
>>              
>> git://github.com/GStreamer/common.git;protocol=https;branch=master;name=common;subdir=${S}/common \
>>   "
>
diff mbox series

Patch

diff --git a/meta-arago-extras/recipes-multimedia/nnshark/nnshark_git.bb b/meta-arago-extras/recipes-multimedia/nnshark/nnshark_git.bb
index 505aaa4c..89be15f5 100644
--- a/meta-arago-extras/recipes-multimedia/nnshark/nnshark_git.bb
+++ b/meta-arago-extras/recipes-multimedia/nnshark/nnshark_git.bb
@@ -5,6 +5,8 @@  LICENSE = "GPL-2.0-only & LGPL-2.1-only"
 LIC_FILES_CHKSUM = "file://COPYING;md5=e1caa368743492879002ad032445fa97 \
                     file://COPYING.LESSER;md5=66c40c88533cd228b5b85936709801c8"
 
+PV = "0.6.1+git"
+
 SRC_URI = "git://github.com/nnstreamer/nnshark.git;protocol=https;branch=master;name=nnshark \
            git://github.com/GStreamer/common.git;protocol=https;branch=master;name=common;subdir=${S}/common \
 "