diff mbox series

[meta-rockchip] rk3288: use u-boot.itb as bootloader image

Message ID 20251102132931.228967-1-mustela@erminea.space
State New
Headers show
Series [meta-rockchip] rk3288: use u-boot.itb as bootloader image | expand

Commit Message

Peter Shkenev Nov. 2, 2025, 1:29 p.m. UTC
Currently, u-boot.bin is used for supported rk3288-based boards. But, as
U-Boot for those boards gets built without OP-TEE, u-boot.bin is a raw
image, and, since raw images support for those boards is disabled as
well, u-boot will fail to boot.

Fix this by using u-boot.itb for supported rk3288 boards, which is a FIT
image.

Signed-off-by: Peter Shkenev <mustela@erminea.space>
---
 conf/machine/include/rk3288.inc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Quentin Schulz Nov. 3, 2025, 1:31 p.m. UTC | #1
Hi Peter,

On 11/2/25 2:29 PM, Peter Shkenev via lists.yoctoproject.org wrote:
> [You don't often get email from mustela=erminea.space@lists.yoctoproject.org. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ]
> 
> Currently, u-boot.bin is used for supported rk3288-based boards. But, as
> U-Boot for those boards gets built without OP-TEE, u-boot.bin is a raw
> image, and, since raw images support for those boards is disabled as
> well, u-boot will fail to boot.
> 
> Fix this by using u-boot.itb for supported rk3288 boards, which is a FIT
> image.
> 

rock2_defconfig used for the rock2-square machine doesn't build (nor 
supports booting U-Boot proper from) a FIT image. Same can be said for 
the Amarula Vyasa RK3288, so this would break the build for them.

Please build U-Boot for all RK3288 to see if it works (I didn't, but 
reading their defconfig was enough to know this will be an issue).

This change *could* be fine if it was accompanied by the necessary 
changes for the boards that cannot boot the .itb image to change their 
UBOOT_SUFFIX as well, to .img as thats what we build now (c.f. 
u-boot-img node instead of fit in arch/arm/dts/rockchip-u-boot.dtsi, and 
tools/binman/entries.rst).

You can also add a comment stating this needs to be itb if 
SPL_OPTEE_IMAGE and SPL_FIT are set in the .config, otherwise img.

On a side note, I think it should be possible to migrate away from 
classes/rockchip-gpt-img.bbclass to wks/wic and upstream U-Boot. Not 
something you need to do though.

Cheers,
Quentin
diff mbox series

Patch

diff --git a/conf/machine/include/rk3288.inc b/conf/machine/include/rk3288.inc
index a648b44..a1e5d06 100644
--- a/conf/machine/include/rk3288.inc
+++ b/conf/machine/include/rk3288.inc
@@ -13,6 +13,6 @@  SERIAL_CONSOLES = "115200;ttyS2"
 KBUILD_DEFCONFIG ?= "multi_v7_defconfig"
 KERNEL_FEATURES:append:rk3288 = " bsp/rockchip/remove-non-rockchip-arch-arm.scc"
 
-UBOOT_SUFFIX ?= "bin"
+UBOOT_SUFFIX ?= "itb"
 
 ENABLE_STATELESS_VPU_GST ?= "1"