| Message ID | 20251027230722.524532-1-contact@schnwalter.eu |
|---|---|
| State | New |
| Headers | show |
| Series | [meta-rockchip,v2] rock-pi-4b-plus: add | expand |
Hi Walter, On 10/28/25 12:06 AM, Walter Werner SCHNEIDER via lists.yoctoproject.org wrote: > [You don't often get email from contact=schnwalter.eu@lists.yoctoproject.org. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ] > > Signed-off-by: Walter Werner SCHNEIDER <contact@schnwalter.eu> > --- > conf/machine/rock-pi-4b-plus.conf | 9 +++++++++ > 1 file changed, 9 insertions(+) > create mode 100644 conf/machine/rock-pi-4b-plus.conf > > diff --git a/conf/machine/rock-pi-4b-plus.conf b/conf/machine/rock-pi-4b-plus.conf > new file mode 100644 > index 0000000..9a5117b > --- /dev/null > +++ b/conf/machine/rock-pi-4b-plus.conf > @@ -0,0 +1,9 @@ > +#@TYPE: Machine > +#@NAME: Radxa Rock 4B+ RK3399 It's an OP1, not an RK3399 :) (essentially an "overclocked" RK3399) > +#@DESCRIPTION: An RK3399 SBC with Wi-Fi 5 & BT 5 and PoE Support. Ditto. > +#https://docs.radxa.com/en/rock4/rock4ab-se > + > +require conf/machine/include/rock-pi-4.inc > + > +KERNEL_DEVICETREE = "rockchip/rk3399-rock-pi-4b-plus.dtb" > +UBOOT_MACHINE = "rock-pi-4-rk3399_defconfig" > This configures U-Boot for the Rock 4A actually, c.f. https://elixir.bootlin.com/u-boot/v2025.10/source/configs/rock-4c-plus-rk3399_defconfig#L8 and https://elixir.bootlin.com/u-boot/v2025.10/source/configs/rock-pi-4-rk3399_defconfig Considering the only differences (according to the Linux kernel device tree) are the presence of a WiFi+BT combo chip and being based on an OP1 rather than an RK3399 (OPPs differ, the rest stays the same apparently; doesn't matter to U-Boot), and that Rock 4B is supported the same way in conf/machine/rock-pi-4b.conf, I guess this is fine :) It would have been nice if we could detect which board of the Rock 4 series we are running U-Boot on at runtime so only one Yocto machine would be needed to support all... But checking the SARADC on 4A, 4A+, 4B and 4B+, they cannot be identified like that sadly. Can you please update the supported list in the README to add this new board? With that, Reviewed-by: Quentin Schulz <quentin.schulz@cherry.de> Thanks! Quentin
diff --git a/conf/machine/rock-pi-4b-plus.conf b/conf/machine/rock-pi-4b-plus.conf new file mode 100644 index 0000000..9a5117b --- /dev/null +++ b/conf/machine/rock-pi-4b-plus.conf @@ -0,0 +1,9 @@ +#@TYPE: Machine +#@NAME: Radxa Rock 4B+ RK3399 +#@DESCRIPTION: An RK3399 SBC with Wi-Fi 5 & BT 5 and PoE Support. +#https://docs.radxa.com/en/rock4/rock4ab-se + +require conf/machine/include/rock-pi-4.inc + +KERNEL_DEVICETREE = "rockchip/rk3399-rock-pi-4b-plus.dtb" +UBOOT_MACHINE = "rock-pi-4-rk3399_defconfig"
Signed-off-by: Walter Werner SCHNEIDER <contact@schnwalter.eu> --- conf/machine/rock-pi-4b-plus.conf | 9 +++++++++ 1 file changed, 9 insertions(+) create mode 100644 conf/machine/rock-pi-4b-plus.conf