Message ID | 20250926061054.1868481-1-yi.zhao@windriver.com |
---|---|
State | New |
Headers | show |
Series | [meta-security] libmhash: fix build with gcc 15 | expand |
On Fri, 26 Sep 2025, Yi Zhao wrote: > GCC 15 switched to C23 by default, which libmhash does not yet support. > So keep using C17. Nothing in meta-security actually uses libmhash at the moment, so I'm curious if you have a usecase for using it standalone? It used to be pulled in by the aide recipe via PACKAGECONFIG, but Armin disabled that last year with a note that newer releases will drop using it. So my plan is to take this patch, but unless you can confirm you need the libmhash recipe for something, we will drop it when aide is updated, which I intend to do soon. Thanks, Scott > Signed-off-by: Yi Zhao <yi.zhao@windriver.com> > --- > recipes-security/libmhash/libmhash_0.9.9.9.bb | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/recipes-security/libmhash/libmhash_0.9.9.9.bb b/recipes-security/libmhash/libmhash_0.9.9.9.bb > index f5518d2..805cf05 100644 > --- a/recipes-security/libmhash/libmhash_0.9.9.9.bb > +++ b/recipes-security/libmhash/libmhash_0.9.9.9.bb > @@ -25,6 +25,8 @@ SRC_URI[sha256sum] = "56521c52a9033779154432d0ae47ad7198914785265e1f570cee21ab24 > > inherit autotools-brokensep ptest multilib_header > > +CFLAGS += "-std=gnu17" > + > do_install:append() { > oe_multilib_header mutils/mhash_config.h > } >
On 9/27/25 01:19, Scott Murray wrote: > On Fri, 26 Sep 2025, Yi Zhao wrote: > >> GCC 15 switched to C23 by default, which libmhash does not yet support. >> So keep using C17. > Nothing in meta-security actually uses libmhash at the moment, so I'm > curious if you have a usecase for using it standalone? It used to be > pulled in by the aide recipe via PACKAGECONFIG, but Armin disabled that > last year with a note that newer releases will drop using it. So my plan > is to take this patch, but unless you can confirm you need the libmhash > recipe for something, we will drop it when aide is updated, which I > intend to do soon. Looking through our project, we don't use it either. So I'm fine with that, you can drop it. Thanks, Yi > > Thanks, > > Scott > > >> Signed-off-by: Yi Zhao <yi.zhao@windriver.com> >> --- >> recipes-security/libmhash/libmhash_0.9.9.9.bb | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/recipes-security/libmhash/libmhash_0.9.9.9.bb b/recipes-security/libmhash/libmhash_0.9.9.9.bb >> index f5518d2..805cf05 100644 >> --- a/recipes-security/libmhash/libmhash_0.9.9.9.bb >> +++ b/recipes-security/libmhash/libmhash_0.9.9.9.bb >> @@ -25,6 +25,8 @@ SRC_URI[sha256sum] = "56521c52a9033779154432d0ae47ad7198914785265e1f570cee21ab24 >> >> inherit autotools-brokensep ptest multilib_header >> >> +CFLAGS += "-std=gnu17" >> + >> do_install:append() { >> oe_multilib_header mutils/mhash_config.h >> } >>
diff --git a/recipes-security/libmhash/libmhash_0.9.9.9.bb b/recipes-security/libmhash/libmhash_0.9.9.9.bb index f5518d2..805cf05 100644 --- a/recipes-security/libmhash/libmhash_0.9.9.9.bb +++ b/recipes-security/libmhash/libmhash_0.9.9.9.bb @@ -25,6 +25,8 @@ SRC_URI[sha256sum] = "56521c52a9033779154432d0ae47ad7198914785265e1f570cee21ab24 inherit autotools-brokensep ptest multilib_header +CFLAGS += "-std=gnu17" + do_install:append() { oe_multilib_header mutils/mhash_config.h }
GCC 15 switched to C23 by default, which libmhash does not yet support. So keep using C17. Signed-off-by: Yi Zhao <yi.zhao@windriver.com> --- recipes-security/libmhash/libmhash_0.9.9.9.bb | 2 ++ 1 file changed, 2 insertions(+)