Message ID | 20250925074624.ozym2jd6qlxczwtr@yogi-work-pc |
---|---|
State | Accepted |
Delegated to: | Ryan Eatmon |
Headers | show |
Series | [meta-arago,master/scarthgap,v2] packagegroup-arago-tisdk-connectivity: Restrict BT_TI to legacy platforms | expand |
meta-arago / na / 20250925074624.ozym2jd6qlxczwtr PRC Results: PASS ========================================================= check-yocto-patches: PASS ========================================================= Patches ---------------------------------------- WARN - [meta-arago][master/scarthgap][PATCH v2] packagegroup-arago-tisdk-connectivity: Restrict BT_TI to legacy platforms WARN: Commit message does not include file/recipe name: . (COMMIT-MESSAGE-2) patch ========================================================= apply-yocto-patch: PASS ========================================================= master ===================== Summary: - Patch Series: [meta-arago][master/scarthgap][PATCH v2] packagegroup-arago-tisdk-connectivity: Restrict BT_TI to legacy platforms - Submitter: From: Yogesh Hegde <y-hegde@ti.com> - Date: Date: Thu, 25 Sep 2025 13:16:24 +0530 - Num Patches: 1 - Mailing List (public inbox) Commit SHA: 1160f033276e999e2ca086732fb1b9f2d3e6cbb4 Applied to: - Repository: lcpd-prc-meta-arago - Base Branch: master-wip - Commit Author: Ryan Eatmon <reatmon@ti.com> - Commit Subject: ti-test: Make opencl-cts dependent on DISTRO_FEATURES - Commit SHA: d3532063218f5c47b5e912554a0b236eb25e61f4 Patches ---------------------------------------- All patches applied scarthgap ===================== Summary: - Patch Series: [meta-arago][master/scarthgap][PATCH v2] packagegroup-arago-tisdk-connectivity: Restrict BT_TI to legacy platforms - Submitter: From: Yogesh Hegde <y-hegde@ti.com> - Date: Date: Thu, 25 Sep 2025 13:16:24 +0530 - Num Patches: 1 - Mailing List (public inbox) Commit SHA: 1160f033276e999e2ca086732fb1b9f2d3e6cbb4 Applied to: - Repository: lcpd-prc-meta-arago - Base Branch: scarthgap-wip - Commit Author: Ryan Eatmon <reatmon@ti.com> - Commit Subject: check_yocto_rules: Flip to regex for files - Commit SHA: 7aedd68536e2fdc3f84579560e8c5a99c98a12d0 Patches ---------------------------------------- All patches applied ========================================================= check-yocto-repo: PASS ========================================================= master ===================== PASS scarthgap ===================== PASS
On 9/25/25 2:46 AM, Yogesh Hegde via lists.yoctoproject.org wrote: > The bt-enable and bt-fw packages are only applicable for AM33X, AM43X and AM57XX > legacy platforms, but was being included for all machines. While the > bt-enable script performs noop for unsupported machines, it still adds > unnecessary overhead to boot time and generates log noise. > > Restrict the bt-enable and bt-fw packages to only be included for the > specific machine overrides (ti33x, ti43x, am57xx) that actually require > Bluetooth enablement support. Do these scripts even work anymore? They look to use the old GPIO_SYSFS to toggle some GPIO bits, we don't enable that in our kernels anymore. Might be better to just drop these recipes completely. Andrew > > Signed-off-by: Yogesh Hegde <y-hegde@ti.com> > --- > v2: > - Improved the subject as suggested by Ryan > - Implemented the change to use CONNECTIVITY_RDEPENDS instead of BT_TI > variable as suggested by Ryan > > .../packagegroups/packagegroup-arago-tisdk-connectivity.bb | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-connectivity.bb b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-connectivity.bb > index 5a91357b..0a8d4493 100644 > --- a/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-connectivity.bb > +++ b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-connectivity.bb > @@ -63,9 +63,12 @@ CONNECTIVITY_RDEPENDS = " \ > ${WLAN_COMMON} \ > ${WLAN_TI} \ > ${BT_COMMON} \ > - ${BT_TI} \ > " > > +CONNECTIVITY_RDEPENDS:append:ti33x = " ${BT_TI}" > +CONNECTIVITY_RDEPENDS:append:ti43x = " ${BT_TI}" > +CONNECTIVITY_RDEPENDS:append:am57xx = " ${BT_TI}" > + > RDEPENDS:${PN} = "\ > ${CONNECTIVITY_RDEPENDS} \ > "
diff --git a/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-connectivity.bb b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-connectivity.bb index 5a91357b..0a8d4493 100644 --- a/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-connectivity.bb +++ b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-connectivity.bb @@ -63,9 +63,12 @@ CONNECTIVITY_RDEPENDS = " \ ${WLAN_COMMON} \ ${WLAN_TI} \ ${BT_COMMON} \ - ${BT_TI} \ " +CONNECTIVITY_RDEPENDS:append:ti33x = " ${BT_TI}" +CONNECTIVITY_RDEPENDS:append:ti43x = " ${BT_TI}" +CONNECTIVITY_RDEPENDS:append:am57xx = " ${BT_TI}" + RDEPENDS:${PN} = "\ ${CONNECTIVITY_RDEPENDS} \ "
The bt-enable and bt-fw packages are only applicable for AM33X, AM43X and AM57XX legacy platforms, but was being included for all machines. While the bt-enable script performs noop for unsupported machines, it still adds unnecessary overhead to boot time and generates log noise. Restrict the bt-enable and bt-fw packages to only be included for the specific machine overrides (ti33x, ti43x, am57xx) that actually require Bluetooth enablement support. Signed-off-by: Yogesh Hegde <y-hegde@ti.com> --- v2: - Improved the subject as suggested by Ryan - Implemented the change to use CONNECTIVITY_RDEPENDS instead of BT_TI variable as suggested by Ryan .../packagegroups/packagegroup-arago-tisdk-connectivity.bb | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)