diff mbox series

[meta-arago,scarthgap,v1,1/2] libsdl2: Add tests package

Message ID 20250917220826.2078836-2-a-christidis@ti.com
State Superseded
Delegated to: Ryan Eatmon
Headers show
Series Add libsdl2 test support | expand

Commit Message

Antonios Christidis Sept. 17, 2025, 10:08 p.m. UTC 
From: Antonios Christidis <a-christidis@ti.com>

The software provides tests, configure cmake to build and install them.
Package the tests in -tests package.

Signed-off-by: Antonios Christidis <a-christidis@ti.com>
---
 meta-arago-test/recipes-graphics/libsdl2/libsdl2-ti.inc     | 5 +++++
 meta-arago-test/recipes-graphics/libsdl2/libsdl2_%.bbappend | 4 ++++
 2 files changed, 9 insertions(+)
 create mode 100644 meta-arago-test/recipes-graphics/libsdl2/libsdl2-ti.inc
 create mode 100644 meta-arago-test/recipes-graphics/libsdl2/libsdl2_%.bbappend

Comments

Ryan Eatmon Sept. 18, 2025, 1:51 p.m. UTC | #1 
On 9/17/2025 5:08 PM, a-christidis@ti.com wrote:
> From: Antonios Christidis <a-christidis@ti.com>
> 
> The software provides tests, configure cmake to build and install them.
> Package the tests in -tests package.
> 
> Signed-off-by: Antonios Christidis <a-christidis@ti.com>
> ---
>   meta-arago-test/recipes-graphics/libsdl2/libsdl2-ti.inc     | 5 +++++
>   meta-arago-test/recipes-graphics/libsdl2/libsdl2_%.bbappend | 4 ++++
>   2 files changed, 9 insertions(+)
>   create mode 100644 meta-arago-test/recipes-graphics/libsdl2/libsdl2-ti.inc
>   create mode 100644 meta-arago-test/recipes-graphics/libsdl2/libsdl2_%.bbappend
> 
> diff --git a/meta-arago-test/recipes-graphics/libsdl2/libsdl2-ti.inc b/meta-arago-test/recipes-graphics/libsdl2/libsdl2-ti.inc
> new file mode 100644
> index 00000000..12e06295
> --- /dev/null
> +++ b/meta-arago-test/recipes-graphics/libsdl2/libsdl2-ti.inc
> @@ -0,0 +1,5 @@
> +EXTRA_OECMAKE:append = " -DSDL_TESTS=ON \
> +                         -DSDL_INSTALL_TESTS=ON \
> +                       "
> +PACKAGE_BEFORE_PN = "${PN}-tests"
> +FILES:${PN}-tests += "${libexecdir} /usr/share/installed-tests/SDL2"


I'm getting QA errors related to nativesdk-libsdl2.  I had to change the 
above line to this:

FILES:${PN}-tests:append = " ${datadir}/installed-tests/SDL2"
FILES:${PN}-tests:append:class-nativesdk = " 
${datadir}/installed-tests/SDL2"

The libexecdir was not needed, and I changed the /usr/share to use the 
correct variable (datadir) in case someone wants to change the directory 
names in the Yocto manner.  I moved to append just so that the two lines 
looked the same.

I know this is also being submitted upstream, so these changes might be 
needed for those patches as well.


> diff --git a/meta-arago-test/recipes-graphics/libsdl2/libsdl2_%.bbappend b/meta-arago-test/recipes-graphics/libsdl2/libsdl2_%.bbappend
> new file mode 100644
> index 00000000..385aa801
> --- /dev/null
> +++ b/meta-arago-test/recipes-graphics/libsdl2/libsdl2_%.bbappend
> @@ -0,0 +1,4 @@
> +LIBSDL2_TI = ""
> +LIBSDL2_TI:ti-soc = "libsdl2-ti.inc"
> +
> +require ${LIBSDL2_TI}
Antonios Christidis Sept. 19, 2025, 7:06 p.m. UTC | #2 
Dear Ryan,


Thank you for the help and guidance for the fix ! Gonna send a v2 fixing 
the native-sdk issue.

${libexecdir} is needed tho, otherwise the test binaries will be 
packaged within the "libsdl2" package and not "libsdl2-tests" package.


Kind Regards,
Antonios

On 9/18/25 8:51 AM, Ryan Eatmon wrote:
>
>
> On 9/17/2025 5:08 PM, a-christidis@ti.com wrote:
>> From: Antonios Christidis <a-christidis@ti.com>
>>
>> The software provides tests, configure cmake to build and install them.
>> Package the tests in -tests package.
>>
>> Signed-off-by: Antonios Christidis <a-christidis@ti.com>
>> ---
>>   meta-arago-test/recipes-graphics/libsdl2/libsdl2-ti.inc     | 5 +++++
>>   meta-arago-test/recipes-graphics/libsdl2/libsdl2_%.bbappend | 4 ++++
>>   2 files changed, 9 insertions(+)
>>   create mode 100644 
>> meta-arago-test/recipes-graphics/libsdl2/libsdl2-ti.inc
>>   create mode 100644 
>> meta-arago-test/recipes-graphics/libsdl2/libsdl2_%.bbappend
>>
>> diff --git a/meta-arago-test/recipes-graphics/libsdl2/libsdl2-ti.inc 
>> b/meta-arago-test/recipes-graphics/libsdl2/libsdl2-ti.inc
>> new file mode 100644
>> index 00000000..12e06295
>> --- /dev/null
>> +++ b/meta-arago-test/recipes-graphics/libsdl2/libsdl2-ti.inc
>> @@ -0,0 +1,5 @@
>> +EXTRA_OECMAKE:append = " -DSDL_TESTS=ON \
>> +                         -DSDL_INSTALL_TESTS=ON \
>> +                       "
>> +PACKAGE_BEFORE_PN = "${PN}-tests"
>> +FILES:${PN}-tests += "${libexecdir} /usr/share/installed-tests/SDL2"
>
>
> I'm getting QA errors related to nativesdk-libsdl2.  I had to change 
> the above line to this:
>
> FILES:${PN}-tests:append = " ${datadir}/installed-tests/SDL2"
> FILES:${PN}-tests:append:class-nativesdk = " 
> ${datadir}/installed-tests/SDL2"
>
> The libexecdir was not needed, and I changed the /usr/share to use the 
> correct variable (datadir) in case someone wants to change the 
> directory names in the Yocto manner.  I moved to append just so that 
> the two lines looked the same.
>
> I know this is also being submitted upstream, so these changes might 
> be needed for those patches as well.
>
>
>> diff --git 
>> a/meta-arago-test/recipes-graphics/libsdl2/libsdl2_%.bbappend 
>> b/meta-arago-test/recipes-graphics/libsdl2/libsdl2_%.bbappend
>> new file mode 100644
>> index 00000000..385aa801
>> --- /dev/null
>> +++ b/meta-arago-test/recipes-graphics/libsdl2/libsdl2_%.bbappend
>> @@ -0,0 +1,4 @@
>> +LIBSDL2_TI = ""
>> +LIBSDL2_TI:ti-soc = "libsdl2-ti.inc"
>> +
>> +require ${LIBSDL2_TI}
>
Denys Dmytriyenko Sept. 19, 2025, 7:54 p.m. UTC | #3 
On Thu, Sep 18, 2025 at 08:51:53AM -0500, Ryan Eatmon via lists.yoctoproject.org wrote:
> 
> 
> On 9/17/2025 5:08 PM, a-christidis@ti.com wrote:
> >From: Antonios Christidis <a-christidis@ti.com>
> >
> >The software provides tests, configure cmake to build and install them.
> >Package the tests in -tests package.
> >
> >Signed-off-by: Antonios Christidis <a-christidis@ti.com>
> >---
> >  meta-arago-test/recipes-graphics/libsdl2/libsdl2-ti.inc     | 5 +++++
> >  meta-arago-test/recipes-graphics/libsdl2/libsdl2_%.bbappend | 4 ++++
> >  2 files changed, 9 insertions(+)
> >  create mode 100644 meta-arago-test/recipes-graphics/libsdl2/libsdl2-ti.inc
> >  create mode 100644 meta-arago-test/recipes-graphics/libsdl2/libsdl2_%.bbappend
> >
> >diff --git a/meta-arago-test/recipes-graphics/libsdl2/libsdl2-ti.inc b/meta-arago-test/recipes-graphics/libsdl2/libsdl2-ti.inc
> >new file mode 100644
> >index 00000000..12e06295
> >--- /dev/null
> >+++ b/meta-arago-test/recipes-graphics/libsdl2/libsdl2-ti.inc
> >@@ -0,0 +1,5 @@
> >+EXTRA_OECMAKE:append = " -DSDL_TESTS=ON \
> >+                         -DSDL_INSTALL_TESTS=ON \
> >+                       "
> >+PACKAGE_BEFORE_PN = "${PN}-tests"
> >+FILES:${PN}-tests += "${libexecdir} /usr/share/installed-tests/SDL2"
> 
> 
> I'm getting QA errors related to nativesdk-libsdl2.  I had to change
> the above line to this:
> 
> FILES:${PN}-tests:append = " ${datadir}/installed-tests/SDL2"
> FILES:${PN}-tests:append:class-nativesdk = " ${datadir}/installed-tests/SDL2"

Aren't those 2 the same? Wouldn't BBCLASSEXTEND handle it normally?

Can you post the QA errors you were seeing?


> The libexecdir was not needed, and I changed the /usr/share to use
> the correct variable (datadir) in case someone wants to change the
> directory names in the Yocto manner.  I moved to append just so that
> the two lines looked the same.
> 
> I know this is also being submitted upstream, so these changes might
> be needed for those patches as well.
> 
> 
> >diff --git a/meta-arago-test/recipes-graphics/libsdl2/libsdl2_%.bbappend b/meta-arago-test/recipes-graphics/libsdl2/libsdl2_%.bbappend
> >new file mode 100644
> >index 00000000..385aa801
> >--- /dev/null
> >+++ b/meta-arago-test/recipes-graphics/libsdl2/libsdl2_%.bbappend
> >@@ -0,0 +1,4 @@
> >+LIBSDL2_TI = ""
> >+LIBSDL2_TI:ti-soc = "libsdl2-ti.inc"
> >+
> >+require ${LIBSDL2_TI}
Ryan Eatmon Sept. 19, 2025, 9:08 p.m. UTC | #4 
On 9/19/2025 2:54 PM, Denys Dmytriyenko wrote:
> On Thu, Sep 18, 2025 at 08:51:53AM -0500, Ryan Eatmon via lists.yoctoproject.org wrote:
>>
>>
>> On 9/17/2025 5:08 PM, a-christidis@ti.com wrote:
>>> From: Antonios Christidis <a-christidis@ti.com>
>>>
>>> The software provides tests, configure cmake to build and install them.
>>> Package the tests in -tests package.
>>>
>>> Signed-off-by: Antonios Christidis <a-christidis@ti.com>
>>> ---
>>>   meta-arago-test/recipes-graphics/libsdl2/libsdl2-ti.inc     | 5 +++++
>>>   meta-arago-test/recipes-graphics/libsdl2/libsdl2_%.bbappend | 4 ++++
>>>   2 files changed, 9 insertions(+)
>>>   create mode 100644 meta-arago-test/recipes-graphics/libsdl2/libsdl2-ti.inc
>>>   create mode 100644 meta-arago-test/recipes-graphics/libsdl2/libsdl2_%.bbappend
>>>
>>> diff --git a/meta-arago-test/recipes-graphics/libsdl2/libsdl2-ti.inc b/meta-arago-test/recipes-graphics/libsdl2/libsdl2-ti.inc
>>> new file mode 100644
>>> index 00000000..12e06295
>>> --- /dev/null
>>> +++ b/meta-arago-test/recipes-graphics/libsdl2/libsdl2-ti.inc
>>> @@ -0,0 +1,5 @@
>>> +EXTRA_OECMAKE:append = " -DSDL_TESTS=ON \
>>> +                         -DSDL_INSTALL_TESTS=ON \
>>> +                       "
>>> +PACKAGE_BEFORE_PN = "${PN}-tests"
>>> +FILES:${PN}-tests += "${libexecdir} /usr/share/installed-tests/SDL2"
>>
>>
>> I'm getting QA errors related to nativesdk-libsdl2.  I had to change
>> the above line to this:
>>
>> FILES:${PN}-tests:append = " ${datadir}/installed-tests/SDL2"
>> FILES:${PN}-tests:append:class-nativesdk = " ${datadir}/installed-tests/SDL2"
> 
> Aren't those 2 the same? Wouldn't BBCLASSEXTEND handle it normally?

I would have thought so, but it didn't.

> Can you post the QA errors you were seeing?

I'll have to rebuild without the fix to regenerate the errors...  I'll 
try and do this Monday.

> 
>> The libexecdir was not needed, and I changed the /usr/share to use
>> the correct variable (datadir) in case someone wants to change the
>> directory names in the Yocto manner.  I moved to append just so that
>> the two lines looked the same.
>>
>> I know this is also being submitted upstream, so these changes might
>> be needed for those patches as well.
>>
>>
>>> diff --git a/meta-arago-test/recipes-graphics/libsdl2/libsdl2_%.bbappend b/meta-arago-test/recipes-graphics/libsdl2/libsdl2_%.bbappend
>>> new file mode 100644
>>> index 00000000..385aa801
>>> --- /dev/null
>>> +++ b/meta-arago-test/recipes-graphics/libsdl2/libsdl2_%.bbappend
>>> @@ -0,0 +1,4 @@
>>> +LIBSDL2_TI = ""
>>> +LIBSDL2_TI:ti-soc = "libsdl2-ti.inc"
>>> +
>>> +require ${LIBSDL2_TI}
diff mbox series

Patch

diff --git a/meta-arago-test/recipes-graphics/libsdl2/libsdl2-ti.inc b/meta-arago-test/recipes-graphics/libsdl2/libsdl2-ti.inc
new file mode 100644
index 00000000..12e06295
--- /dev/null
+++ b/meta-arago-test/recipes-graphics/libsdl2/libsdl2-ti.inc
@@ -0,0 +1,5 @@ 
+EXTRA_OECMAKE:append = " -DSDL_TESTS=ON \
+                         -DSDL_INSTALL_TESTS=ON \
+                       "
+PACKAGE_BEFORE_PN = "${PN}-tests"
+FILES:${PN}-tests += "${libexecdir} /usr/share/installed-tests/SDL2"
diff --git a/meta-arago-test/recipes-graphics/libsdl2/libsdl2_%.bbappend b/meta-arago-test/recipes-graphics/libsdl2/libsdl2_%.bbappend
new file mode 100644
index 00000000..385aa801
--- /dev/null
+++ b/meta-arago-test/recipes-graphics/libsdl2/libsdl2_%.bbappend
@@ -0,0 +1,4 @@ 
+LIBSDL2_TI = ""
+LIBSDL2_TI:ti-soc = "libsdl2-ti.inc"
+
+require ${LIBSDL2_TI}