Message ID | 20250905233849.2506703-3-a-christidis@ti.com |
---|---|
State | Superseded |
Delegated to: | Ryan Eatmon |
Headers | show |
Series | opencl-clhpp v2.0.16 -> v2024.05.08 | expand |
Please don't use "meta-arago-test: recipes-extended:" prefix in the commit summary (Subject) - it's very high level and absolutely useless. The convention that OE layers use is to specify the "area:", which is usually the name of the recipe for a single change, or a common name for multiple changes in the same commit, e.g. "conf/machine:" or even "opencl:" here. So, this would change current subject "meta-arago-test: recipes-extended: Specify correct PV for OCL C headers" into "opencl-headers: specify correct PV" And for #3: "opencl-clhpp: update v2.0.16 -> v2024.05.08" In other words, instead of doing this: "blah: blah: blah: do foo for bar" do this: "bar: do foo" On Fri, Sep 05, 2025 at 06:38:48PM -0500, Antonios Christidis via lists.yoctoproject.org wrote: > From: Antonios Christidis <a-christidis@ti.com> > > With the .bbappend and .inc file, the version of the headers is > increased. So, specify the correct PV of the headers. > > Signed-off-by: Antonios Christidis <a-christidis@ti.com> > --- > meta-arago-test/recipes-extended/opencl/opencl_headers-ti.inc | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/meta-arago-test/recipes-extended/opencl/opencl_headers-ti.inc b/meta-arago-test/recipes-extended/opencl/opencl_headers-ti.inc > index 48335204..1216adf5 100644 > --- a/meta-arago-test/recipes-extended/opencl/opencl_headers-ti.inc > +++ b/meta-arago-test/recipes-extended/opencl/opencl_headers-ti.inc > @@ -1,6 +1,7 @@ > inherit cmake > > SRCREV = "8275634cf9ec31b6484c2e6be756237cb583999d" > +PV = "2024.05.08" > > EXTRA_OECMAKE = "-DBUILD_TESTING=OFF" > > -- > 2.34.1
On 9/8/2025 10:21 AM, Denys Dmytriyenko wrote: > Please don't use "meta-arago-test: recipes-extended:" prefix in the commit > summary (Subject) - it's very high level and absolutely useless. > > The convention that OE layers use is to specify the "area:", which is usually > the name of the recipe for a single change, or a common name for multiple > changes in the same commit, e.g. "conf/machine:" or even "opencl:" here. > > So, this would change current subject > > "meta-arago-test: recipes-extended: Specify correct PV for OCL C headers" > > into > > "opencl-headers: specify correct PV" > > And for #3: > > "opencl-clhpp: update v2.0.16 -> v2024.05.08" > > In other words, instead of doing this: > > "blah: blah: blah: do foo for bar" > > do this: > > "bar: do foo" I need to add a check to the PRC to flag this kind of thing. I agree this level of subject tagging is not needed or desired. > > On Fri, Sep 05, 2025 at 06:38:48PM -0500, Antonios Christidis via lists.yoctoproject.org wrote: >> From: Antonios Christidis <a-christidis@ti.com> >> >> With the .bbappend and .inc file, the version of the headers is >> increased. So, specify the correct PV of the headers. >> >> Signed-off-by: Antonios Christidis <a-christidis@ti.com> >> --- >> meta-arago-test/recipes-extended/opencl/opencl_headers-ti.inc | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/meta-arago-test/recipes-extended/opencl/opencl_headers-ti.inc b/meta-arago-test/recipes-extended/opencl/opencl_headers-ti.inc >> index 48335204..1216adf5 100644 >> --- a/meta-arago-test/recipes-extended/opencl/opencl_headers-ti.inc >> +++ b/meta-arago-test/recipes-extended/opencl/opencl_headers-ti.inc >> @@ -1,6 +1,7 @@ >> inherit cmake >> >> SRCREV = "8275634cf9ec31b6484c2e6be756237cb583999d" >> +PV = "2024.05.08" >> >> EXTRA_OECMAKE = "-DBUILD_TESTING=OFF" >> >> -- >> 2.34.1
diff --git a/meta-arago-test/recipes-extended/opencl/opencl_headers-ti.inc b/meta-arago-test/recipes-extended/opencl/opencl_headers-ti.inc index 48335204..1216adf5 100644 --- a/meta-arago-test/recipes-extended/opencl/opencl_headers-ti.inc +++ b/meta-arago-test/recipes-extended/opencl/opencl_headers-ti.inc @@ -1,6 +1,7 @@ inherit cmake SRCREV = "8275634cf9ec31b6484c2e6be756237cb583999d" +PV = "2024.05.08" EXTRA_OECMAKE = "-DBUILD_TESTING=OFF"