diff mbox series

[ptest-runner] main.print_usage: Remove unused argument list of -l

Message ID 036b0e6d97c28f21acc8a3fa855240b24e2d850c.1751552135.git.joerg.sommer@navimatix.de
State New
Headers show
Series [ptest-runner] main.print_usage: Remove unused argument list of -l | expand

Commit Message

Jörg Sommer July 3, 2025, 2:15 p.m. UTC 
From: Natalie Dobrick <nata.dobrick@gmail.com>

Removed unused argument 'list' from usage message because the
option -l does not take an argument according to the *get_opt*
specification and *print_list* gets nothing passed, too.

Signed-off-by: Natalie Dobrick <nata.dobrick@gmail.com>
Signed-off-by: Jörg Sommer <joerg.sommer@navimatix.de>
---
 main.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Anibal Limon July 3, 2025, 3:17 p.m. UTC | #1 
Hi Jörg,

I will apply this patch!,

Cheers!,
Anibal

On Thu, Jul 3, 2025 at 8:15 AM Jörg Sommer <joerg.sommer@navimatix.de>
wrote:

> From: Natalie Dobrick <nata.dobrick@gmail.com>
>
> Removed unused argument 'list' from usage message because the
> option -l does not take an argument according to the *get_opt*
> specification and *print_list* gets nothing passed, too.
>
> Signed-off-by: Natalie Dobrick <nata.dobrick@gmail.com>
> Signed-off-by: Jörg Sommer <joerg.sommer@navimatix.de>
> ---
>  main.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/main.c b/main.c
> index 31e4dd5..feb0685 100644
> --- a/main.c
> +++ b/main.c
> @@ -47,7 +47,7 @@
>  static inline void
>  print_usage(FILE *stream, char *progname)
>  {
> -       fprintf(stream, "Usage: %s [-d directory directory2 ...] [-e
> exclude] [-l list] [-t timeout]"
> +       fprintf(stream, "Usage: %s [-d directory directory2 ...] [-e
> exclude] [-l] [-t timeout]"
>                         " [-x xml-filename] [-h] [ptest1 ptest2 ...]\n",
> progname);
>  }
>
> --
> 2.48.1
>
>
Jörg Sommer July 3, 2025, 6:06 p.m. UTC | #2 
Anibal Limon schrieb am Do 03. Jul, 09:17 (-0600):
> Hi Jörg,
> 
> I will apply this patch!,

Hi Anibal,

thank you. How do you think about a full help message with -h to describe
each option? Would this be useful?

And a different issue: currently, ptest-runner fails, if no tests are
installed or left after exclusion (of expensive tests). Would it be okay to
add an option to successfully exit in this case? We run ptests in a
build/test pipeline and don't know in advance, if there are (useful) ptests
in the image.


Regards, Jörg
diff mbox series

Patch

diff --git a/main.c b/main.c
index 31e4dd5..feb0685 100644
--- a/main.c
+++ b/main.c
@@ -47,7 +47,7 @@ 
 static inline void
 print_usage(FILE *stream, char *progname)
 {
-	fprintf(stream, "Usage: %s [-d directory directory2 ...] [-e exclude] [-l list] [-t timeout]"
+	fprintf(stream, "Usage: %s [-d directory directory2 ...] [-e exclude] [-l] [-t timeout]"
 			" [-x xml-filename] [-h] [ptest1 ptest2 ...]\n", progname);
 }