| Message ID | 20250623191048.488812-1-alperyasinak1@gmail.com |
|---|---|
| State | New |
| Headers | show |
| Series | [meta-oe] tk: Fix compile error | expand |
Could the variable PV not be used in the directory name to replace the hard code version number? Br On Mon, Jun 23, 2025 at 9:11 PM Alper Ak via lists.openembedded.org <alperyasinak1=gmail.com@lists.openembedded.org> wrote: > > tk9.0.1/unix/../generic/tk.h:19:10: fatal error: tcl.h: No such file or directory > | 19 | #include <tcl.h> > | | ^~~~~~~ > > Signed-off-by: Alper Ak <alperyasinak1@gmail.com> > --- > meta-oe/recipes-devtools/tcltk/tk_9.0.1.bb | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/meta-oe/recipes-devtools/tcltk/tk_9.0.1.bb b/meta-oe/recipes-devtools/tcltk/tk_9.0.1.bb > index 504b40927e..230a244a6b 100644 > --- a/meta-oe/recipes-devtools/tcltk/tk_9.0.1.bb > +++ b/meta-oe/recipes-devtools/tcltk/tk_9.0.1.bb > @@ -30,6 +30,8 @@ S = "${UNPACKDIR}/${BPN}${PV}" > # Short version format: "8.6" > VER = "${@os.path.splitext(d.getVar('PV'))[0]}" > > +CFLAGS += "-I${STAGING_INCDIR}/tcl9.0.1/generic" > + > LDFLAGS += "-Wl,-rpath,${libdir}/tcltk/${PV}/lib" > > inherit autotools features_check pkgconfig > -- > 2.43.0 > > > -=-=-=-=-=-=-=-=-=-=-=- > Links: You receive all messages sent to this group. > View/Reply Online (#118088): https://lists.openembedded.org/g/openembedded-devel/message/118088 > Mute This Topic: https://lists.openembedded.org/mt/113794949/2167232 > Group Owner: openembedded-devel+owner@lists.openembedded.org > Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [jan.vermaete@gmail.com] > -=-=-=-=-=-=-=-=-=-=-=- >
I thought about using PV, but if tcl and tk can be upgraded independently (tcl recipe is in poky, tk is in meta-oe), this may cause failures if tcl is upgraded without upgrading tk. That's why I preferred to hard code the version. If there is a better way to handle this, I’m open to suggestions. jan vermaete <jan.vermaete@gmail.com>, 23 Haz 2025 Pzt, 22:45 tarihinde şunu yazdı: > > Could the variable PV not be used in the directory name to replace the > hard code version number? > > Br > > On Mon, Jun 23, 2025 at 9:11 PM Alper Ak via lists.openembedded.org > <alperyasinak1=gmail.com@lists.openembedded.org> wrote: > > > > tk9.0.1/unix/../generic/tk.h:19:10: fatal error: tcl.h: No such file or directory > > | 19 | #include <tcl.h> > > | | ^~~~~~~ > > > > Signed-off-by: Alper Ak <alperyasinak1@gmail.com> > > --- > > meta-oe/recipes-devtools/tcltk/tk_9.0.1.bb | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/meta-oe/recipes-devtools/tcltk/tk_9.0.1.bb b/meta-oe/recipes-devtools/tcltk/tk_9.0.1.bb > > index 504b40927e..230a244a6b 100644 > > --- a/meta-oe/recipes-devtools/tcltk/tk_9.0.1.bb > > +++ b/meta-oe/recipes-devtools/tcltk/tk_9.0.1.bb > > @@ -30,6 +30,8 @@ S = "${UNPACKDIR}/${BPN}${PV}" > > # Short version format: "8.6" > > VER = "${@os.path.splitext(d.getVar('PV'))[0]}" > > > > +CFLAGS += "-I${STAGING_INCDIR}/tcl9.0.1/generic" > > + > > LDFLAGS += "-Wl,-rpath,${libdir}/tcltk/${PV}/lib" > > > > inherit autotools features_check pkgconfig > > -- > > 2.43.0 > > > > > > -=-=-=-=-=-=-=-=-=-=-=- > > Links: You receive all messages sent to this group. > > View/Reply Online (#118088): https://lists.openembedded.org/g/openembedded-devel/message/118088 > > Mute This Topic: https://lists.openembedded.org/mt/113794949/2167232 > > Group Owner: openembedded-devel+owner@lists.openembedded.org > > Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [jan.vermaete@gmail.com] > > -=-=-=-=-=-=-=-=-=-=-=- > > > > > -- > Jan Vermaete > “Success is a self-correcting phenomenom.” -- Gary Hamel
Good point. I didn’t touch about the split of TCL and TK. Jan Vermaete “Success is a self-correcting phenomenom.” -- Gary Hamel On Mon, 23 Jun 2025 at 22:17, Alper Ak <alperyasinak1@gmail.com> wrote: > I thought about using PV, but if tcl and tk can be upgraded > independently (tcl recipe is in poky, tk is in meta-oe), this may > cause failures if tcl is upgraded without upgrading tk. That's why I > preferred to hard code the version. > > If there is a better way to handle this, I’m open to suggestions. > > jan vermaete <jan.vermaete@gmail.com>, 23 Haz 2025 Pzt, 22:45 > tarihinde şunu yazdı: > > > > Could the variable PV not be used in the directory name to replace the > > hard code version number? > > > > Br > > > > On Mon, Jun 23, 2025 at 9:11 PM Alper Ak via lists.openembedded.org > > <alperyasinak1=gmail.com@lists.openembedded.org> wrote: > > > > > > tk9.0.1/unix/../generic/tk.h:19:10: fatal error: tcl.h: No such file > or directory > > > | 19 | #include <tcl.h> > > > | | ^~~~~~~ > > > > > > Signed-off-by: Alper Ak <alperyasinak1@gmail.com> > > > --- > > > meta-oe/recipes-devtools/tcltk/tk_9.0.1.bb | 2 ++ > > > 1 file changed, 2 insertions(+) > > > > > > diff --git a/meta-oe/recipes-devtools/tcltk/tk_9.0.1.bb > b/meta-oe/recipes-devtools/tcltk/tk_9.0.1.bb > > > index 504b40927e..230a244a6b 100644 > > > --- a/meta-oe/recipes-devtools/tcltk/tk_9.0.1.bb > > > +++ b/meta-oe/recipes-devtools/tcltk/tk_9.0.1.bb > > > @@ -30,6 +30,8 @@ S = "${UNPACKDIR}/${BPN}${PV}" > > > # Short version format: "8.6" > > > VER = "${@os.path.splitext(d.getVar('PV'))[0]}" > > > > > > +CFLAGS += "-I${STAGING_INCDIR}/tcl9.0.1/generic" > > > + > > > LDFLAGS += "-Wl,-rpath,${libdir}/tcltk/${PV}/lib" > > > > > > inherit autotools features_check pkgconfig > > > -- > > > 2.43.0 > > > > > > > > > -=-=-=-=-=-=-=-=-=-=-=- > > > Links: You receive all messages sent to this group. > > > View/Reply Online (#118088): > https://lists.openembedded.org/g/openembedded-devel/message/118088 > > > Mute This Topic: https://lists.openembedded.org/mt/113794949/2167232 > > > Group Owner: openembedded-devel+owner@lists.openembedded.org > > > Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub > [jan.vermaete@gmail.com] > > > -=-=-=-=-=-=-=-=-=-=-=- > > > > > > > > > -- > > Jan Vermaete > > “Success is a self-correcting phenomenom.” -- Gary Hamel >
Hello, Le lun. 23 juin 2025 à 22:17, Alper Ak via lists.openembedded.org <alperyasinak1=gmail.com@lists.openembedded.org> a écrit : > I thought about using PV, but if tcl and tk can be upgraded > independently (tcl recipe is in poky, tk is in meta-oe), this may > cause failures if tcl is upgraded without upgrading tk. That's why I > preferred to hard code the version. > > If there is a better way to handle this, I’m open to suggestions. > I see that the tk recipe uses the pkgconfig class, theoretically, that's the way for tcl to tell tk where to find its headers. Regards, > jan vermaete <jan.vermaete@gmail.com>, 23 Haz 2025 Pzt, 22:45 > tarihinde şunu yazdı: > > > > Could the variable PV not be used in the directory name to replace the > > hard code version number? > > > > Br > > > > On Mon, Jun 23, 2025 at 9:11 PM Alper Ak via lists.openembedded.org > > <alperyasinak1=gmail.com@lists.openembedded.org> wrote: > > > > > > tk9.0.1/unix/../generic/tk.h:19:10: fatal error: tcl.h: No such file > or directory > > > | 19 | #include <tcl.h> > > > | | ^~~~~~~ > > > > > > Signed-off-by: Alper Ak <alperyasinak1@gmail.com> > > > --- > > > meta-oe/recipes-devtools/tcltk/tk_9.0.1.bb | 2 ++ > > > 1 file changed, 2 insertions(+) > > > > > > diff --git a/meta-oe/recipes-devtools/tcltk/tk_9.0.1.bb > b/meta-oe/recipes-devtools/tcltk/tk_9.0.1.bb > > > index 504b40927e..230a244a6b 100644 > > > --- a/meta-oe/recipes-devtools/tcltk/tk_9.0.1.bb > > > +++ b/meta-oe/recipes-devtools/tcltk/tk_9.0.1.bb > > > @@ -30,6 +30,8 @@ S = "${UNPACKDIR}/${BPN}${PV}" > > > # Short version format: "8.6" > > > VER = "${@os.path.splitext(d.getVar('PV'))[0]}" > > > > > > +CFLAGS += "-I${STAGING_INCDIR}/tcl9.0.1/generic" > > > + > > > LDFLAGS += "-Wl,-rpath,${libdir}/tcltk/${PV}/lib" > > > > > > inherit autotools features_check pkgconfig > > > -- > > > 2.43.0 > > > > > > > > > > > > > > > > > > -- > > Jan Vermaete > > “Success is a self-correcting phenomenom.” -- Gary Hamel > > -=-=-=-=-=-=-=-=-=-=-=- > Links: You receive all messages sent to this group. > View/Reply Online (#118091): > https://lists.openembedded.org/g/openembedded-devel/message/118091 > Mute This Topic: https://lists.openembedded.org/mt/113794949/4316185 > Group Owner: openembedded-devel+owner@lists.openembedded.org > Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [ > yoann.congal@smile.fr] > -=-=-=-=-=-=-=-=-=-=-=- > >
diff --git a/meta-oe/recipes-devtools/tcltk/tk_9.0.1.bb b/meta-oe/recipes-devtools/tcltk/tk_9.0.1.bb index 504b40927e..230a244a6b 100644 --- a/meta-oe/recipes-devtools/tcltk/tk_9.0.1.bb +++ b/meta-oe/recipes-devtools/tcltk/tk_9.0.1.bb @@ -30,6 +30,8 @@ S = "${UNPACKDIR}/${BPN}${PV}" # Short version format: "8.6" VER = "${@os.path.splitext(d.getVar('PV'))[0]}" +CFLAGS += "-I${STAGING_INCDIR}/tcl9.0.1/generic" + LDFLAGS += "-Wl,-rpath,${libdir}/tcltk/${PV}/lib" inherit autotools features_check pkgconfig
tk9.0.1/unix/../generic/tk.h:19:10: fatal error: tcl.h: No such file or directory | 19 | #include <tcl.h> | | ^~~~~~~ Signed-off-by: Alper Ak <alperyasinak1@gmail.com> --- meta-oe/recipes-devtools/tcltk/tk_9.0.1.bb | 2 ++ 1 file changed, 2 insertions(+)