| Message ID | 20250523114923.2206133-1-robbin.vandamme@renson.be |
|---|---|
| State | New |
| Headers | show |
| Series | Add ? to mark the start of the AZ_SAS query parameters | expand |
Hi Robbin, Thanks for the patch. But.. why this patch? Please provide a commit log explaining why this is necessary or what kind of additional feature this provides. Additionally, if this actually fixes a bug, a test would be most welcome so it doesn't get reintroduced later on. If it's a new feature, a test would be nice as well. We're also missing your Signed-off-by here, c.f. https://docs.yoctoproject.org/contributor-guide/submit-changes.html#implement-and-commit-changes which signifies the submitter agrees to the Developer's Certificate of Origin. Cheers, Quentin On 5/23/25 1:49 PM, robbin van damme via lists.openembedded.org wrote: > --- > lib/bb/fetch2/az.py | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/lib/bb/fetch2/az.py b/lib/bb/fetch2/az.py > index 346124a8b..327273379 100644 > --- a/lib/bb/fetch2/az.py > +++ b/lib/bb/fetch2/az.py > @@ -36,7 +36,7 @@ class Az(Wget): > > az_sas = d.getVar('AZ_SAS') > if az_sas and az_sas not in ud.url: > - ud.url += az_sas > + ud.url += f'?{az_sas}' > > return Wget.checkstatus(self, fetch, ud, d, try_again) > > @@ -62,7 +62,7 @@ class Az(Wget): > az_sas = d.getVar('AZ_SAS') > > if az_sas: > - azuri = '%s%s%s%s' % ('https://', ud.host, ud.path, az_sas) > + azuri = '%s%s%s?%s' % ('https://', ud.host, ud.path, az_sas) > else: > azuri = '%s%s%s' % ('https://', ud.host, ud.path) > > > > > -=-=-=-=-=-=-=-=-=-=-=- > Links: You receive all messages sent to this group. > View/Reply Online (#17632): https://lists.openembedded.org/g/bitbake-devel/message/17632 > Mute This Topic: https://lists.openembedded.org/mt/113263422/6293953 > Group Owner: bitbake-devel+owner@lists.openembedded.org > Unsubscribe: https://lists.openembedded.org/g/bitbake-devel/unsub [quentin.schulz@cherry.de] > -=-=-=-=-=-=-=-=-=-=-=- >
On Fri, 2025-05-23 at 13:49 +0200, robbin van damme via lists.openembedded.org wrote: > --- > lib/bb/fetch2/az.py | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/lib/bb/fetch2/az.py b/lib/bb/fetch2/az.py > index 346124a8b..327273379 100644 > --- a/lib/bb/fetch2/az.py > +++ b/lib/bb/fetch2/az.py > @@ -36,7 +36,7 @@ class Az(Wget): > > az_sas = d.getVar('AZ_SAS') > if az_sas and az_sas not in ud.url: > - ud.url += az_sas > + ud.url += f'?{az_sas}' > > return Wget.checkstatus(self, fetch, ud, d, try_again) > > @@ -62,7 +62,7 @@ class Az(Wget): > az_sas = d.getVar('AZ_SAS') > > if az_sas: > - azuri = '%s%s%s%s' % ('https://', ud.host, ud.path, az_sas) > + azuri = '%s%s%s?%s' % ('https://', ud.host, ud.path, az_sas) > else: > azuri = '%s%s%s' % ('https://', ud.host, ud.path) This definitely needs an explaination in the commit message about what is breaking, why and how this fixes it. There also isn't a Signed-off- by line. Cheers, Richard
diff --git a/lib/bb/fetch2/az.py b/lib/bb/fetch2/az.py index 346124a8b..327273379 100644 --- a/lib/bb/fetch2/az.py +++ b/lib/bb/fetch2/az.py @@ -36,7 +36,7 @@ class Az(Wget): az_sas = d.getVar('AZ_SAS') if az_sas and az_sas not in ud.url: - ud.url += az_sas + ud.url += f'?{az_sas}' return Wget.checkstatus(self, fetch, ud, d, try_again) @@ -62,7 +62,7 @@ class Az(Wget): az_sas = d.getVar('AZ_SAS') if az_sas: - azuri = '%s%s%s%s' % ('https://', ud.host, ud.path, az_sas) + azuri = '%s%s%s?%s' % ('https://', ud.host, ud.path, az_sas) else: azuri = '%s%s%s' % ('https://', ud.host, ud.path)