| Message ID | 20250311165146.3713480-1-denis@denix.org |
|---|---|
| State | Superseded |
| Delegated to: | Ryan Eatmon |
| Headers | show |
| Series | [master/scarthgap] open62541: fix examples binaries packaging | expand |
On 3/11/2025 11:51 AM, Denys Dmytriyenko wrote: > From: Denys Dmytriyenko <denys@konsulko.com> > > Recent update in upstream meta-oe changed FILES list to only include > libraries, which is correct when no examples are built. Our bbappend > enables building examples and those are placed into own directory. > But there are 2 exceptions where ua_client and ua_server are placed > under ${bindir} and now those trigger a QA error about unpackaged > files. While these 2 files should probably go along with other example > binaries, for now restore the previous behavior of packaging them > into ${bindir} in case some downstream usage expects them there. Thanks! I was going to look into this today. > Signed-off-by: Denys Dmytriyenko <denys@konsulko.com> > --- > .../recipes-connectivity/open62541/open62541-arago.inc | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/meta-arago-extras/recipes-connectivity/open62541/open62541-arago.inc b/meta-arago-extras/recipes-connectivity/open62541/open62541-arago.inc > index 3d72f0e9..745c88a1 100644 > --- a/meta-arago-extras/recipes-connectivity/open62541/open62541-arago.inc > +++ b/meta-arago-extras/recipes-connectivity/open62541/open62541-arago.inc > @@ -28,6 +28,7 @@ do_install:append() { > } > > PACKAGES =+ "${PN}-examples ${PN}-tests" > +FILES:${PN} += "${bindir}" > FILES:${PN}-dev += "${libdir}/cmake/* ${datadir}/${BPN}/tools" > FILES:${PN}-examples += "${datadir}/${BPN}/examples" > FILES:${PN}-tests += "${datadir}/${BPN}/tests"
On 3/11/2025 11:51 AM, Denys Dmytriyenko wrote: > From: Denys Dmytriyenko <denys@konsulko.com> > > Recent update in upstream meta-oe changed FILES list to only include > libraries, which is correct when no examples are built. Our bbappend > enables building examples and those are placed into own directory. > But there are 2 exceptions where ua_client and ua_server are placed > under ${bindir} and now those trigger a QA error about unpackaged > files. While these 2 files should probably go along with other example > binaries, for now restore the previous behavior of packaging them > into ${bindir} in case some downstream usage expects them there. > > Signed-off-by: Denys Dmytriyenko <denys@konsulko.com> > --- > .../recipes-connectivity/open62541/open62541-arago.inc | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/meta-arago-extras/recipes-connectivity/open62541/open62541-arago.inc b/meta-arago-extras/recipes-connectivity/open62541/open62541-arago.inc > index 3d72f0e9..745c88a1 100644 > --- a/meta-arago-extras/recipes-connectivity/open62541/open62541-arago.inc > +++ b/meta-arago-extras/recipes-connectivity/open62541/open62541-arago.inc Ah. I see you are making this change against master-wip. master and scarthgap do not have that change yet as it is still cooking. I'm going to send a v2 to move this patch over to the .bbappend so that we can pick this up right now and then rebase master-wip on top of it. > @@ -28,6 +28,7 @@ do_install:append() { > } > > PACKAGES =+ "${PN}-examples ${PN}-tests" > +FILES:${PN} += "${bindir}" > FILES:${PN}-dev += "${libdir}/cmake/* ${datadir}/${BPN}/tools" > FILES:${PN}-examples += "${datadir}/${BPN}/examples" > FILES:${PN}-tests += "${datadir}/${BPN}/tests"
diff --git a/meta-arago-extras/recipes-connectivity/open62541/open62541-arago.inc b/meta-arago-extras/recipes-connectivity/open62541/open62541-arago.inc index 3d72f0e9..745c88a1 100644 --- a/meta-arago-extras/recipes-connectivity/open62541/open62541-arago.inc +++ b/meta-arago-extras/recipes-connectivity/open62541/open62541-arago.inc @@ -28,6 +28,7 @@ do_install:append() { } PACKAGES =+ "${PN}-examples ${PN}-tests" +FILES:${PN} += "${bindir}" FILES:${PN}-dev += "${libdir}/cmake/* ${datadir}/${BPN}/tools" FILES:${PN}-examples += "${datadir}/${BPN}/examples" FILES:${PN}-tests += "${datadir}/${BPN}/tests"