| Message ID | 20250228130137.400-3-eric.meyers@arthrex.com |
|---|---|
| State | Accepted, archived |
| Commit | d5562e007c7c64e8613a118ab9a6c73ed2063263 |
| Headers | show |
| Series | NPM Fetcher Private Registry Authentication Support: | expand |
On Fri, Feb 28, 2025 at 5:01 AM Eric Meyers <eric.meyers15310@gmail.com> wrote: > Signed-off-by: Eric Meyers <eric.meyers@arthrex.com> > Cc: Geoff Parker <geoffrey.parker@arthrex.com> > Cc: Chuck Wolber <chuckwolber@gmail.com> > --- > .../bitbake-user-manual-ref-variables.rst | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/doc/bitbake-user-manual/bitbake-user-manual-ref-variables.rst > b/doc/bitbake-user-manual/bitbake-user-manual-ref-variables.rst > index 858de6347..00300d0d8 100644 > --- a/doc/bitbake-user-manual/bitbake-user-manual-ref-variables.rst > +++ b/doc/bitbake-user-manual/bitbake-user-manual-ref-variables.rst > @@ -692,6 +692,12 @@ overview of their function and contents. > Within an executing task, this variable holds the hash of the task > as > returned by the currently enabled signature generator. > > + :term:`BB_USE_HOME_NPMRC` > + Controls whether or not BitBake uses the user's .npmrc file within > their > + home directory within the npm fetcher. This can be used for > authentication > + of private NPM registries, among other uses. This is turned off by > default > + and requires the user to explicitly set it to "1" to enable. > + > :term:`BB_VERBOSE_LOGS` > Controls how verbose BitBake is during builds. If set, shell scripts > echo commands and shell script output appears on standard out > Signed-off-by: Chuck Wolber <chuckwolber@gmail.com> ..Ch:W..
On Fri, Feb 28, 2025 at 12:09 PM Chuck Wolber <chuckwolber@gmail.com> wrote: > On Fri, Feb 28, 2025 at 5:01 AM Eric Meyers <eric.meyers15310@gmail.com> > wrote: > >> Signed-off-by: Eric Meyers <eric.meyers@arthrex.com> >> Cc: Geoff Parker <geoffrey.parker@arthrex.com> >> Cc: Chuck Wolber <chuckwolber@gmail.com> >> --- >> .../bitbake-user-manual-ref-variables.rst | 6 ++++++ >> 1 file changed, 6 insertions(+) >> >> diff --git >> a/doc/bitbake-user-manual/bitbake-user-manual-ref-variables.rst >> b/doc/bitbake-user-manual/bitbake-user-manual-ref-variables.rst >> index 858de6347..00300d0d8 100644 >> --- a/doc/bitbake-user-manual/bitbake-user-manual-ref-variables.rst >> +++ b/doc/bitbake-user-manual/bitbake-user-manual-ref-variables.rst >> @@ -692,6 +692,12 @@ overview of their function and contents. >> Within an executing task, this variable holds the hash of the task >> as >> returned by the currently enabled signature generator. >> >> + :term:`BB_USE_HOME_NPMRC` >> + Controls whether or not BitBake uses the user's .npmrc file within >> their >> + home directory within the npm fetcher. This can be used for >> authentication >> + of private NPM registries, among other uses. This is turned off by >> default >> + and requires the user to explicitly set it to "1" to enable. >> + >> :term:`BB_VERBOSE_LOGS` >> Controls how verbose BitBake is during builds. If set, shell >> scripts >> echo commands and shell script output appears on standard out >> > > > Signed-off-by: Chuck Wolber <chuckwolber@gmail.com> > > ..Ch:W.. > Apologies if this isn't the correct process (this is my first time submitting a patch), but what's needed to merge this patch into master-next, then master? Thanks, -Eric
On Fri, Mar 7, 2025 at 9:17 AM Eric Meyers <eric.meyers15310@gmail.com> wrote: > > Apologies if this isn't the correct process (this is my first time > submitting a patch), but what's needed to merge this patch into > master-next, then master? > > For now, probably nothing, but it never hurts to do what you did and ask. The bitbake repo maintainers watch this list. Your patches show up in patchwork here: https://patchwork.yoctoproject.org/project/bitbake/list/ Just search for your name. Also, have you reviewed the contribution docs? https://docs.yoctoproject.org/dev/contributor-guide/submit-changes.html ..Ch:W..
On Fri, Mar 7, 2025 at 12:56 PM Chuck Wolber <chuckwolber@gmail.com> wrote: > On Fri, Mar 7, 2025 at 9:17 AM Eric Meyers <eric.meyers15310@gmail.com> > wrote: > >> >> Apologies if this isn't the correct process (this is my first time >> submitting a patch), but what's needed to merge this patch into >> master-next, then master? >> >> > For now, probably nothing, but it never hurts to do what you did and ask. > The > bitbake repo maintainers watch this list. > > Your patches show up in patchwork here: > https://patchwork.yoctoproject.org/project/bitbake/list/ > Just search for your name. > > Also, have you reviewed the contribution docs? > > https://docs.yoctoproject.org/dev/contributor-guide/submit-changes.html > > > ..Ch:W.. > > Yes, I have reviewed those, they are what helped me out with initially submitting the patch, I just wanted to poke this thread since the guidance was 2-3 days until it makes it into master-next. Anyways, I see the commits have been applied now: - https://github.com/openembedded/bitbake/commit/177395a4dee1b51380e61ffa8889588f81740bc0 - https://github.com/openembedded/bitbake/commit/23f3f16cf211f9a9db8914eeb82ccf131ac21b22 Thanks a ton! I will submit another patch for backporting this to the scarthgap version of bitbake (2.8) in the coming days. -Eric
On Sat, 2025-03-08 at 08:16 -0600, Eric Meyers via lists.openembedded.org wrote: > > > On Fri, Mar 7, 2025 at 12:56 PM Chuck Wolber <chuckwolber@gmail.com> > wrote: > > On Fri, Mar 7, 2025 at 9:17 AM Eric Meyers > > <eric.meyers15310@gmail.com> wrote: > > > > > > Apologies if this isn't the correct process (this is my first > > > time submitting a patch), but what's needed to merge this patch > > > into master-next, then master? > > > > > > > > > > > > For now, probably nothing, but it never hurts to do what you did > > and ask. The > > bitbake repo maintainers watch this list. > > > > Your patches show up in patchwork here: > > https://patchwork.yoctoproject.org/project/bitbake/list/ > > Just search for your name. > > > > Also, have you reviewed the contribution docs? > > > > https://docs.yoctoproject.org/dev/contributor-guide/submit-changes.html > > > > > > ..Ch:W.. > > > > > > > Yes, I have reviewed those, they are what helped me out with > initially submitting the patch, I just wanted to poke this thread > since the guidance was 2-3 days until it makes it into master-next. > > Anyways, I see the commits have been applied now: > > - > https://github.com/openembedded/bitbake/commit/177395a4dee1b51380e61ffa8889588f81740bc0 > - > https://github.com/openembedded/bitbake/commit/23f3f16cf211f9a9db891 > 4eeb82ccf131ac21b22 > > Thanks a ton! I will submit another patch for backporting this to the > scarthgap version of bitbake (2.8) in the coming days. They're in master-next, they haven't merged until they're in master. If you're looking at 2.8, they'll need to be backported to 2.10 first as per the stable release policies. One of the policies related to not backporting new features, this one is a bit borderline in that regard. Cheers, Richard
diff --git a/doc/bitbake-user-manual/bitbake-user-manual-ref-variables.rst b/doc/bitbake-user-manual/bitbake-user-manual-ref-variables.rst index 858de6347..00300d0d8 100644 --- a/doc/bitbake-user-manual/bitbake-user-manual-ref-variables.rst +++ b/doc/bitbake-user-manual/bitbake-user-manual-ref-variables.rst @@ -692,6 +692,12 @@ overview of their function and contents. Within an executing task, this variable holds the hash of the task as returned by the currently enabled signature generator. + :term:`BB_USE_HOME_NPMRC` + Controls whether or not BitBake uses the user's .npmrc file within their + home directory within the npm fetcher. This can be used for authentication + of private NPM registries, among other uses. This is turned off by default + and requires the user to explicitly set it to "1" to enable. + :term:`BB_VERBOSE_LOGS` Controls how verbose BitBake is during builds. If set, shell scripts echo commands and shell script output appears on standard out
Signed-off-by: Eric Meyers <eric.meyers@arthrex.com> Cc: Geoff Parker <geoffrey.parker@arthrex.com> Cc: Chuck Wolber <chuckwolber@gmail.com> --- .../bitbake-user-manual-ref-variables.rst | 6 ++++++ 1 file changed, 6 insertions(+)